[openstack-dev] What should I do for resolving Tempest Failure in jenkins?

2013-12-26 Thread 한승진
Hi all,

I requested to review code about no hpet option.

https://blueprints.launchpad.net/nova/+spec/add-no-hpet-option-into-guest-clock

I expected that the code is verified.

However, the code was failed for verifying tempest test.

https://review.openstack.org/#/c/63769/

Actually, this is because of not my source codes but other codes.

 I add review comments recheck bug 1254890. However, re failed.

In this case, I don't know I should I do.

Could you tell me what should I do for passing tempest test?
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] What should I do for resolving Tempest Failure in jenkins?

2013-12-26 Thread 柳东
Hi, in my experience, if it not caused by your code, recheck more times.


在 2013年12月26日,21:29,한승진 yongi...@gmail.com 写道:

 Hi all,
 
 I requested to review code about no hpet option.
 
 https://blueprints.launchpad.net/nova/+spec/add-no-hpet-option-into-guest-clock
 
 I expected that the code is verified.
 
 However, the code was failed for verifying tempest test.
 
 https://review.openstack.org/#/c/63769/
 
 Actually, this is because of not my source codes but other codes.
 
  I add review comments recheck bug 1254890. However, re failed.
 
 In this case, I don't know I should I do.
 
 Could you tell me what should I do for passing tempest test? 
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] What should I do for resolving Tempest Failure in jenkins?

2013-12-26 Thread Anita Kuno
Unfortunately this approach leads to forcing in code that may increase
the bug in question, which will affect all developers.

I suggest you evaluate the Jenkins logs carefully, and link to the
timestamp in the logs were the failure occurred, in a comment on your
patch. This enables reviewers to evaluate for themselves whether your
patch is a likely contributor towards the bug.

Be active in the irc channels for your project and for -qa. Ask in the
channel if someone else can review your patch to see if it may be
contributing to the bug.

Consider speaking with the people who have contributed comments to the
bug report as well as the person who is assigned to the bug, if there is
one. Perhaps your Jenkins logs might help the folks working on the bug
to identify the issue and offer a patch. You are also welcome and
encouraged to work on solving the bug.

It may be your patch is unrelated to the bug but your patch also might
be a contributing factor. Ask some other developers for their opinion on
your patch. Request that they comment on your patch to help other
reviewers as well.

Thanks,
Anita.

On 12/26/2013 01:24 PM, 柳东 wrote:
 Hi, in my experience, if it not caused by your code, recheck more times.
 
 
 在 2013年12月26日,21:29,한승진 yongi...@gmail.com 写道:
 
 Hi all,

 I requested to review code about no hpet option.

 https://blueprints.launchpad.net/nova/+spec/add-no-hpet-option-into-guest-clock

 I expected that the code is verified.

 However, the code was failed for verifying tempest test.

 https://review.openstack.org/#/c/63769/

 Actually, this is because of not my source codes but other codes.

  I add review comments recheck bug 1254890. However, re failed.

 In this case, I don't know I should I do.

 Could you tell me what should I do for passing tempest test? 
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
 
 
 
 
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
 


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] What should I do for resolving Tempest Failure in jenkins?

2013-12-26 Thread Clark Boylan
On Thu, Dec 26, 2013 at 10:50 AM, Anita Kuno ante...@anteaya.info wrote:
 Unfortunately this approach leads to forcing in code that may increase
 the bug in question, which will affect all developers.

 I suggest you evaluate the Jenkins logs carefully, and link to the
 timestamp in the logs were the failure occurred, in a comment on your
 patch. This enables reviewers to evaluate for themselves whether your
 patch is a likely contributor towards the bug.

 Be active in the irc channels for your project and for -qa. Ask in the
 channel if someone else can review your patch to see if it may be
 contributing to the bug.

 Consider speaking with the people who have contributed comments to the
 bug report as well as the person who is assigned to the bug, if there is
 one. Perhaps your Jenkins logs might help the folks working on the bug
 to identify the issue and offer a patch. You are also welcome and
 encouraged to work on solving the bug.

 It may be your patch is unrelated to the bug but your patch also might
 be a contributing factor. Ask some other developers for their opinion on
 your patch. Request that they comment on your patch to help other
 reviewers as well.

 Thanks,
 Anita.

 On 12/26/2013 01:24 PM, 柳东 wrote:
 Hi, in my experience, if it not caused by your code, recheck more times.


 在 2013年12月26日,21:29,한승진 yongi...@gmail.com 写道:

 Hi all,

 I requested to review code about no hpet option.

 https://blueprints.launchpad.net/nova/+spec/add-no-hpet-option-into-guest-clock

 I expected that the code is verified.

 However, the code was failed for verifying tempest test.

 https://review.openstack.org/#/c/63769/

 Actually, this is because of not my source codes but other codes.

  I add review comments recheck bug 1254890. However, re failed.

 In this case, I don't know I should I do.

 Could you tell me what should I do for passing tempest test?
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Worth noting that every Jenkins comment in Gerrit that posts a -1 or
-2 links to https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures
which contains information on what to do with test failures. If that
document is lacking in some way please give details and we can update
it (or feel free to update it yourself).

Clark

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev