Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-11-12 Thread Michael Bright
+1 also. I spent less than half the time on my first fix (so far) understanding the problem, reproducing it, coding it and learning about the code review system. Much more than half the time was spent on reverse engineering existing tests to be able to add new ones (which had to use features not

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-11-12 Thread Michael Bright
To be clear, that was a +1 for Mark's suggestion: In cases like that, I'd be of a mind to go +2 Awesome! Thanks for catching this! It would be great to have a unit test for this, but it's clear the current code is broken so I'm fine with merging the fix without a test. You could say it's now

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-11-11 Thread Vishvananda Ishaya
On Oct 31, 2013, at 6:56 AM, Clint Byrum cl...@fewbar.com wrote: Excerpts from Mark McLoughlin's message of 2013-10-31 06:30:32 -0700: On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote: This is a bit of a social norms thread I've been consistently asking for tests in reviews for

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-11-11 Thread Ed Leafe
On Nov 11, 2013, at 6:42 PM, Vishvananda Ishaya vishvana...@gmail.com wrote: It also gives the submitter a specific example of a well-written test, which can be a faster way to learn than forcing them to get there via trial and error. +1. Implementing a policy that has as the end effect more

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-11-01 Thread Rosa, Andrea (HP Cloud Services)
-Original Message- From: Chris Friesen [mailto:chris.frie...@windriver.com] Sent: 31 October 2013 17:07 To: openstack-dev@lists.openstack.org Subject: Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ? On 10/31/2013 06:04 AM, Rosa, Andrea (HP Cloud

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-11-01 Thread Khanh-Toan Tran
Hey thanks a lot! - Original Message - From: Clint Byrum cl...@fewbar.com To: openstack-dev openstack-dev@lists.openstack.org Sent: Thursday, October 31, 2013 7:49:55 PM Subject: Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ? Excerpts from

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Rosa, Andrea (HP Cloud Services)
Hi all, This is a bit of a social norms thread I've been consistently asking for tests in reviews for a while now, and I get the occasional push-back. I think this falls into a few broad camps: A - there is no test suite at all, adding one in unreasonable B - this thing cannot be tested

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Sean Dague
On 10/30/2013 10:37 PM, Robert Collins wrote: This is a bit of a social norms thread I've been consistently asking for tests in reviews for a while now, and I get the occasional push-back. I think this falls into a few broad camps: A - there is no test suite at all, adding one in

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Mark McLoughlin
On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote: This is a bit of a social norms thread I've been consistently asking for tests in reviews for a while now, and I get the occasional push-back. I think this falls into a few broad camps: A - there is no test suite at all, adding

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Clint Byrum
Excerpts from Mark McLoughlin's message of 2013-10-31 06:30:32 -0700: On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote: This is a bit of a social norms thread I've been consistently asking for tests in reviews for a while now, and I get the occasional push-back. I think this

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Kyle Mestery (kmestery)
On Oct 31, 2013, at 8:56 AM, Clint Byrum cl...@fewbar.com wrote: Excerpts from Mark McLoughlin's message of 2013-10-31 06:30:32 -0700: On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote: This is a bit of a social norms thread I've been consistently asking for tests in reviews for a

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Khanh-Toan Tran
Hi all, As a newbie of the community, I'm not familiar with unittest and how to use it here. I've learned that Jenkins runs tests everytime we submit some code. But how to write the test and what is a 'good test' and a 'bad test'? I saw some commits in gerrit but am unable to say if the written

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Chris Friesen
On 10/31/2013 06:04 AM, Rosa, Andrea (HP Cloud Services) wrote: A - there is no test suite at all, adding one in unreasonable B - this thing cannot be tested in this context (e.g. functional tests are defined in a different tree) C - this particular thing is very hard to test D - testing

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Ben Nemec
On 2013-10-31 09:05, Kyle Mestery (kmestery) wrote: On Oct 31, 2013, at 8:56 AM, Clint Byrum cl...@fewbar.com wrote: Excerpts from Mark McLoughlin's message of 2013-10-31 06:30:32 -0700: On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote: This is a bit of a social norms thread I've

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Clint Byrum
Excerpts from Khanh-Toan Tran's message of 2013-10-31 07:22:06 -0700: Hi all, As a newbie of the community, I'm not familiar with unittest and how to use it here. I've learned that Jenkins runs tests everytime we submit some code. But how to write the test and what is a 'good test' and a

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Steven Hardy
On Thu, Oct 31, 2013 at 01:30:32PM +, Mark McLoughlin wrote: On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote: This is a bit of a social norms thread I've been consistently asking for tests in reviews for a while now, and I get the occasional push-back. I think this falls

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Paul Belanger
On 13-10-30 10:37 PM, Robert Collins wrote: This is a bit of a social norms thread I've been consistently asking for tests in reviews for a while now, and I get the occasional push-back. I think this falls into a few broad camps: A - there is no test suite at all, adding one in

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Michael Bright
I like Steve's suggestion: The approach the Heat team have sometimes taken in this situation is to merge the patch, but raise a bug (targetted at the next milestone) identifying the missing coverage. I'm (almost!) a first time contributor and I've put a fix on the backburner as I find the

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Sandy Walsh
On 10/30/2013 11:37 PM, Robert Collins wrote: This is a bit of a social norms thread I've been consistently asking for tests in reviews for a while now, and I get the occasional push-back. I think this falls into a few broad camps: A - there is no test suite at all, adding one in

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Jeremy Stanley
On 2013-10-31 13:30:32 + (+), Mark McLoughlin wrote: [...] In cases like that, I'd be of a mind to go +2 Awesome! Thanks for catching this! It would be great to have a unit test for this, but it's clear the current code is broken so I'm fine with merging the fix without a test. You

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-31 Thread Adam Young
On 10/31/2013 03:24 PM, Jeremy Stanley wrote: On 2013-10-31 13:30:32 + (+), Mark McLoughlin wrote: [...] In cases like that, I'd be of a mind to go +2 Awesome! Thanks for catching this! It would be great to have a unit test for this, but it's clear the current code is broken so I'm fine

[openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-30 Thread Robert Collins
This is a bit of a social norms thread I've been consistently asking for tests in reviews for a while now, and I get the occasional push-back. I think this falls into a few broad camps: A - there is no test suite at all, adding one in unreasonable B - this thing cannot be tested in this

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-30 Thread Morgan Fainberg
On Wed, Oct 30, 2013 at 7:37 PM, Robert Collins robe...@robertcollins.net wrote: This is a bit of a social norms thread I've been consistently asking for tests in reviews for a while now, and I get the occasional push-back. I think this falls into a few broad camps: A - there is no test

Re: [openstack-dev] When is it okay for submitters to say 'I don't want to add tests' ?

2013-10-30 Thread Christopher Yeoh
When is it okay for submitters to say 'I don't want to add tests' ? When they don't want their patch merged :-) But more seriously On Thu, Oct 31, 2013 at 1:07 PM, Robert Collins robe...@robertcollins.netwrote: This is a bit of a social norms thread I've been consistently asking for