Re: [openstack-dev] additional core review criteria - recent Jenkins pass - otherwise you break the gates

2013-12-22 Thread Michael Still
On Fri, Dec 20, 2013 at 12:09 PM, Julien Danjou jul...@danjou.info wrote: On Thu, Dec 19 2013, Sean Dague wrote: So please look for recent passes before +Aing anything. What about making that automatic? Same question for patchset that stays that for a month, finally got approved and fails

[openstack-dev] additional core review criteria - recent Jenkins pass - otherwise you break the gates

2013-12-19 Thread Sean Dague
https://review.openstack.org/#/c/51793/ is a good instance of a behavior I've seen a lot of recently, where someone approves a patch that last ran CI on it a month ago (the last Jenkins pass on this patch was Nov 19th). If you come across a patch like that, as a core reviewer, please recheck no

Re: [openstack-dev] additional core review criteria - recent Jenkins pass - otherwise you break the gates

2013-12-19 Thread Julien Danjou
On Thu, Dec 19 2013, Sean Dague wrote: So please look for recent passes before +Aing anything. What about making that automatic? Same question for patchset that stays that for a month, finally got approved and fails right away because they cannot be merged. It would be cool to notify the

Re: [openstack-dev] additional core review criteria - recent Jenkins pass - otherwise you break the gates

2013-12-19 Thread Sean Dague
Jim and I have been talking about both of these ideas for months. We aren't lacking clever solutions to make this better. However they are lacking implementors. Volunteers welcomed. Until such time, this is completely solvable problem by people taking and extra 5 seconds before approving a