Re: [openstack-dev] sqlalchemy-migrate call for reviews

2014-12-02 Thread Ihar Hrachyshka
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 It's weird: we run python33 job for gate but not checks. Adding Cyril Roelandt who ported the library to py3 to CC. On 01/12/14 23:40, Thomas Goirand wrote: > On 12/01/2014 06:19 PM, Ihar Hrachyshka wrote: >> Indeed, the review queue is non-responsi

Re: [openstack-dev] sqlalchemy-migrate call for reviews

2014-12-01 Thread Thomas Goirand
On 12/01/2014 06:19 PM, Ihar Hrachyshka wrote: > Indeed, the review queue is non-responsive. There are other patches in > the queue that bit rot there: > > https://review.openstack.org/#/q/status:open+project:stackforge/sqlalchemy-migrate,n,z I did +2 some of the patches which I thought were tota

Re: [openstack-dev] sqlalchemy-migrate call for reviews

2014-12-01 Thread Jeremy Stanley
On 2014-12-01 13:24:43 -0500 (-0500), Mike Bayer wrote: [...] > for users on the outside of immediate Openstack use cases I’d > prefer if they can continue working towards moving to Alembic; the > major features I’ve introduced in Alembic including the SQLite > support are intended to make transiti

Re: [openstack-dev] sqlalchemy-migrate call for reviews

2014-12-01 Thread Mike Bayer
I can +2 whichever patches are needed by Openstack projects, or that are critically needed in general, that you can point me towards directly. Overall I’m not the “maintainer” of sqlalchemy-migrate, I’ve only volunteered to have a +2 role for critically needed issues, so in the absence of so

Re: [openstack-dev] sqlalchemy-migrate call for reviews

2014-12-01 Thread Ihar Hrachyshka
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Indeed, the review queue is non-responsive. There are other patches in the queue that bit rot there: https://review.openstack.org/#/q/status:open+project:stackforge/sqlalchemy-migrate,n,z I guess since no one with a +2 hammer systematically monitor

Re: [openstack-dev] sqlalchemy-migrate call for reviews

2014-11-30 Thread Mike Bayer
I’ve +2’ed it, it was caused by https://review.openstack.org/#/c/81955/. > On Nov 29, 2014, at 9:54 PM, Davanum Srinivas wrote: > > Looks like there is a review in the queue - > https://review.openstack.org/#/c/111485/ > > -- dims > > On Sat, Nov 29, 2014 at 6:28 PM, Jeremy Stanley wrote: >>

Re: [openstack-dev] sqlalchemy-migrate call for reviews

2014-11-29 Thread Davanum Srinivas
Looks like there is a review in the queue - https://review.openstack.org/#/c/111485/ -- dims On Sat, Nov 29, 2014 at 6:28 PM, Jeremy Stanley wrote: > To anyone who reviews sqlalchemy-migrate changes, there are people > talking to themselves on GitHub about long-overdue bug fixes because > the Ge

[openstack-dev] sqlalchemy-migrate call for reviews

2014-11-29 Thread Jeremy Stanley
To anyone who reviews sqlalchemy-migrate changes, there are people talking to themselves on GitHub about long-overdue bug fixes because the Gerrit review queue for it is sluggish and they apparently don't realize the SQLAM reviewers don't look at Google Code issues[1] and GitHub pull request commen