Re: [openstack-dev] [Fuel] Recent issues with our review workflow

2015-03-11 Thread Dmitry Borodaenko
It's really fine to create backports, even of other people's commits, as long as you don't do it too early (and thus make it possible to forget to update backports in line with newer patch sets of the master commit and land inconsistent implementations to different release series) and don't mangle

Re: [openstack-dev] [Fuel] Recent issues with our review workflow

2015-03-11 Thread Bartlomiej Piotrowski
I'll keep it in mind not to create unnecessary backports, although I really find it more convenient to do them once I submit changes to master for review. I apologize for [4], it indeed was wrong and it won't happen again. Regards, Bartłomiej On Wed, Mar 11, 2015 at 12:36 AM, Ryan Moe

Re: [openstack-dev] [Fuel] Recent issues with our review workflow

2015-03-10 Thread Tomasz Napierala
On 09 Mar 2015, at 18:21, Ryan Moe r...@mirantis.com wrote: Hi All, I've noticed a few times recently where reviews have been abandoned by people who were not the original authors. These reviews were only days old and there was no prior notice or discussion. This is both rude and

Re: [openstack-dev] [Fuel] Recent issues with our review workflow

2015-03-10 Thread Bartłomiej Piotrowski
On 03/09/2015 06:21 PM, Ryan Moe wrote: Hi All, I've noticed a few times recently where reviews have been abandoned by people who were not the original authors. These reviews were only days old and there was no prior notice or discussion. This is both rude and discouraging to contributors.

Re: [openstack-dev] [Fuel] Recent issues with our review workflow

2015-03-10 Thread Ryan Moe
Here are some examples of proposing changes prior to being merged in master [0][1][2][3][4]. [0] is a perfect example of why this isn't a good process. A change was proposed to stable/6.0 before master was merged, and now the change to master needs to be reworked based on review feedback.

[openstack-dev] [Fuel] Recent issues with our review workflow

2015-03-09 Thread Ryan Moe
Hi All, I've noticed a few times recently where reviews have been abandoned by people who were not the original authors. These reviews were only days old and there was no prior notice or discussion. This is both rude and discouraging to contributors. Reasons for abandoning should be discussed on

Re: [openstack-dev] [Fuel] Recent issues with our review workflow

2015-03-09 Thread Jay Pipes
+1 on both points, Ryan. On 03/09/2015 01:21 PM, Ryan Moe wrote: Hi All, I've noticed a few times recently where reviews have been abandoned by people who were not the original authors. These reviews were only days old and there was no prior notice or discussion. This is both rude and