Re: [openstack-dev] [Neutron] Database field sizes and attribute "MAX_LEN" constants

2016-10-17 Thread Morales, Victor
I just want to add my two cents on this. Several months ago I asked to nova community about a bug that they decided to don’t implement, this bug was suggesting to add a validation to String OVO field[1] to check if the length of the columns has been changed, the answer was that they considered

Re: [openstack-dev] [Neutron] Database field sizes and attribute "MAX_LEN" constants

2016-10-17 Thread Anna Taraday
Ihar, we all adults here, but this does not save us from making silly mistakes sometimes :( I think that if we can protect from possible mistakes - lets do this, as messing up with size of fields is a common issue. On Mon, Oct 17, 2016 at 2:16 PM Ihar Hrachyshka wrote: >

Re: [openstack-dev] [Neutron] Database field sizes and attribute "MAX_LEN" constants

2016-10-17 Thread Ihar Hrachyshka
Henry Gessau wrote: Anna Taraday wrote: Henry, thanks for taking care of this! In my opinion, it is just safe to use raw values in migration, because migration is a strict point in time. I remember how many patches I send in havana in Neutron

Re: [openstack-dev] [Neutron] Database field sizes and attribute "MAX_LEN" constants

2016-10-17 Thread Henry Gessau
Anna Taraday wrote: > Henry, thanks for taking care of this! > > In my opinion, it is just safe to use raw values in migration, because > migration is a strict point in time. > > I remember how many patches I send in havana in Neutron for fixing > synchronization

Re: [openstack-dev] [Neutron] Database field sizes and attribute "MAX_LEN" constants

2016-10-17 Thread Henry Gessau
Ihar Hrachyshka wrote: > Henry Gessau wrote: > >> Hi neutrinos, >> >> In Neutron many attributes are stored in database fields. The size of these >> fields therefore determines the maximum length of the attribute values. >> >> I would like to get some

Re: [openstack-dev] [Neutron] Database field sizes and attribute "MAX_LEN" constants

2016-10-17 Thread Anna Taraday
Henry, thanks for taking care of this! In my opinion, it is just safe to use raw values in migration, because migration is a strict point in time. I remember how many patches I send in havana in Neutron for fixing synchronization issues. Usage constants everywhere can be good in this case, but

Re: [openstack-dev] [Neutron] Database field sizes and attribute "MAX_LEN" constants

2016-10-17 Thread Ihar Hrachyshka
Henry Gessau wrote: Hi neutrinos, In Neutron many attributes are stored in database fields. The size of these fields therefore determines the maximum length of the attribute values. I would like to get some consistency in place around how we define the constants and where

[openstack-dev] [Neutron] Database field sizes and attribute "MAX_LEN" constants

2016-10-15 Thread Henry Gessau
Hi neutrinos, In Neutron many attributes are stored in database fields. The size of these fields therefore determines the maximum length of the attribute values. I would like to get some consistency in place around how we define the constants and where they are used. Here are my thoughts... 1.