Re: [openstack-dev] [Openstack-stable-maint][stable/liberty][trove] stable/liberty changes in Trove that are ready for merge

[Tony Breeds]

On Sun, Mar 20, 2016 at 08:00:07PM -0400, Luigi Toscano wrote:

> No one said that there will be other backports, at this time. It would have
> made sense if the reviews would have been merged when they have been
> proposed. It would be nice thought to backports one or two other patches for
> the integration tests, provided that the two disscused here are merged, but
> let's focus on them first.
> 
> Without the code from the two reviews, the code for scenario tests _shipped_
> in Liberty is unusable.
> Scenario tests are the new tests which are going to replace the current
> integration tests. Scenario tests are not used on the CI right now (which
> also means that the backport is not going to break anything), the plan was to
> switch to them in Mitaka, but most likely now in Newton.
> 
> Now, the integration tests currently used on the CI makes it very difficult,
> if not impossible, to test any datastore which is not MySQL - including for
> example MariaDB. Merging the two reviews would make the life a bit easier for
> people which use Liberty (which is for a while still the stable release, and
> it will be supported for other few months).
> 
> My summary is:
> Does they break some code? No.
> Does they fix broken code? Yes.
> Does this open a can of worm? IMHO no, there is no impact on the
> functionalities even in the "worst" case of other reviews being merged.

As an extra data point I ran the experimental queue over the reviews in
question.  The results aren't good.

In order to gatehr more data I'm running a no-op change through the
experimental queue.  This will help us dtermine if we're just making work for
ourselves.

Yours Tony.


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Openstack-stable-maint][stable/liberty][trove] stable/liberty changes in Trove that are ready for merge

[Luigi Toscano]

- Original Message -
> On 03/19/2016 01:43 AM, Tony Breeds wrote:
> > On Sun, Mar 13, 2016 at 12:15:23PM +, Amrith Kumar wrote:
> >> Hi,
> >>
> >> Sorry for the blast mail, this is targeted at the stable-maint team. The
> >> following five changes are now ready to merge. Two of them are changes
> >> proposed by the bot and three of them are clearly identified as
> >> cherry-picks
> >> from changes that went into master.
> > 
> >
> >> Add instance create int-tests
> >> Add MySQL int-test helper client
> > It looks like it's down to just those 2 which are testing only backports.
> >
> > From a stable POV I'm a little on the fence about applicability.
> >
> > Ignoring that right now both reviews seem to be focused around "scenarios"
> > testing but trove doesn't run gate-trove-scenario-functional-dsvm* on
> > stable
> > and on master they seem to be non-voting experimental jobs.
> >
> > Did I misunderstand what these reviews are doing?
> 
> Tony, your understanding is correct. These requests led to a lot of
> discussion and the fact that these are non-voting experimental jobs was
> discussed at length. It was felt that these would be useful for people
> who have to support stable/liberty. But, as one of the reviewers points
> out, this request opens a can of worms. Are we implying that over time
> there are going to be more fixes to get these tests working? And I don't
> think any of us is comfortable with the answer to that being "yes".

No one said that there will be other backports, at this time. It would have 
made sense if the reviews would have been merged when they have been proposed. 
It would be nice thought to backports one or two other patches for the 
integration tests, provided that the two disscused here are merged, but let's 
focus on them first.

Without the code from the two reviews, the code for scenario tests _shipped_ in 
Liberty is unusable.
Scenario tests are the new tests which are going to replace the current 
integration tests. Scenario tests are not used on the CI right now (which also 
means that the backport is not going to break anything), the plan was to switch 
to them in Mitaka, but most likely now in Newton.

Now, the integration tests currently used on the CI makes it very difficult, if 
not impossible, to test any datastore which is not MySQL - including for 
example MariaDB. Merging the two reviews would make the life a bit easier for 
people which use Liberty (which is for a while still the stable release, and it 
will be supported for other few months).

My summary is:
Does they break some code? No.
Does they fix broken code? Yes.
Does this open a can of worm? IMHO no, there is no impact on the 
functionalities even in the "worst" case of other reviews being merged.

Hope this helps.

Ciao
-- 
Luigi

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Openstack-stable-maint][stable/liberty][trove] stable/liberty changes in Trove that are ready for merge

[Tony Breeds]

On Sat, Mar 19, 2016 at 09:53:41AM -0400, Amrith Kumar wrote:
> On 03/19/2016 01:43 AM, Tony Breeds wrote:

> > Did I misunderstand what these reviews are doing?
 
> Tony, your understanding is correct. These requests led to a lot of
> discussion and the fact that these are non-voting experimental jobs was
> discussed at length. It was felt that these would be useful for people
> who have to support stable/liberty. But, as one of the reviewers points
> out, this request opens a can of worms. Are we implying that over time
> there are going to be more fixes to get these tests working? And I don't
> think any of us is comfortable with the answer to that being "yes".
> 
> So, I've put this discussion on the agenda for the Trove meeting on
> Wednesday and I will get back to you after that.

Cool.  I looked at attending in case I could provide helpful stable context,
but it's at 5am (for me).  I'll read over the log and minutes instead.

Yours Tony.


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Openstack-stable-maint][stable/liberty][trove] stable/liberty changes in Trove that are ready for merge

[Amrith Kumar]

On 03/19/2016 01:43 AM, Tony Breeds wrote:
> On Sun, Mar 13, 2016 at 12:15:23PM +, Amrith Kumar wrote:
>> Hi,
>>
>> Sorry for the blast mail, this is targeted at the stable-maint team. The
>> following five changes are now ready to merge. Two of them are changes
>> proposed by the bot and three of them are clearly identified as cherry-picks
>> from changes that went into master.
> 
>
>> Add instance create int-tests
>> Add MySQL int-test helper client
> It looks like it's down to just those 2 which are testing only backports.
>
> From a stable POV I'm a little on the fence about applicability.
>
> Ignoring that right now both reviews seem to be focused around "scenarios"
> testing but trove doesn't run gate-trove-scenario-functional-dsvm* on stable
> and on master they seem to be non-voting experimental jobs.
>
> Did I misunderstand what these reviews are doing?

Tony, your understanding is correct. These requests led to a lot of
discussion and the fact that these are non-voting experimental jobs was
discussed at length. It was felt that these would be useful for people
who have to support stable/liberty. But, as one of the reviewers points
out, this request opens a can of worms. Are we implying that over time
there are going to be more fixes to get these tests working? And I don't
think any of us is comfortable with the answer to that being "yes".

So, I've put this discussion on the agenda for the Trove meeting on
Wednesday and I will get back to you after that.

Thanks,

-amrith
> Yours Tony.
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




signature.asc
Description: OpenPGP digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Openstack-stable-maint][stable/liberty][trove] stable/liberty changes in Trove that are ready for merge

[Tony Breeds]

On Sun, Mar 13, 2016 at 12:15:23PM +, Amrith Kumar wrote:
> Hi,
> 
> Sorry for the blast mail, this is targeted at the stable-maint team. The
> following five changes are now ready to merge. Two of them are changes
> proposed by the bot and three of them are clearly identified as cherry-picks
> from changes that went into master.



> Add instance create int-tests
> Add MySQL int-test helper client

It looks like it's down to just those 2 which are testing only backports.

From a stable POV I'm a little on the fence about applicability.

Ignoring that right now both reviews seem to be focused around "scenarios"
testing but trove doesn't run gate-trove-scenario-functional-dsvm* on stable
and on master they seem to be non-voting experimental jobs.

Did I misunderstand what these reviews are doing?

Yours Tony.


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [Openstack-stable-maint][stable/liberty][trove] stable/liberty changes in Trove that are ready for merge

[Amrith Kumar]

Hi,

Sorry for the blast mail, this is targeted at the stable-maint team. The 
following five changes are now ready to merge. Two of them are changes proposed 
by the bot and three of them are clearly identified as cherry-picks from 
changes that went into master.

236209

Updated from global requirements

262287

Add instance create int-tests

262289

Add MySQL int-test helper client

262291

Catch all errors in Mock detector

228965

Updated from global requirements


Thanks,

-amrith


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev