Re: [openstack-dev] [keystone][all] Max Complexity Check Considered Harmful

2014-12-09 Thread Angus Salkeld
On Wed, Dec 10, 2014 at 8:43 AM, Joe Gordon wrote: > > > On Mon, Dec 8, 2014 at 5:03 PM, Brant Knudson wrote: > >> >> Not too long ago projects added a maximum complexity check to tox.ini, >> for example keystone has "max-complexity=24". Seemed like a good idea at >> the time, but in a recent at

Re: [openstack-dev] [keystone][all] Max Complexity Check Considered Harmful

2014-12-09 Thread Joe Gordon
On Mon, Dec 8, 2014 at 5:03 PM, Brant Knudson wrote: > > Not too long ago projects added a maximum complexity check to tox.ini, for > example keystone has "max-complexity=24". Seemed like a good idea at the > time, but in a recent attempt to lower the maximum complexity check in > keystone[1][2],

[openstack-dev] [keystone][all] Max Complexity Check Considered Harmful

2014-12-08 Thread Brant Knudson
Not too long ago projects added a maximum complexity check to tox.ini, for example keystone has "max-complexity=24". Seemed like a good idea at the time, but in a recent attempt to lower the maximum complexity check in keystone[1][2], I found that the maximum complexity check can actually lead to l