Hi Eugene,
I'd like to ask you to reconsider the -1 on this review:
a) https://review.openstack.org/#/c/114928/
I'm tackling a different issue than Kevin here:
b) https://review.openstack.org/#/c/109736/
I'm trying to allow general use of the IpNetns wrapper when
namespace=None (which is valid) and root_wraper=None (which is
valid too) to make the external_process module more testable
without needing to add extra rootwrap rules, and without needing
to rewrite the ProcessManager for that special case. [1]
Kevin, on his side, is making the code smarter, to guess from
the system, whether ip netns requires privilege elevation
or not.
Those are different bugs, tackling different issues:
a) https://bugs.launchpad.net/neutron/+bug/1358196
b) https://bugs.launchpad.net/neutron/+bug/1311804 +
https://bugs.launchpad.net/neutron/+bug/1348812
Best regards,
Miguel Ángel.
[1]:
https://review.openstack.org/#/c/112798/18/neutron/tests/functional/agent/linux/test_process_manager.py
(line 77),
namespace=None by default.
which goes through this:
https://github.com/openstack/neutron/blob/master/neutron/agent/linux/external_process.py#L54
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
