Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-29 Thread Ryan Rossiter
> On Jan 28, 2016, at 5:01 PM, Dan Smith wrote: > >> I know we have some projects (heat, I think?) that don't have UUIDs at >> all. Are they using oslo.versionedobjects? I suppose we could move them >> to a string field instead of a UUID field, instead of flipping the >>

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-29 Thread Matt Riedemann
On 1/28/2016 11:01 PM, Dan Smith wrote: I know we have some projects (heat, I think?) that don't have UUIDs at all. Are they using oslo.versionedobjects? I suppose we could move them to a string field instead of a UUID field, instead of flipping the enforcement flag on. Alternately, if we add

[openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Hayes, Graham
Recently I tried started to use oslo.versionedobjects for a project. After playing around with it for a while, I noticed I could set "this is not a uuid" as the value of a UUIDField. After making sure I made no mistakes - I looked at the underlying code, and found:[0] class UUID(FieldType):

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Davanum Srinivas
Graham, Quite unfair characterization of Oslo being -2 heavy. Please compare stats before making such an assertion: http://russellbryant.net/openstack-stats/oslo-reviewers-365.txt http://russellbryant.net/openstack-stats/nova-reviewers-365.txt

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Doug Hellmann
Excerpts from Hayes, Graham's message of 2016-01-28 17:01:09 +: > Recently I tried started to use oslo.versionedobjects for a project. > > After playing around with it for a while, I noticed I could set "this is > not a uuid" as the value of a UUIDField. > > After making sure I made no

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Joshua Harlow
Hayes, Graham wrote: Also, olso seem to be very-2 heavy. This means that alternative views on the review are very unlikely. My question is what is the difference between a-1 and a-2 for oslo? If this is the case I am sorry about it, and I'd also like to think that we (as the oslo team)

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Hayes, Graham
On 28/01/2016 18:44, Davanum Srinivas wrote: > Graham, > > Quite unfair characterization of Oslo being -2 heavy. Please compare > stats before making such an assertion: OK - that was probably my frustration boiling over at the time. I should not have made that generalization. I had been involved

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Mike Bayer
On 01/28/2016 01:52 PM, Doug Hellmann wrote: > Excerpts from Hayes, Graham's message of 2016-01-28 17:01:09 +: >> Recently I tried started to use oslo.versionedobjects for a project. >> >> After playing around with it for a while, I noticed I could set "this is >> not a uuid" as the value of

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Hayes, Graham
On 28/01/2016 19:13, Mike Bayer wrote: > > > On 01/28/2016 01:52 PM, Doug Hellmann wrote: >> Excerpts from Hayes, Graham's message of 2016-01-28 17:01:09 +: >>> >>> The steps I had looked at doing was this: >>> >>> 1. Allow a "validate" flag on the Field __init__() defaulting to False. >>>

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Hayes, Graham
On 28/01/2016 18:54, Doug Hellmann wrote: > Excerpts from Hayes, Graham's message of 2016-01-28 17:01:09 +: >> Recently I tried started to use oslo.versionedobjects for a project. >> >> After playing around with it for a while, I noticed I could set "this is >> not a uuid" as the value of a

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Doug Hellmann
Excerpts from Hayes, Graham's message of 2016-01-28 19:02:57 +: > On 28/01/2016 18:44, Davanum Srinivas wrote: > > Graham, > > > > Quite unfair characterization of Oslo being -2 heavy. Please compare > > stats before making such an assertion: > > OK - that was probably my frustration boiling

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Joshua Harlow
Ryan Rossiter wrote: As the-guy-in-nova-that-does-this-a-bunch, I’ve pushed a bunch of changes to nova because we didn’t have them yet in o.vo, and once they get released, I “re-sync” them back to nova to use the o.vo version, see: https://review.openstack.org/#/c/272641/

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Ryan Rossiter
> On Jan 28, 2016, at 4:04 PM, Joshua Harlow wrote: > > Ryan Rossiter wrote: >> >> As the-guy-in-nova-that-does-this-a-bunch, I’ve pushed a bunch of changes to >> nova because we didn’t have them yet in o.vo, and once they get released, I >> “re-sync” them back to nova

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Dan Smith
> I know we have some projects (heat, I think?) that don't have UUIDs at > all. Are they using oslo.versionedobjects? I suppose we could move them > to a string field instead of a UUID field, instead of flipping the > enforcement flag on. Alternately, if we add a new class we wouldn't have > to

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Doug Hellmann
Excerpts from Hayes, Graham's message of 2016-01-28 19:17:54 +: > On 28/01/2016 18:54, Doug Hellmann wrote: > > Excerpts from Hayes, Graham's message of 2016-01-28 17:01:09 +: > >> Recently I tried started to use oslo.versionedobjects for a project. > >> > >> After playing around with it

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Doug Hellmann
Excerpts from Hayes, Graham's message of 2016-01-28 20:42:39 +: > On 28/01/2016 20:16, Doug Hellmann wrote: > > Excerpts from Hayes, Graham's message of 2016-01-28 19:17:54 +: > >> On 28/01/2016 18:54, Doug Hellmann wrote: > >>> Excerpts from Hayes, Graham's message of 2016-01-28 17:01:09

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Hayes, Graham
On 28/01/2016 20:16, Doug Hellmann wrote: > Excerpts from Hayes, Graham's message of 2016-01-28 19:17:54 +: >> On 28/01/2016 18:54, Doug Hellmann wrote: >>> Excerpts from Hayes, Graham's message of 2016-01-28 17:01:09 +: Recently I tried started to use oslo.versionedobjects for a

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Ryan Rossiter
> On Jan 28, 2016, at 1:10 PM, Mike Bayer wrote: > > > > On 01/28/2016 01:52 PM, Doug Hellmann wrote: >> Excerpts from Hayes, Graham's message of 2016-01-28 17:01:09 +: >>> Recently I tried started to use oslo.versionedobjects for a project. >>> >>> After playing

Re: [openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?

2016-01-28 Thread Ryan Rossiter
> On Jan 28, 2016, at 1:32 PM, Doug Hellmann wrote: > > Excerpts from Hayes, Graham's message of 2016-01-28 19:02:57 +: >> On 28/01/2016 18:44, Davanum Srinivas wrote: >>> Graham, >>> >>> Quite unfair characterization of Oslo being -2 heavy. Please compare >>> stats