Re: [openstack-dev] [sahara][qa] Unblocking Sahara gate

2016-10-12 Thread Ghanshyam Mann
I think this is issue more the way plugin was using the config options.

Sahara tests plugin should have used the options in their own way or implement 
same way it was done in Tempest (define self. data-processing etc) instead of 
partially relying on tempest defined variable.

Honestly saying, I do not prefer of adding the automapping in tempest side. 

[1]  will fix the issue and unblock the sahara tests. And I saw sahara plugin 
is also branchless so should be ok with just this patch ?

..1 - https://review.openstack.org/#/c/385701/


Thanks & Regards,
Ghanshyam Mann

> -Original Message-
> From: Luigi Toscano [mailto:ltosc...@redhat.com]
> Sent: 13 October 2016 00:37
> To: openstack-dev@lists.openstack.org
> Subject: [openstack-dev] [sahara][qa] Unblocking Sahara gate
> 
> Hi all,
> 
> the removal of the Sahara tests from Tempest [1] broke the tests now in
> sahara-tests, and basically I underestimated the fall-out of the removal.
> Apart from a minor issue due to the wrong exception [2], the key issue
> comes from the option groups in tempest.conf, which are defined as data-
> processing and data-processing-feature-available, while the code tries to
> access CONF.data_processing. Previously this was handled by some magic
> mapping [3], which can't be used, as it is, by plugins.
> I came up with this solution [4] after discussing with Andrea Frittoli. The
> patches only fails with the automation negative tests, which are on the way
> of the Dodo anyway [5].
> The alternative fix for sahara would involve patching the configured
> tempest.conf in few branches, in addition to the fixes to sahara-tests, and 
> I'd
> frankly prefer a more general solution.
> 
> My question is: can you please approve [5] and [4], so that Sahara gates can
> be unlocked?
> 
> 
> [1] https://review.openstack.org/#/c/380082/
> [2] https://review.openstack.org/#/c/385336/
> [3]
> http://git.openstack.org/cgit/openstack/tempest/tree/tempest/config.py?
> h=13.0.0#n1239
> [4] https://review.openstack.org/#/c/385460/
> [5] https://review.openstack.org/#/c/380982/
> 
> Ciao
> --
> Luigi
> 
> __
> 
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [sahara][qa] Unblocking Sahara gate

2016-10-12 Thread Luigi Toscano
Hi all,

the removal of the Sahara tests from Tempest [1] broke the tests now in 
sahara-tests, and basically I underestimated the fall-out of the removal. 
Apart from a minor issue due to the wrong exception [2], the key issue comes 
from the option groups in tempest.conf, which are defined as data-processing 
and data-processing-feature-available, while the code tries to access 
CONF.data_processing. Previously this was handled by some magic mapping [3], 
which can't be used, as it is, by plugins.
I came up with this solution [4] after discussing with Andrea Frittoli. The 
patches only fails with the automation negative tests, which are on the way of 
the Dodo anyway [5].
The alternative fix for sahara would involve patching the configured 
tempest.conf in few branches, in addition to the fixes to sahara-tests, and 
I'd frankly prefer a more general solution.

My question is: can you please approve [5] and [4], so that Sahara gates can 
be unlocked?


[1] https://review.openstack.org/#/c/380082/
[2] https://review.openstack.org/#/c/385336/
[3] http://git.openstack.org/cgit/openstack/tempest/tree/tempest/config.py?
h=13.0.0#n1239
[4] https://review.openstack.org/#/c/385460/
[5] https://review.openstack.org/#/c/380982/

Ciao
-- 
Luigi

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev