[openstack-dev] [swift] statsd client opening a new socket everytime a stats is updated

2014-07-15 Thread Tatiana Al-Chueyr Martins
Hello!

I'm new to both Swift and OpenStack, I hope you can help me.

Considering statsd is enabled, each time something is logged, a new socket
is being opened.

At least, this is what I understood from the implementation and usage of
StatsdClient at:
- swift/common/utils.py
- swift/common/middleware/proxy_logging.py

If this analysis is correct: is there any special reason for this behavior
(open a new socket each request)?

We could significantly improve performance reusing the same socket.

Would you be interested in a patch in this regard?

Best,
-- 
Tatiana Al-Chueyr
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [swift] statsd client opening a new socket everytime a stats is updated

2014-07-15 Thread John Dickinson
We've been chatting in IRC, but for the mailing list archives, yes! we'd love 
to see patches to improve this.

--John


On Jul 15, 2014, at 1:22 PM, Tatiana Al-Chueyr Martins 
tatiana.alchu...@gmail.com wrote:

 Hello!
 
 I'm new to both Swift and OpenStack, I hope you can help me.
 
 Considering statsd is enabled, each time something is logged, a new socket is 
 being opened.
 
 At least, this is what I understood from the implementation and usage of 
 StatsdClient at:
 - swift/common/utils.py
 - swift/common/middleware/proxy_logging.py
 
 If this analysis is correct: is there any special reason for this behavior 
 (open a new socket each request)?
 
 We could significantly improve performance reusing the same socket.
 
 Would you be interested in a patch in this regard?
 
 Best,
 -- 
 Tatiana Al-Chueyr
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev