Re: [openstack-dev] generate Windows exe
Hi Viktor, I just submitted the patch, adding you as co-author with the email address that you used here, please let me know if this is ok for you: https://review.openstack.org/#/c/115782/ The patch is even easier compared to what you sent as all we need is to add declaratively the requested entry point in setup.cfg: [entry_points] console_scripts = swift = swiftclient.shell:main The OpenStack patch workflow is not that complicated if you’re already familiar with git, but it can be challenging at the beginning. If you’d like to join our dev IRC channel (#openstack-dev, Freenode), I can explain you the basics in just a few minutes (nic: alexpilotti) in case you’d like to contribute again in the future. In case you’d like to take a look here are the general guideline: https://wiki.openstack.org/wiki/How_To_Contribute In particular it'd be great if you could sign online the contributor license agreement, it's just a matter of having a Launchpad account and doing a couple of clicks. Thanks! Alessandro On 20 Aug 2014, at 22:47, Szépe Viktor wrote: > Thank you! > > https://bugs.launchpad.net/python-swiftclient/+bug/1359360 > > > > Idézem/Quoting Stefano Maffulli : > >> Hi Szepe, >> >> On Wed 20 Aug 2014 11:33:47 AM PDT, Szépe Viktor wrote: >>> Thank you for your answer. >>> That workflow seems a huge job for me. >>> >>> I leave this patch up to you. >> >> thanks for sending this fix. You've stumbled upon one of the known >> issues of OpenStack's way to deal with small patches like yours. We have >> a workflow optimized for the extremely large amount of patches we get >> (around 60-70 *per hour*). Our workflow does not use github and its pull >> requests. >> >> Unfortunately this optimization for large scale contributions is leaving >> occasional contributors like you outside. >> >> I would suggest you to file a bug on >> https://bugs.launchpad.net/python-swiftclient instead of a pull request >> as we don't use github at all, only drop there code as 'mirror' and >> nothing else. >> >> I'll suggest also to add 'file a bug' as a suggestion to the message >> sent upon automatically closing the PR. >> >> /stef >> -- >> Ask and answer questions on https://ask.openstack.org > > > Szépe Viktor > -- > +36-20-4242498 s...@szepe.net skype: szepe.viktor > Budapest, XX. kerület > > > > > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] generate Windows exe
Thank you! https://bugs.launchpad.net/python-swiftclient/+bug/1359360 Idézem/Quoting Stefano Maffulli : Hi Szepe, On Wed 20 Aug 2014 11:33:47 AM PDT, Szépe Viktor wrote: Thank you for your answer. That workflow seems a huge job for me. I leave this patch up to you. thanks for sending this fix. You've stumbled upon one of the known issues of OpenStack's way to deal with small patches like yours. We have a workflow optimized for the extremely large amount of patches we get (around 60-70 *per hour*). Our workflow does not use github and its pull requests. Unfortunately this optimization for large scale contributions is leaving occasional contributors like you outside. I would suggest you to file a bug on https://bugs.launchpad.net/python-swiftclient instead of a pull request as we don't use github at all, only drop there code as 'mirror' and nothing else. I'll suggest also to add 'file a bug' as a suggestion to the message sent upon automatically closing the PR. /stef -- Ask and answer questions on https://ask.openstack.org Szépe Viktor -- +36-20-4242498 s...@szepe.net skype: szepe.viktor Budapest, XX. kerület ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] generate Windows exe
Hi Szepe, On Wed 20 Aug 2014 11:33:47 AM PDT, Szépe Viktor wrote: > Thank you for your answer. > That workflow seems a huge job for me. > > I leave this patch up to you. thanks for sending this fix. You've stumbled upon one of the known issues of OpenStack's way to deal with small patches like yours. We have a workflow optimized for the extremely large amount of patches we get (around 60-70 *per hour*). Our workflow does not use github and its pull requests. Unfortunately this optimization for large scale contributions is leaving occasional contributors like you outside. I would suggest you to file a bug on https://bugs.launchpad.net/python-swiftclient instead of a pull request as we don't use github at all, only drop there code as 'mirror' and nothing else. I'll suggest also to add 'file a bug' as a suggestion to the message sent upon automatically closing the PR. /stef -- Ask and answer questions on https://ask.openstack.org ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] generate Windows exe
Thank you for your answer.
That workflow seems a huge job for me.
I leave this patch up to you.
Idézem/Quoting Adam Lawson :
Curious, did you follow the link and follow the Gerrit workflow? Seems your
rejection letter (unlike mine I received from my sweetheart in high school)
was due to process rather than merit. (
http://wiki.openstack.org/GerritWorkflow)
*Adam Lawson*
AQORN, Inc.
427 North Tatnall Street
Ste. 58461
Wilmington, Delaware 19801-2230
Toll-free: (844) 4-AQORN-NOW ext. 101
International: +1 302-387-4660
Direct: +1 916-246-2072
On Wed, Aug 20, 2014 at 11:15 AM, Szépe Viktor wrote:
Is it the right list?
The PR was rejected: https://github.com/openstack/
python-swiftclient/pull/14
Idézem/Quoting Szépe Viktor :
Now bin\swift can only be started by python Scripts\swift
Windows does not support extensionless scripts.
Maybe I did it wrong, this is my first encounter with setuptools.
Please consider modifying setup.py
import setuptools
setuptools.setup(
setup_requires=['pbr'],
pbr=True,
entry_points={
"console_scripts": [
"swift=swiftclient.shell:main"
]
})
Thank you!
Szépe Viktor
--
+36-20-4242498 s...@szepe.net skype: szepe.viktor
Budapest, XX. kerület
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Szépe Viktor
--
+36-20-4242498 s...@szepe.net skype: szepe.viktor
Budapest, XX. kerület
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] generate Windows exe
Curious, did you follow the link and follow the Gerrit workflow? Seems your
rejection letter (unlike mine I received from my sweetheart in high school)
was due to process rather than merit. (
http://wiki.openstack.org/GerritWorkflow)
*Adam Lawson*
AQORN, Inc.
427 North Tatnall Street
Ste. 58461
Wilmington, Delaware 19801-2230
Toll-free: (844) 4-AQORN-NOW ext. 101
International: +1 302-387-4660
Direct: +1 916-246-2072
On Wed, Aug 20, 2014 at 11:15 AM, Szépe Viktor wrote:
> Is it the right list?
>
> The PR was rejected: https://github.com/openstack/
> python-swiftclient/pull/14
>
>
>
> Idézem/Quoting Szépe Viktor :
>
> Now bin\swift can only be started by python Scripts\swift
>> Windows does not support extensionless scripts.
>> Maybe I did it wrong, this is my first encounter with setuptools.
>>
>>
>> Please consider modifying setup.py
>>
>> import setuptools
>>
>> setuptools.setup(
>> setup_requires=['pbr'],
>> pbr=True,
>> entry_points={
>> "console_scripts": [
>> "swift=swiftclient.shell:main"
>> ]
>> })
>>
>> Thank you!
>>
>
> Szépe Viktor
> --
> +36-20-4242498 s...@szepe.net skype: szepe.viktor
> Budapest, XX. kerület
>
>
>
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] generate Windows exe
Is it the right list?
The PR was rejected: https://github.com/openstack/python-swiftclient/pull/14
Idézem/Quoting Szépe Viktor :
Now bin\swift can only be started by python Scripts\swift
Windows does not support extensionless scripts.
Maybe I did it wrong, this is my first encounter with setuptools.
Please consider modifying setup.py
import setuptools
setuptools.setup(
setup_requires=['pbr'],
pbr=True,
entry_points={
"console_scripts": [
"swift=swiftclient.shell:main"
]
})
Thank you!
Szépe Viktor
--
+36-20-4242498 s...@szepe.net skype: szepe.viktor
Budapest, XX. kerület
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] generate Windows exe
Now bin\swift can only be started by python Scripts\swift
Windows does not support extensionless scripts.
Maybe I did it wrong, this is my first encounter with distutil.
Please consider modifying setup.py
import setuptools
setuptools.setup(
setup_requires=['pbr'],
pbr=True,
entry_points={
"console_scripts": [
"swift=swiftclient.shell:main"
]
})
Thank you!
Szépe Viktor
--
+36-20-4242498 s...@szepe.net skype: szepe.viktor
Budapest, XX. kerület
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
