Re: [openstack-dev] Thanks for fixing my patch

2013-10-13 Thread Angus Salkeld
On 11/10/13 11:34 -0700, Clint Byrum wrote: Recently in the TripleO meeting we identified situations where we need to make it very clear that it is ok to pick up somebody else's patch and finish it. We are broadly distributed, time-zone-wise, and I know other teams working on OpenStack projects

Re: [openstack-dev] Thanks for fixing my patch

2013-10-13 Thread Jeremy Stanley
On 2013-10-14 09:45:38 +1100 (+1100), Angus Salkeld wrote: Note the commit will authored by the original poster, so perhaps if you modify a patch we should add a Modified-by: line to indicate that it was dual authored. We encourage the use of Co-Authored-By: name n...@example.com in commit

Re: [openstack-dev] Thanks for fixing my patch

2013-10-13 Thread Angus Salkeld
On 13/10/13 22:58 +, Jeremy Stanley wrote: On 2013-10-14 09:45:38 +1100 (+1100), Angus Salkeld wrote: Note the commit will authored by the original poster, so perhaps if you modify a patch we should add a Modified-by: line to indicate that it was dual authored. We encourage the use of

Re: [openstack-dev] Thanks for fixing my patch

2013-10-13 Thread Kieran Spear
On 14 October 2013 09:58, Jeremy Stanley fu...@yuggoth.org wrote: On 2013-10-14 09:45:38 +1100 (+1100), Angus Salkeld wrote: Note the commit will authored by the original poster, so perhaps if you modify a patch we should add a Modified-by: line to indicate that it was dual authored. We

Re: [openstack-dev] Thanks for fixing my patch

2013-10-12 Thread Lingxian Kong
Really a good idea! It's painful for us to summit a patch, then waiting for reviewing because of the time difference. It's more painful if we get a -1 after getting up. It's very appreciated that if someone could help, and we can help others, too. 2013/10/12 Nikhil Manchanda nik...@manchanda.me

Re: [openstack-dev] Thanks for fixing my patch

2013-10-11 Thread David Kranz
On 10/11/2013 02:34 PM, Clint Byrum wrote: Recently in the TripleO meeting we identified situations where we need to make it very clear that it is ok to pick up somebody else's patch and finish it. We are broadly distributed, time-zone-wise, and I know other teams working on OpenStack projects

Re: [openstack-dev] Thanks for fixing my patch

2013-10-11 Thread Doug Hellmann
Running git review -d $gerrit_id will download the patch and create a local branch for you. For example, if I wanted to work on Sandy's patch https://review.openstack.org/#/c/51249 I would git review -d 51249. I can then amend the changeset, rebase, or whatever. Running git review will push it up

Re: [openstack-dev] Thanks for fixing my patch

2013-10-11 Thread Dolph Mathews
On Fri, Oct 11, 2013 at 1:34 PM, Clint Byrum cl...@fewbar.com wrote: Recently in the TripleO meeting we identified situations where we need to make it very clear that it is ok to pick up somebody else's patch and finish it. We are broadly distributed, time-zone-wise, and I know other teams

Re: [openstack-dev] Thanks for fixing my patch

2013-10-11 Thread Nikhil Manchanda
Just wanted to chime in that Trove also follows this approach and it's worked pretty well for us. +1 on Doug's suggestion to leave a comment on the patch so that two reviewers don't end up doing the same work fixing it. Cheers, -Nikhil On Fri, Oct 11, 2013 at 12:17 PM, Dolph Mathews