Re: [openstack-dev] [Cinder] pep8 issues and how to pep8 locally ?

2014-04-28 Thread Sean Dague
On 04/28/2014 06:08 AM, Deepak Shetty wrote: Hi, H703 Multiple positional placeholders I got this for one of my patch and googling i could find that the fix is to use dict instead of direct substitues.. which i did.. but it still gives me the error :( Also just running pep8 locally

Re: [openstack-dev] [Cinder] pep8 issues and how to pep8 locally ?

2014-04-28 Thread Deepak Shetty
Why is this not part of cinder or devstack dep and why isn't this auto installed ? I searched the HACKING and CONTRIBUTING docs.. none of them explain how to sanity check your code before posting it to gerrit ... yum search and pip install didn't help me install tox-epep8... How do i proceed ?

Re: [openstack-dev] [Cinder] pep8 issues and how to pep8 locally ?

2014-04-28 Thread Deepak Shetty
[stack@devstack-vm cinder]$ sudo pip install tox-epep8 Downloading/unpacking tox-epep8 Could not find any downloads that satisfy the requirement tox-epep8 Cleaning up... No distributions at all found for tox-epep8 Storing complete log in /root/.pip/pip.log [stack@devstack-vm cinder]$ sudo yum

Re: [openstack-dev] [Cinder] pep8 issues and how to pep8 locally ?

2014-04-28 Thread Avishay Traeger
Deepak, Sean meant that 'tox -epep8' is the command that runs the pep8 checks. You can install tox with 'pip install tox' and pep8 with 'pip install pep8'. Once you have those, run 'tox -epep8' Thanks, Avishay On Mon, Apr 28, 2014 at 1:15 PM, Deepak Shetty dpkshe...@gmail.com wrote:

Re: [openstack-dev] [Cinder] pep8 issues and how to pep8 locally ?

2014-04-28 Thread Kashyap Chamarthy
On Mon, Apr 28, 2014 at 03:47:14PM +0530, Deepak Shetty wrote: Why is this not part of cinder or devstack dep and why isn't this auto installed ? I searched the HACKING and CONTRIBUTING docs.. none of them explain how to sanity check your code before posting it to gerrit ... yum search and pip