Re: [openstack-dev] [Cinder] pep8 issues and how to pep8 locally ?
On 04/28/2014 06:08 AM, Deepak Shetty wrote: Hi, H703 Multiple positional placeholders I got this for one of my patch and googling i could find that the fix is to use dict instead of direct substitues.. which i did.. but it still gives me the error :( Also just running pep8 locally on my glsuterfs.py file doesn't show any issue but gerrit does. So how do i run the same pep8 that gerrit does locally on my box, so that I don't end up resending new patches due to failed gerrit build checks ? tox -epep8 -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder] pep8 issues and how to pep8 locally ?
Why is this not part of cinder or devstack dep and why isn't this auto installed ? I searched the HACKING and CONTRIBUTING docs.. none of them explain how to sanity check your code before posting it to gerrit ... yum search and pip install didn't help me install tox-epep8... How do i proceed ? On Mon, Apr 28, 2014 at 3:39 PM, Sean Dague s...@dague.net wrote: On 04/28/2014 06:08 AM, Deepak Shetty wrote: Hi, H703 Multiple positional placeholders I got this for one of my patch and googling i could find that the fix is to use dict instead of direct substitues.. which i did.. but it still gives me the error :( Also just running pep8 locally on my glsuterfs.py file doesn't show any issue but gerrit does. So how do i run the same pep8 that gerrit does locally on my box, so that I don't end up resending new patches due to failed gerrit build checks ? tox -epep8 -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder] pep8 issues and how to pep8 locally ?
[stack@devstack-vm cinder]$ sudo pip install tox-epep8 Downloading/unpacking tox-epep8 Could not find any downloads that satisfy the requirement tox-epep8 Cleaning up... No distributions at all found for tox-epep8 Storing complete log in /root/.pip/pip.log [stack@devstack-vm cinder]$ sudo yum search tox-epep8 Warning: No matches found for: tox-epep8 No matches found [stack@devstack-vm cinder]$ On Mon, Apr 28, 2014 at 3:39 PM, Sean Dague s...@dague.net wrote: On 04/28/2014 06:08 AM, Deepak Shetty wrote: Hi, H703 Multiple positional placeholders I got this for one of my patch and googling i could find that the fix is to use dict instead of direct substitues.. which i did.. but it still gives me the error :( Also just running pep8 locally on my glsuterfs.py file doesn't show any issue but gerrit does. So how do i run the same pep8 that gerrit does locally on my box, so that I don't end up resending new patches due to failed gerrit build checks ? tox -epep8 -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder] pep8 issues and how to pep8 locally ?
Deepak, Sean meant that 'tox -epep8' is the command that runs the pep8 checks. You can install tox with 'pip install tox' and pep8 with 'pip install pep8'. Once you have those, run 'tox -epep8' Thanks, Avishay On Mon, Apr 28, 2014 at 1:15 PM, Deepak Shetty dpkshe...@gmail.com wrote: [stack@devstack-vm cinder]$ sudo pip install tox-epep8 Downloading/unpacking tox-epep8 Could not find any downloads that satisfy the requirement tox-epep8 Cleaning up... No distributions at all found for tox-epep8 Storing complete log in /root/.pip/pip.log [stack@devstack-vm cinder]$ sudo yum search tox-epep8 Warning: No matches found for: tox-epep8 No matches found [stack@devstack-vm cinder]$ On Mon, Apr 28, 2014 at 3:39 PM, Sean Dague s...@dague.net wrote: On 04/28/2014 06:08 AM, Deepak Shetty wrote: Hi, H703 Multiple positional placeholders I got this for one of my patch and googling i could find that the fix is to use dict instead of direct substitues.. which i did.. but it still gives me the error :( Also just running pep8 locally on my glsuterfs.py file doesn't show any issue but gerrit does. So how do i run the same pep8 that gerrit does locally on my box, so that I don't end up resending new patches due to failed gerrit build checks ? tox -epep8 -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder] pep8 issues and how to pep8 locally ?
On Mon, Apr 28, 2014 at 03:47:14PM +0530, Deepak Shetty wrote: Why is this not part of cinder or devstack dep and why isn't this auto installed ? I searched the HACKING and CONTRIBUTING docs.. none of them explain how to sanity check your code before posting it to gerrit ... yum search and pip install didn't help me install tox-epep8... How do i proceed ? Seems like you're searching for the wrong packages. Try this: $ yum install python-tox python-pep8 -y That should bring you what you need. Then, you can try: $ tox -epep8 PS: Per Fedora packaging conventions, all PyPI packages are prefixed with 'python-' -- /kashyap ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
