Re: [openstack-dev] [Congress] Magnum_driver

That job is non-voting, which since you're adding a new datasource, you can ignore. Nothing to do now but wait for people to give you reviews. Tim On Mon, Dec 12, 2016 at 1:12 PM Ruben wrote: > Hi Tim, > thanks a lot for your help. > I've seen that there is a

Re: [openstack-dev] [Congress] Magnum_driver

Hi Tim, thanks a lot for your help. I've seen that there is a failure for "gate-congress-pe-replicated-nv". It's strange because I didn't have failure before. So, what should I do now? Ruben - Messaggio originale - Da: "Tim Hinrichs" A: "Ruben"

Re: [openstack-dev] [Congress] Magnum_driver

Hi Ruben, Looked like there were still multiple changes, so I squashed them into 1 and fixed up the requirements.txt file. (You should only need to add the python-magnumclient to the requirements.txt file.) I also abandoned one that was incorporated into the one 1 fix. Here it is. Now the

Re: [openstack-dev] [Congress] Magnum_driver

Hi Tim, sorry for the late, but I've had a busy week. Anyway, I've tried to add the magnum_driver to review into a single commit. I don't know if I have been able.. Ruben - Messaggio originale - Da: "Tim Hinrichs" A: "Ruben" Cc:

Re: [openstack-dev] [Congress] Magnum_driver

Hi Ruben, What you're doing is correct. The downside is that it creates a new commit for every change you make, and all of those commits show up on gerrit. In OpenStack (and other projects I've seen that use Gerrit for code reviews) you squash those commits into 1 change so that it's easier for

Re: [openstack-dev] [Congress] Magnum_driver

Hi Tim, what should I do to squash all the commits into a single one? To add the code to review I made: git add git commit git review Isn't it correct? Ruben - Messaggio originale - Da: "Tim Hinrichs" A: "Ruben" Cc:

Re: [openstack-dev] [Congress] Magnum_driver

Hi Ruben, I left a comment on one of the changes; after you take care of that I'll take a closer look at the code. Let me know if you have questions. Tim On Tue, Nov 29, 2016 at 4:06 AM Ruben wrote: > Hi Tim, > I've added the code of magnum_driver and its

Re: [openstack-dev] [Congress] Magnum_driver

Hi Tim, I've added the code of magnum_driver and its unit test to review. It seems everything works. Ruben - Original Message - From: "Tim Hinrichs" To: "Ruben" Cc: openstack-dev@lists.openstack.org, "timothy l hinrichs"

Re: [openstack-dev] [Congress] Magnum_driver

Definitely push that code up into Gerrit so we can all take a look. Data like pods and containers is probably the most valuable data from Magnum, so I'd definitely recommend adding that. But push the code you have to Gerrit first. (As long as you leave the ChangeId the same each time you push

Re: [openstack-dev] [Congress] Magnum_driver

Hi Tim, You are great. It works! Thanks a lot! I've also solved the problem with py27. The unit test seems to work. The only thing that seems not to work is populate the 'clusters_links' and 'cluster_templates_links' tables: they are empty. Also, the 'labels' table is empty. I've no errors

Re: [openstack-dev] [Congress] Magnum_driver

Hi Ruben, Glad you got that worked out. Once in a while I end up deleting my .tox dir because it gets out of date. I guess that's what the --recreate option to tox does. So I learned something. :) The new error message looks to be saying that an object of type 'Cluster' cannot be iterated.

Re: [openstack-dev] [Congress] Magnum_driver

Hi Tim, I solved the problem with: tox --recreate -e py27 Now I no have the error on the import. The unit test still has some errors, but I don't know why.. Anyway, I've this error when I try to add the magnum_driver: 2016-11-24 20:56:27.191 INFO congress.datasources.datasource_driver [-]

Re: [openstack-dev] [Congress] Magnum_driver

It's hard to debug that remotely. If you add the requirements.txt file with the magnum-client to the code you submitted to gerrit, the tests will run on gerrit, and I can see the errors for myself. The error message is pretty clearly saying that the module can't be found. Not sure what to

Re: [openstack-dev] [Congress] Magnum_driver

Hi Tim, I already have 'pyhton-magnumclient' in the requirements.txt file, but I still have the error. This is the /opt/stack/congress/requirements.txt file: "# The order of packages is significant, because pip processes them in the order # of appearance. Changing the order has an impact on the

Re: [openstack-dev] [Congress] Magnum_driver

Ruben, All the software that gets imported by your code needs to be listed in requirements.txt so that when tox runs, it installs that software. When I did some debugging for you I made the necessary change, so if you add that back into your change, that error should disappear.

Re: [openstack-dev] [Congress] Magnum_driver

Hi Ruben, The fieldnames you care about are the fields as they show up in the JSON that gets returned from the magnum-client methods inside the datasource driver, e.g. from these methods... self.magnum.cluster_template.list() self.magnum.cluster.list() Several ways to check that you have the

Re: [openstack-dev] [Congress] Magnum_driver

Hi Ruben, Did a little debugging for you... 1) Run your unit tests $ tox -epy34 congress.tests.datasources.test_magnum ... File "/Users/tim/opencode/congress/congress/tests/datasources/test_magnum_driver.py", line 3, in from congress.datasources import magnum_driver File

Re: [openstack-dev] [Congress] Magnum_driver

Ruben, I found the following two reviews: https://review.openstack.org/397150 Magnum_driver for congress https://review.openstack.org/397151 Test for magnum_driver Are these what you are referring to, or is it something else? Thanks, Adrian > On Nov 14, 2016, at 4:13 AM, Ruben