Re: [openstack-dev] [Fuel] [UI] Deploy Changes dialog redesign

2015-01-28 Thread Igor Kalnitsky
Nik, I'm now here and I don't agree that we need to remove changes attribute. On the opposite, I think this is the only attribute which should be looked at on UI and backend, and all these pending_addition and pending_someotherstuff are obsolete and needless. You're absolutely right. It's

Re: [openstack-dev] [Fuel] [UI] Deploy Changes dialog redesign

2015-01-28 Thread Nikolay Markov
Igor, But why can't we implement it properly on the first try? It doesn't seem like a hard task and won't take much time. On Wed, Jan 28, 2015 at 12:50 PM, Igor Kalnitsky ikalnit...@mirantis.com wrote: Nik, I'm now here and I don't agree that we need to remove changes attribute. On the

Re: [openstack-dev] [Fuel] [UI] Deploy Changes dialog redesign

2015-01-28 Thread Igor Kalnitsky
Nik, I'm sure it requires at least a spec, since there are things that should be discussed. Who can do it in this release cycle? If there's a person I'm +1 for refactoring; otherwise - I'd prefer to remove it to make code more clear. Thanks, Igor On Wed, Jan 28, 2015 at 12:44 PM, Nikolay Markov

Re: [openstack-dev] [Fuel] [UI] Deploy Changes dialog redesign

2015-01-27 Thread Nikolay Markov
Guys, I'm now here and I don't agree that we need to remove changes attribute. On the opposite, I think this is the only attribute which should be looked at on UI and backend, and all these pending_addition and pending_someotherstuff are obsolete and needless. Just assume, that we'll soon have

Re: [openstack-dev] [Fuel] [UI] Deploy Changes dialog redesign

2015-01-26 Thread Vitaly Kramskikh
+1 for removing changes attribute. It's useless now. If there are no plans to add something else there, let's remove it. 2015-01-26 11:39 GMT+03:00 Julia Aranovich jkirnos...@mirantis.com: Hi All, Since we changed Deploy Changes pop-up and added processing of role limits and restrictions

Re: [openstack-dev] [Fuel] [UI] Deploy Changes dialog redesign

2015-01-26 Thread Evgeniy L
Hi, I agree that this information is useless, but it's not really clear what you are going to show instead, will you completely remove the information about nodes for deployment? I think the list of nodes for deployment (without detailed list of changes) can be useful for the user. Thanks, On

Re: [openstack-dev] [Fuel] [UI] Deploy Changes dialog redesign

2015-01-26 Thread Igor Kalnitsky
+1 for removing attribute. @Evgeniy, I'm not sure that this attribute really shows all changes that's going to be done. On Mon, Jan 26, 2015 at 7:11 PM, Evgeniy L e...@mirantis.com wrote: To be more specific, +1 for removing this information from UI, not from backend. On Mon, Jan 26, 2015 at

Re: [openstack-dev] [Fuel] [UI] Deploy Changes dialog redesign

2015-01-26 Thread Evgeniy L
To be more specific, +1 for removing this information from UI, not from backend. On Mon, Jan 26, 2015 at 7:46 PM, Evgeniy L e...@mirantis.com wrote: Hi, I agree that this information is useless, but it's not really clear what you are going to show instead, will you completely remove the

Re: [openstack-dev] [Fuel] [UI] Deploy Changes dialog redesign

2015-01-26 Thread Mike Scherbakov
+1, I do not think it's usable as how it is now. Let's think though if we can come up with better idea how to show what has been changed (or even otherwise, what was not touched - and so might bring a surprise later). We might want to think about it after wizard-like UI is implemented. On Mon,