Re: [openstack-dev] [Fuel] Abandon changesets which hang for a while without updates

2015-07-21 Thread Mike Scherbakov
Folks, I'll push DevOps to run the script. However, what we need is to just go ahead and clean up, abandon manually what is not relevant anymore, provide comment. Please start with your patches. On Thu, Jul 16, 2015 at 11:08 PM Oleg Gelbukh ogelb...@mirantis.com wrote: Nicely put, Doug, you

Re: [openstack-dev] [Fuel] Abandon changesets which hang for a while without updates

2015-07-17 Thread Oleg Gelbukh
Nicely put, Doug, you gave me laughs :) I can't see how a CR could hang for a month without anyone paying attention if it worths merging. If this really happens (which I'm not aware of), auto-abandon definitely won't make things any worse. -- Best regards, Oleg Gelbukh On Fri, Jul 17, 2015 at

Re: [openstack-dev] [Fuel] Abandon changesets which hang for a while without updates

2015-07-16 Thread Dmitry Borodaenko
I'm with Stanislaw on this one: abandoning reviews just to make numbers *look* better will accomplish nothing. The only benefit I can see is cleaning up reviews that we *know* don't need to be considered, so that it's easier for reviewers to find the reviews that still need attention. I don't see

Re: [openstack-dev] [Fuel] Abandon changesets which hang for a while without updates

2015-07-15 Thread Mike Scherbakov
Folks, let's execute here. Numbers are still large. Did we have a chance to look over the whole queue? Can we go ahead and abandon changes having -1 or -2 from reviewers for over than a months or so? I'm all for just following standard OpenStack process [1], and then change it only if there is

Re: [openstack-dev] [Fuel] Abandon changesets which hang for a while without updates

2015-07-09 Thread Stanislaw Bogatkin
2 weeks seems too small for me. We easy can be in situation when fix for medium bug is done, but SCF starts. And gap between SCF and release easily can be more than a month. So, 2 months seems okay for me if speaking about forcibly applying auto-abandon by major vote. And I'm personally against

Re: [openstack-dev] [Fuel] Abandon changesets which hang for a while without updates

2015-07-09 Thread Davanum Srinivas
That's a very good plan (Initial feedback/triage) Mike. thanks, dims On Thu, Jul 9, 2015 at 3:23 PM, Mike Scherbakov mscherba...@mirantis.com wrote: +1 for just reusing existing script, and adjust it on the way. No need to immediately switch from infinite time to a couple of weeks, we can

Re: [openstack-dev] [Fuel] Abandon changesets which hang for a while without updates

2015-07-09 Thread Mike Scherbakov
+1 for just reusing existing script, and adjust it on the way. No need to immediately switch from infinite time to a couple of weeks, we can always adjust it later. But 1-2 month should be a good start already. Our current stats [1] look just terrible. Before we enable an auto-abandon, we need to

Re: [openstack-dev] [Fuel] Abandon changesets which hang for a while without updates

2015-07-08 Thread Evgeniy L
+1 for enabling auto-abandon Sergii, I think the period should be smaller, 2 weeks - 1 month, if patch is important, the author will unabandon it. Thanks, On Wed, Jul 8, 2015 at 3:50 AM, Sergii Golovatiuk sgolovat...@mirantis.com wrote: 3 Months should be a good period. Sometimes, people have