Re: [openstack-dev] [Glance][QA] python-glanceclient untestable in Python 3.4

2014-10-17 Thread Flavio Percoco
On 10/17/2014 05:57 AM, Fei Long Wang wrote:
 Hi Jeremy,
 
 Thanks for the heads up. Is there a bug opened to track this? If not,
 I'm going to open one and dig into it. Cheers.

Hey Fei Long,

Thanks for taking care of this, please keep me in the loop.

@Jeremy: Thanks for the heads up

Flavio

 
 On 17/10/14 14:17, Jeremy Stanley wrote:
 As part of an effort to deprecate our specialized testing platform
 for Python 3.3, many of us have been working to confirm projects
 which currently gate on 3.3 can also pass their same test sets under
 Python 3.4 (which comes by default in Ubuntu Trusty). For the vast
 majority of projects, the differences between 3.3 and 3.4 are
 immaterial and no effort is required. For some, minor adjustments
 are needed...

 For python-glanceclient, we have 22 failing tests in a tox -e py34
 run. I spent the better part of today digging into them, and they
 basically all stem from the fact that PEP 456 switches the unordered
 data hash algorithm from FNV to SipHash in 3.4. The unit tests in
 python-glanceclient frequently rely on trying to match
 multi-parameter URL queries and JSON built from unordered data types
 against predetermined string representations. Put simply, this just
 doesn't work if you can't guarantee their ordering.

 I'm left with a dilemma--I don't really have time to fix all of
 these (I started to go through and turn the fixture keys into format
 strings embedding dicts filtered through urlencode() for example,
 but it created as many new failures as it fixed), however I'd hate
 to drop Py3K testing for software which currently has it no matter
 how fragile. This is mainly a call for help to anyone with some
 background and/or interest in python-glanceclient's unit tests to
 get them working under Python 3.4, so that we can eliminate the
 burden of maintaining special 3.3 test infrastructure.
 


-- 
@flaper87
Flavio Percoco

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Glance][QA] python-glanceclient untestable in Python 3.4

2014-10-17 Thread Jeremy Stanley
On 2014-10-17 16:57:59 +1300 (+1300), Fei Long Wang wrote:
 Thanks for the heads up. Is there a bug opened to track this? If
 not, I'm going to open one and dig into it. Cheers.

Gah! You'd think *I* would know better at this point--sorry about
that... I've now opened https://launchpad.net/bugs/1382582 to track
this. Thanks for any assistance you're able to provide!
-- 
Jeremy Stanley

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Glance][QA] python-glanceclient untestable in Python 3.4

2014-10-17 Thread Louis Taylor
On Fri, Oct 17, 2014 at 03:01:22PM +, Jeremy Stanley wrote:
 Gah! You'd think *I* would know better at this point--sorry about
 that... I've now opened https://launchpad.net/bugs/1382582 to track
 this. Thanks for any assistance you're able to provide!

This looks like a continuation of the old PYTHONHASHSEED bug:

https://launchpad.net/bugs/1348818


signature.asc
Description: Digital signature
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Glance][QA] python-glanceclient untestable in Python 3.4

2014-10-17 Thread Jeremy Stanley
On 2014-10-17 16:17:39 +0100 (+0100), Louis Taylor wrote:
 This looks like a continuation of the old PYTHONHASHSEED bug:
 
 https://launchpad.net/bugs/1348818

The underlying design choices in python-glanceclient's tests do
cause both problems (can't run with a random hash seed, but also
can't run under a different hash algorithm), and properly fixing one
will fix the other. Unfortunately there isn't an easy workaround for
the Python 3.4 testing issue, unlike bug 1348818.
-- 
Jeremy Stanley

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Glance][QA] python-glanceclient untestable in Python 3.4

2014-10-16 Thread Fei Long Wang
Hi Jeremy,

Thanks for the heads up. Is there a bug opened to track this? If not,
I'm going to open one and dig into it. Cheers.

On 17/10/14 14:17, Jeremy Stanley wrote:
 As part of an effort to deprecate our specialized testing platform
 for Python 3.3, many of us have been working to confirm projects
 which currently gate on 3.3 can also pass their same test sets under
 Python 3.4 (which comes by default in Ubuntu Trusty). For the vast
 majority of projects, the differences between 3.3 and 3.4 are
 immaterial and no effort is required. For some, minor adjustments
 are needed...

 For python-glanceclient, we have 22 failing tests in a tox -e py34
 run. I spent the better part of today digging into them, and they
 basically all stem from the fact that PEP 456 switches the unordered
 data hash algorithm from FNV to SipHash in 3.4. The unit tests in
 python-glanceclient frequently rely on trying to match
 multi-parameter URL queries and JSON built from unordered data types
 against predetermined string representations. Put simply, this just
 doesn't work if you can't guarantee their ordering.

 I'm left with a dilemma--I don't really have time to fix all of
 these (I started to go through and turn the fixture keys into format
 strings embedding dicts filtered through urlencode() for example,
 but it created as many new failures as it fixed), however I'd hate
 to drop Py3K testing for software which currently has it no matter
 how fragile. This is mainly a call for help to anyone with some
 background and/or interest in python-glanceclient's unit tests to
 get them working under Python 3.4, so that we can eliminate the
 burden of maintaining special 3.3 test infrastructure.

-- 
Cheers  Best regards,
Fei Long Wang (王飞龙)
--
Senior Cloud Software Engineer
Tel: +64-48032246
Email: flw...@catalyst.net.nz
Catalyst IT Limited
Level 6, Catalyst House, 150 Willis Street, Wellington
-- 


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev