Re: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard

2014-12-12 Thread David Lyle
) openstack-dev@lists.openstack.org From: David Lyle dkly...@gmail.com Date: 12/11/2014 09:23AM Subject: Re: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard I'm probably not understanding the nuance of the question but moving the _scripts.html file to openstack_dashboard

Re: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard

2014-12-12 Thread Lin Hua Cheng
: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard I'm probably not understanding the nuance of the question but moving the _scripts.html file to openstack_dashboard creates some circular dependencies, does it not? templates/base.html in the horizon side of the repo includes

Re: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard

2014-12-12 Thread Thai Q Tran
As is the case with anything we change, but that should not stop us from making improvements/progress. I would argue that it would make life easier for them since all scripts are now in one place.-Lin Hua Cheng os.lch...@gmail.com wrote: -To: "OpenStack Development Mailing List (not for

Re: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard

2014-12-12 Thread Lin Hua Cheng
os.lch...@gmail.com wrote: - To: OpenStack Development Mailing List (not for usage questions) openstack-dev@lists.openstack.org From: Lin Hua Cheng os.lch...@gmail.com Date: 12/12/2014 10:28AM Subject: Re: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard Consolidating them

Re: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard

2014-12-12 Thread Thai Q Tran
Haha, sure I'm willing to make concessions. I'll update the patch to retain the _conf file but it will be blank. This way, we can move forward and not break it for existing users.I'll also document it somewhere in the patch.-Lin Hua Cheng os.lch...@gmail.com wrote: -To: "OpenStack

Re: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard

2014-12-11 Thread David Lyle
I'm probably not understanding the nuance of the question but moving the _scripts.html file to openstack_dashboard creates some circular dependencies, does it not? templates/base.html in the horizon side of the repo includes _scripts.html and insures that the javascript needed by the existing

Re: [openstack-dev] [Horizon] Moving _conf and _scripts to dashboard

2014-12-11 Thread Thai Q Tran
It would not create a circular dependency, dashboard would depend on horizon - not the latter.Scripts that are library specific will live in horizon while scripts that are panel specific will live in dashboard.Let me draw a more concrete example.In Horizon We know that _script and _conf are