Re: [openstack-dev] [Murano] Should we run tests on all supported database engines?

2015-03-05 Thread Andrew Pashkin 
Why do we need that, by the way?

REST API tests will cover database access, and database is not used for
anything else than API anyway. Additional DB layer will bring additional
complexity which we will consume time to maintain it. So if we do not
know why exactly we need such layer, I think we should not introduce it.

On 02.03.2015 19:05, Serg Melikyan wrote:
> Hi Andrew,
> 
> I think we should isolate DB access layer and test this layer
> extensively on MySQL & PostgreSQL. 
> 
> On Mon, Mar 2, 2015 at 6:57 PM, Andrew Pashkin  > wrote:
> 
> There is a bug:
> https://bugs.launchpad.net/murano/+bug/1419743
> 
> It's about that search on packages is failing if use Postgres as DB
> backend. The fix is pretty easy there, but how this bug should be
> tested?
> 
> I see such options:
> 1) Run all tests for all DBs that we support.
> 2) Run some tests for some DBs.
> 3) Do not test such issues at all.
> 
> Do anyone has some thoughts on this?
> 
> --
> With kind regards, Andrew Pashkin.
> cell phone - +7 (985) 898 57 59
> Skype - waves_in_fluids
> e-mail - apash...@mirantis.com 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> 
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> 
> 
> -- 
> Serg Melikyan, Senior Software Engineer at Mirantis, Inc.
> http://mirantis.com  | smelik...@mirantis.com
> 
> 
> +7 (495) 640-4904, 0261
> +7 (903) 156-0836
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 

-- 
With kind regards, Andrew Pashkin.
cell phone - +7 (985) 898 57 59
Skype - waves_in_fluids
e-mail - apash...@mirantis.com

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Murano] Should we run tests on all supported database engines?

2015-03-02 Thread Andrew Pashkin 
What kind of layer do you mean?

Right now we have some kind of isolation in the form of separate
functions for DB lookups. For example for this case its
murano.db.catalog.api.package_search [1].

[1]
https://github.com/stackforge/murano/blob/b4918b512010875b9cf3b59d65ff1fbfeaf5f197/murano/db/catalog/api.py#L226-226

On 02.03.2015 19:05, Serg Melikyan wrote:
> Hi Andrew,
> 
> I think we should isolate DB access layer and test this layer
> extensively on MySQL & PostgreSQL. 
> 
> On Mon, Mar 2, 2015 at 6:57 PM, Andrew Pashkin  > wrote:
> 
> There is a bug:
> https://bugs.launchpad.net/murano/+bug/1419743
> 
> It's about that search on packages is failing if use Postgres as DB
> backend. The fix is pretty easy there, but how this bug should be
> tested?
> 
> I see such options:
> 1) Run all tests for all DBs that we support.
> 2) Run some tests for some DBs.
> 3) Do not test such issues at all.
> 
> Do anyone has some thoughts on this?
> 
> --
> With kind regards, Andrew Pashkin.
> cell phone - +7 (985) 898 57 59
> Skype - waves_in_fluids
> e-mail - apash...@mirantis.com 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> 
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> 
> 
> -- 
> Serg Melikyan, Senior Software Engineer at Mirantis, Inc.
> http://mirantis.com  | smelik...@mirantis.com
> 
> 
> +7 (495) 640-4904, 0261
> +7 (903) 156-0836
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 

-- 
With kind regards, Andrew Pashkin.
cell phone - +7 (985) 898 57 59
Skype - waves_in_fluids
e-mail - apash...@mirantis.com

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Murano] Should we run tests on all supported database engines?

2015-03-02 Thread Serg Melikyan 
Hi Andrew,

I think we should isolate DB access layer and test this layer extensively
on MySQL & PostgreSQL.

On Mon, Mar 2, 2015 at 6:57 PM, Andrew Pashkin 
wrote:

> There is a bug:
> https://bugs.launchpad.net/murano/+bug/1419743
>
> It's about that search on packages is failing if use Postgres as DB
> backend. The fix is pretty easy there, but how this bug should be
> tested?
>
> I see such options:
> 1) Run all tests for all DBs that we support.
> 2) Run some tests for some DBs.
> 3) Do not test such issues at all.
>
> Do anyone has some thoughts on this?
>
> --
> With kind regards, Andrew Pashkin.
> cell phone - +7 (985) 898 57 59
> Skype - waves_in_fluids
> e-mail - apash...@mirantis.com
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Serg Melikyan, Senior Software Engineer at Mirantis, Inc.
http://mirantis.com | smelik...@mirantis.com

+7 (495) 640-4904, 0261
+7 (903) 156-0836
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev