Re: [openstack-dev] [Neutron] Add an extension "btree_gist" to Postgresql

2016-07-21 Thread na...@vn.fujitsu.com
Ihar Hrachyshka wrote:

> That’s an interesting precedent. I understand that since we gate on  
> postgresql and mysql only, the solution is good enough to pass in the gate.  
> But are we ok fixing a bug just for those two backends, knowing that it’s  
> left exposed for other backends? Could you think of a solution that would  
> be backend agnostic?

Thank you for your reply and sorry for my late because I got many comments
from core-reviews including you so I need to investigate their one. By the way, 
they are discussing on my patch set so shall I close this thread.
Please check my one [1] for more detail.

Thanks and best regards,
Nam

[1] https://review.openstack.org/#/c/314054/ 
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Neutron] Add an extension "btree_gist" to Postgresql

2016-07-18 Thread Sean M. Collins
Ihar Hrachyshka wrote:
> That’s an interesting precedent. I understand that since we gate on
> postgresql and mysql only, the solution is good enough to pass in the gate.
> But are we ok fixing a bug just for those two backends, knowing that it’s
> left exposed for other backends? Could you think of a solution that would be
> backend agnostic?


This is why during the review phase, I objected to using a stored
procedure for this logic, since it is tied very tightly to the database
implementation. 

I also have a lot of scars and recurring nightmares
about an old job where the majority of an application's logic was
embedded in huge stored procedures and database triggers - so I'm a bit
biased.

-- 
Sean M. Collins

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Neutron] Add an extension "btree_gist" to Postgresql

2016-07-18 Thread Ihar Hrachyshka

na...@vn.fujitsu.com wrote:


Hi everyone,

I am trying to fix a bug that created two subnets on *one* network with
overlap CIDR [1]. My solution is to focus on Database interaction [2].

I am encountering/facing a problem with Postgresql
(There is no problem with MySQL).

For Postgresql, I used a feature called GiST that I strong believe
it can fix this bug. However, this feature needs to be created
an extension "btree_gist" that we have to need "root" permission.
In my point of view, we cannot do this on Neutron
because it only has normal user permission.

Currently, There are two ways that may be fix this issue in my opinion:

1. I will try to find a solution to let Neutron can create an extension
in Postgresql with normal user. But I'm not sure about this yet.

2. I will try to implement a create an extension "btree_gist" during
Postgresql Database setting up when deploying OpenStack.
If so, an "Installation Guide" section must be included.

How do you think about that or do you have any advice?
Any help is very appreciated!

[1] https://bugs.launchpad.net/neutron/+bug/1532695
[2] https://review.openstack.org/#/c/314054/


That’s an interesting precedent. I understand that since we gate on  
postgresql and mysql only, the solution is good enough to pass in the gate.  
But are we ok fixing a bug just for those two backends, knowing that it’s  
left exposed for other backends? Could you think of a solution that would  
be backend agnostic?


Ihar

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev