Re: [openstack-dev] [Nova] [FFE] Final Libvirt User Namespaces Patch

2014-09-05 Thread Daniel P. Berrange
On Fri, Sep 05, 2014 at 01:49:20PM +, Andrew Melton wrote:
 Hey Devs,
 
 I'd like to request a feature freeze exception for: 
 https://review.openstack.org/#/c/94915/
 
 This feature is the final patch set for the User Namespace BP
 (https://blueprints.launchpad.net/nova/+spec/libvirt-lxc-user-namespaces).
 This is an important feature for libvirt-lxc because in greatly increases
 the security of running libvirt-lxc based containers. The code for this
 feature has been up for a couple months now and has had plenty of time
 to go through review. The code itself is solid by now and functionally
 it hasn't changed much in the last month or so. Lastly, the only thing
 holding up the patch from merging this week was a multitude of bugs in
 the gate.

Since we've already merged 9 out of the 10 total patches for this feature,
it is a no brainer to merge this last one.

I sponsor it.

Regards,
Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Nova] [FFE] Final Libvirt User Namespaces Patch

2014-09-05 Thread Jay Pipes

On 09/05/2014 09:57 AM, Daniel P. Berrange wrote:

On Fri, Sep 05, 2014 at 01:49:20PM +, Andrew Melton wrote:

Hey Devs,

I'd like to request a feature freeze exception for: 
https://review.openstack.org/#/c/94915/

This feature is the final patch set for the User Namespace BP
(https://blueprints.launchpad.net/nova/+spec/libvirt-lxc-user-namespaces).
This is an important feature for libvirt-lxc because in greatly increases
the security of running libvirt-lxc based containers. The code for this
feature has been up for a couple months now and has had plenty of time
to go through review. The code itself is solid by now and functionally
it hasn't changed much in the last month or so. Lastly, the only thing
holding up the patch from merging this week was a multitude of bugs in
the gate.


Since we've already merged 9 out of the 10 total patches for this feature,
it is a no brainer to merge this last one.

I sponsor it.


Me as well. I've already reviewed most of the patches.

-jay

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Nova] [FFE] Final Libvirt User Namespaces Patch

2014-09-05 Thread Matt Dietz
Thirding sponsorship.

I didn¹t review as much as the other two, but I helped merge a couple of
the patches. Agreed with Jay otherwise; we¹re almost there, let¹s finish
it.

-Original Message-
From: Jay Pipes jaypi...@gmail.com
Reply-To: OpenStack Development Mailing List (not for usage questions)
openstack-dev@lists.openstack.org
Date: Friday, September 5, 2014 at 9:56 AM
To: openstack-dev@lists.openstack.org openstack-dev@lists.openstack.org
Subject: Re: [openstack-dev] [Nova] [FFE] Final Libvirt User Namespaces
Patch

On 09/05/2014 09:57 AM, Daniel P. Berrange wrote:
 On Fri, Sep 05, 2014 at 01:49:20PM +, Andrew Melton wrote:
 Hey Devs,

 I'd like to request a feature freeze exception for:
https://review.openstack.org/#/c/94915/

 This feature is the final patch set for the User Namespace BP
 
(https://blueprints.launchpad.net/nova/+spec/libvirt-lxc-user-namespaces
).
 This is an important feature for libvirt-lxc because in greatly
increases
 the security of running libvirt-lxc based containers. The code for this
 feature has been up for a couple months now and has had plenty of time
 to go through review. The code itself is solid by now and functionally
 it hasn't changed much in the last month or so. Lastly, the only thing
 holding up the patch from merging this week was a multitude of bugs in
 the gate.

 Since we've already merged 9 out of the 10 total patches for this
feature,
 it is a no brainer to merge this last one.

 I sponsor it.

Me as well. I've already reviewed most of the patches.

-jay

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Nova] [FFE] Final Libvirt User Namespaces Patch

2014-09-05 Thread Michael Still
Approved.

Michael

On Fri, Sep 5, 2014 at 3:46 PM, Matt Dietz matt.di...@rackspace.com wrote:
 Thirding sponsorship.

 I didn¹t review as much as the other two, but I helped merge a couple of
 the patches. Agreed with Jay otherwise; we¹re almost there, let¹s finish
 it.

 -Original Message-
 From: Jay Pipes jaypi...@gmail.com
 Reply-To: OpenStack Development Mailing List (not for usage questions)
 openstack-dev@lists.openstack.org
 Date: Friday, September 5, 2014 at 9:56 AM
 To: openstack-dev@lists.openstack.org openstack-dev@lists.openstack.org
 Subject: Re: [openstack-dev] [Nova] [FFE] Final Libvirt User Namespaces
 Patch

On 09/05/2014 09:57 AM, Daniel P. Berrange wrote:
 On Fri, Sep 05, 2014 at 01:49:20PM +, Andrew Melton wrote:
 Hey Devs,

 I'd like to request a feature freeze exception for:
https://review.openstack.org/#/c/94915/

 This feature is the final patch set for the User Namespace BP

(https://blueprints.launchpad.net/nova/+spec/libvirt-lxc-user-namespaces
).
 This is an important feature for libvirt-lxc because in greatly
increases
 the security of running libvirt-lxc based containers. The code for this
 feature has been up for a couple months now and has had plenty of time
 to go through review. The code itself is solid by now and functionally
 it hasn't changed much in the last month or so. Lastly, the only thing
 holding up the patch from merging this week was a multitude of bugs in
 the gate.

 Since we've already merged 9 out of the 10 total patches for this
feature,
 it is a no brainer to merge this last one.

 I sponsor it.

Me as well. I've already reviewed most of the patches.

-jay

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Rackspace Australia

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev