Re: [openstack-dev] [Nova] Deprecating localfs?
On Wed, Sep 24, 2014 at 08:26:44AM +1000, Michael Still wrote: On Tue, Sep 23, 2014 at 8:58 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 23, 2014 at 02:27:52PM +0400, Roman Bogorodskiy wrote: Michael Still wrote: Hi. I know we've been talking about deprecating nova.virt.disk.vfs.localfs for a long time, in favour of wanting people to use libguestfs instead. However, I can't immediately find any written documentation for when we said we'd do that thing. Additionally, this came to my attention because Ubuntu 14.04 is apparently shipping a libguestfs old enough to cause us to emit the falling back to localfs warning, so I think we need Ubuntu to catch up before we can do this thing. So -- how about we remove localfs early in Kilo to give Canonical a release to update libguestfs? Thoughts appreciated, Michael If at some point we'd start moving into getting FreeBSD supported as a host OS for OpenStack, then it would make sense to keep localfs for that configuration. libguestfs doesn't work on FreeBSD yet. On the other hand, localfs code in Nova doesn't look like it'd be hard to port. Yep, that's a good point and in fact applies to Linux too when considering the non-KVM/QEMU drivers libvirt supports. eg if your host does not have virtualization and you're using LXC for container virt, then we need to have localfs still be present. Likewise if running Xen. So we definitely cannot delete or even deprecate it unconditionally. We simply want to make sure localfs isn't used when Nova is configured to run QEMU/KVM via libvirt. So if we take the config option approach I suggested, then we'd set a default value for the vfs_impl parameter according to which libvirt driver you have enabled. I'm glad we've had this thread, because I hadn't thought of the FreeBSD case at all. In that case I wonder if we want to water down the warning we currently log in this case: LOG.warn(_LW(Unable to import guestfs falling back to VFSLocalFS)) If feel like it should be an info if we know some platforms will always have this occur. I know this is a minor thing, but this came to my attention because at lease one operator was concerned by seeing that warning in their logs. If we take my suggested approach of using a fixed impl based on libvirt driver type, then we wouldn't have fallback so not see this warning. Even when we do have fallback, we should only warn if libguestfs is installed, but not working. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] Deprecating localfs?
On Tue, Sep 23, 2014 at 09:53:36AM +1000, Michael Still wrote: Hi. I know we've been talking about deprecating nova.virt.disk.vfs.localfs for a long time, in favour of wanting people to use libguestfs instead. However, I can't immediately find any written documentation for when we said we'd do that thing. Additionally, this came to my attention because Ubuntu 14.04 is apparently shipping a libguestfs old enough to cause us to emit the falling back to localfs warning, so I think we need Ubuntu to catch up before we can do this thing. So -- how about we remove localfs early in Kilo to give Canonical a release to update libguestfs? A few randomly related points: - libguestfs 1.26 in Debian (and eventually in Ubuntu) finally gets rid of 'update-guestfs-appliance'. - Unfortunately Ubuntu still has the kernel permissions bug: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/759725 Fedora/RHEL has none of these issues. - There are a couple of easy to fix bugs that would greatly improve libguestfs usability in OpenStack: (1) Don't throw away debugging information: https://bugs.launchpad.net/nova/+bug/1279857 (2) [Don't think there's a bug# for this] The libvirt_inject_partition parameter doesn't adequately model what libguestfs can do for guests. Plus it's a global setting and ought to be a glance setting (or per disk/per template anyway). libguestfs has a rich API for inspecting guests, and that cannot be modelled in a single integer. http://libguestfs.org/guestfs.3.html#inspection Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] Deprecating localfs?
On Tue, Sep 23, 2014 at 09:53:36AM +1000, Michael Still wrote: Hi. I know we've been talking about deprecating nova.virt.disk.vfs.localfs for a long time, in favour of wanting people to use libguestfs instead. However, I can't immediately find any written documentation for when we said we'd do that thing. Additionally, this came to my attention because Ubuntu 14.04 is apparently shipping a libguestfs old enough to cause us to emit the falling back to localfs warning, so I think we need Ubuntu to catch up before we can do this thing. So -- how about we remove localfs early in Kilo to give Canonical a release to update libguestfs? Rather than removing localfs right away how about we add an explicit config parameter to control behaviour vfs_impl=auto|guestfs|localfs where auto == try libguestfs, fallback to localfs guestfs == try libguestfs, error otherwise localfs == try localfs, error otherwise Currently we do 'auto' behaviour but in Kilo we could make 'guestfs' be the default, so there is no fallback. That way distros will quickly see if they have a problem, but still have option to reconfigure to use localfs if they need to. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] Deprecating localfs?
I am ok with a staged approach, although I do think its something we should start in Kilo. That said though, we emit a warning if the installation doesn't have a working libguestfs in juno. Michael On Tue, Sep 23, 2014 at 8:09 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 23, 2014 at 09:53:36AM +1000, Michael Still wrote: Hi. I know we've been talking about deprecating nova.virt.disk.vfs.localfs for a long time, in favour of wanting people to use libguestfs instead. However, I can't immediately find any written documentation for when we said we'd do that thing. Additionally, this came to my attention because Ubuntu 14.04 is apparently shipping a libguestfs old enough to cause us to emit the falling back to localfs warning, so I think we need Ubuntu to catch up before we can do this thing. So -- how about we remove localfs early in Kilo to give Canonical a release to update libguestfs? Rather than removing localfs right away how about we add an explicit config parameter to control behaviour vfs_impl=auto|guestfs|localfs where auto == try libguestfs, fallback to localfs guestfs == try libguestfs, error otherwise localfs == try localfs, error otherwise Currently we do 'auto' behaviour but in Kilo we could make 'guestfs' be the default, so there is no fallback. That way distros will quickly see if they have a problem, but still have option to reconfigure to use localfs if they need to. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Rackspace Australia ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] Deprecating localfs?
Michael Still wrote: Hi. I know we've been talking about deprecating nova.virt.disk.vfs.localfs for a long time, in favour of wanting people to use libguestfs instead. However, I can't immediately find any written documentation for when we said we'd do that thing. Additionally, this came to my attention because Ubuntu 14.04 is apparently shipping a libguestfs old enough to cause us to emit the falling back to localfs warning, so I think we need Ubuntu to catch up before we can do this thing. So -- how about we remove localfs early in Kilo to give Canonical a release to update libguestfs? Thoughts appreciated, Michael If at some point we'd start moving into getting FreeBSD supported as a host OS for OpenStack, then it would make sense to keep localfs for that configuration. libguestfs doesn't work on FreeBSD yet. On the other hand, localfs code in Nova doesn't look like it'd be hard to port. Roman Bogorodskiy ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] Deprecating localfs?
On Tue, Sep 23, 2014 at 02:27:52PM +0400, Roman Bogorodskiy wrote: Michael Still wrote: Hi. I know we've been talking about deprecating nova.virt.disk.vfs.localfs for a long time, in favour of wanting people to use libguestfs instead. However, I can't immediately find any written documentation for when we said we'd do that thing. Additionally, this came to my attention because Ubuntu 14.04 is apparently shipping a libguestfs old enough to cause us to emit the falling back to localfs warning, so I think we need Ubuntu to catch up before we can do this thing. So -- how about we remove localfs early in Kilo to give Canonical a release to update libguestfs? Thoughts appreciated, Michael If at some point we'd start moving into getting FreeBSD supported as a host OS for OpenStack, then it would make sense to keep localfs for that configuration. libguestfs doesn't work on FreeBSD yet. On the other hand, localfs code in Nova doesn't look like it'd be hard to port. Yep, that's a good point and in fact applies to Linux too when considering the non-KVM/QEMU drivers libvirt supports. eg if your host does not have virtualization and you're using LXC for container virt, then we need to have localfs still be present. Likewise if running Xen. So we definitely cannot delete or even deprecate it unconditionally. We simply want to make sure localfs isn't used when Nova is configured to run QEMU/KVM via libvirt. So if we take the config option approach I suggested, then we'd set a default value for the vfs_impl parameter according to which libvirt driver you have enabled. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Nova] Deprecating localfs?
On Tue, Sep 23, 2014 at 8:58 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 23, 2014 at 02:27:52PM +0400, Roman Bogorodskiy wrote: Michael Still wrote: Hi. I know we've been talking about deprecating nova.virt.disk.vfs.localfs for a long time, in favour of wanting people to use libguestfs instead. However, I can't immediately find any written documentation for when we said we'd do that thing. Additionally, this came to my attention because Ubuntu 14.04 is apparently shipping a libguestfs old enough to cause us to emit the falling back to localfs warning, so I think we need Ubuntu to catch up before we can do this thing. So -- how about we remove localfs early in Kilo to give Canonical a release to update libguestfs? Thoughts appreciated, Michael If at some point we'd start moving into getting FreeBSD supported as a host OS for OpenStack, then it would make sense to keep localfs for that configuration. libguestfs doesn't work on FreeBSD yet. On the other hand, localfs code in Nova doesn't look like it'd be hard to port. Yep, that's a good point and in fact applies to Linux too when considering the non-KVM/QEMU drivers libvirt supports. eg if your host does not have virtualization and you're using LXC for container virt, then we need to have localfs still be present. Likewise if running Xen. So we definitely cannot delete or even deprecate it unconditionally. We simply want to make sure localfs isn't used when Nova is configured to run QEMU/KVM via libvirt. So if we take the config option approach I suggested, then we'd set a default value for the vfs_impl parameter according to which libvirt driver you have enabled. I'm glad we've had this thread, because I hadn't thought of the FreeBSD case at all. In that case I wonder if we want to water down the warning we currently log in this case: LOG.warn(_LW(Unable to import guestfs falling back to VFSLocalFS)) If feel like it should be an info if we know some platforms will always have this occur. I know this is a minor thing, but this came to my attention because at lease one operator was concerned by seeing that warning in their logs. Michael -- Rackspace Australia ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
