Re: [openstack-dev] [Os-brick][Cinder] NVMe-oF NQN string

2018-04-19 Thread Szwed, Maciej
Hi Hamdy,
Thanks for quick action.

Regards
Maciej

From: Hamdy Khader [mailto:ham...@mellanox.com]
Sent: Tuesday, April 17, 2018 12:51 PM
To: OpenStack-dev@lists.openstack.org
Subject: Re: [openstack-dev] [Os-brick][Cinder] NVMe-oF NQN string


Hi,

I think you're right, will drop the split and push change soon.



Regards,

Hamdy


From: Szwed, Maciej <maciej.sz...@intel.com<mailto:maciej.sz...@intel.com>>
Sent: Monday, April 16, 2018 4:51 PM
To: OpenStack-dev@lists.openstack.org<mailto:OpenStack-dev@lists.openstack.org>
Subject: [openstack-dev] [Os-brick][Cinder] NVMe-oF NQN string


Hi,

I'm wondering why in Os-brick implementation of NVMe-oF in 
os_brick/initiator/connectors/nvme.py, line 97 we do split on 'nqn'. Connection 
properties, including 'nqn', are provided by Cinder driver and when user want 
to implement new driver that will use NVMe-of he/she needs to create NQN string 
with additional string and dot proceeding the desired NQN string. This 
additional string is unused across whole NVMe-oF implementation. This creates 
confusion for people when creating new Cinder driver. What was its purpose? Can 
we drop that split?



Regards,

Maciej
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Os-brick][Cinder] NVMe-oF NQN string

2018-04-17 Thread Hamdy Khader
Hi,

I think you're right, will drop the split and push change soon.


Regards,

Hamdy



From: Szwed, Maciej 
Sent: Monday, April 16, 2018 4:51 PM
To: OpenStack-dev@lists.openstack.org
Subject: [openstack-dev] [Os-brick][Cinder] NVMe-oF NQN string


Hi,

I’m wondering why in Os-brick implementation of NVMe-oF in 
os_brick/initiator/connectors/nvme.py, line 97 we do split on ‘nqn’. Connection 
properties, including ‘nqn’, are provided by Cinder driver and when user want 
to implement new driver that will use NVMe-of he/she needs to create NQN string 
with additional string and dot proceeding the desired NQN string. This 
additional string is unused across whole NVMe-oF implementation. This creates 
confusion for people when creating new Cinder driver. What was its purpose? Can 
we drop that split?



Regards,

Maciej
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev