Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
Sean Dague said on Fri, May 09, 2014 at 08:20:42AM -0400: Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit. Hi Sean, I've been looking for something like this! Very nice. Only one problem - if all cores use this, anything with a -1 is dead. It's not always possible to address everyone's concerns to their full satisfaction and sometimes even core reviewers like to acknowledge this by leaving a -1 not a -2. This affects new starters who have little reputation to trade on more than frequent contributors who can ask around to get their patches merged despite not being on the review list. What do you think please? Alexis -- Nova Engineer, HP Cloud. AKA lealexis, lxsli. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
On 05/19/2014 01:03 PM, Alexis Lee wrote: Sean Dague said on Fri, May 09, 2014 at 08:20:42AM -0400: Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit. Hi Sean, I've been looking for something like this! Very nice. Only one problem - if all cores use this, anything with a -1 is dead. It's not always possible to address everyone's concerns to their full satisfaction and sometimes even core reviewers like to acknowledge this by leaving a -1 not a -2. This affects new starters who have little reputation to trade on more than frequent contributors who can ask around to get their patches merged despite not being on the review list. What do you think please? Alexis It's actually pretty rare for something to merge with a negative code review on it. In the last 30 days in Nova we've merged: - 218 patches - 10 of which had a negative code review on them at merge time If we go back 60 days we get: - 462 patches - 17 of which had a negative code review on them at merge time ssh review.openstack.org gerrit query status:merged project:openstack/nova NOT age:2mon vs. ssh review.openstack.org gerrit query status:merged project:openstack/nova label:Code-Review=-1 NOT age:2mon (after that we exceed 500 reviews on the positive case, so command line counting isn't quite as easy). So we are really looking at 5% occurrence of this kind of behavior. As such it's an exceptional case, and can be handled in an exceptional way. -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
On 05/11/2014 10:26 AM, Mark McLoughlin wrote: On Fri, 2014-05-09 at 08:20 -0400, Sean Dague wrote: Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit. ex: https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard (replace openstack/nova with the project of your choice). This provides 3 sections. = Needs Final +2 = This is code that has an existing +2, no negative code review feedback, and positive jenkins score. So it's mergable if you provide the final +2. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 label:Code-Review=2 NOT label:Workflow=-1 limit:50 ) = No negative feedback = Changes that have no negative code review feedback, and positive jenkins score. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 NOT label:Workflow=-1 limit:50 ) = Wayward changes = Changes that have no code review feedback at all (no one has looked at it), a positive jenkins score, and are older than 2 days. (Gerrit Query: status:open label:Verified=1,jenkins NOT label:Workflow=-1 NOT label:Code-Review=2 age:2d) In all cases it filters out patches that you've commented on in the most recently revision. So as you vote on these things they will disappear from your list. Hopefully people will find this dashboard also useful. Nicely done. Any reason you've included the stable branches - i.e. not restricted it to branch:master ? Because it hadn't quite occurred to me yet to filter it out. I think that would be a good change. Joe also mentioned filtering out things you own: NOT owner:self. Which I also think would be a good change. The processing of changing these is currently a little odd because of where they live in the gerrit meta data. I'm hoping we can get this into a normal code review flow in the next couple of weeks and get these changes in, as well making it easy to get people to add new additional dashboards as well. -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
On Fri, 2014-05-09 at 08:20 -0400, Sean Dague wrote: Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit. ex: https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard (replace openstack/nova with the project of your choice). This provides 3 sections. = Needs Final +2 = This is code that has an existing +2, no negative code review feedback, and positive jenkins score. So it's mergable if you provide the final +2. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 label:Code-Review=2 NOT label:Workflow=-1 limit:50 ) = No negative feedback = Changes that have no negative code review feedback, and positive jenkins score. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 NOT label:Workflow=-1 limit:50 ) = Wayward changes = Changes that have no code review feedback at all (no one has looked at it), a positive jenkins score, and are older than 2 days. (Gerrit Query: status:open label:Verified=1,jenkins NOT label:Workflow=-1 NOT label:Code-Review=2 age:2d) In all cases it filters out patches that you've commented on in the most recently revision. So as you vote on these things they will disappear from your list. Hopefully people will find this dashboard also useful. Nicely done. Any reason you've included the stable branches - i.e. not restricted it to branch:master ? Thanks, Mark. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
On 05/09/2014 08:20 AM, Sean Dague wrote: Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit. ex: https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard (replace openstack/nova with the project of your choice). This provides 3 sections. = Needs Final +2 = This is code that has an existing +2, no negative code review feedback, and positive jenkins score. So it's mergable if you provide the final +2. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 label:Code-Review=2 NOT label:Workflow=-1 limit:50 ) = No negative feedback = Changes that have no negative code review feedback, and positive jenkins score. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 NOT label:Workflow=-1 limit:50 ) = Wayward changes = Changes that have no code review feedback at all (no one has looked at it), a positive jenkins score, and are older than 2 days. (Gerrit Query: status:open label:Verified=1,jenkins NOT label:Workflow=-1 NOT label:Code-Review=2 age:2d) In all cases it filters out patches that you've commented on in the most recently revision. So as you vote on these things they will disappear from your list. Hopefully people will find this dashboard also useful. This is awesome. Thank you SO much, Sean. Best, -jay ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
On 05/09/2014 02:20 PM, Sean Dague wrote:
Based on some of my blog posts on gerrit queries, I've built and gotten
integrated a custom inbox zero dashboard which is per project in gerrit.
ex:
https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard
(replace openstack/nova with the project of your choice).
[...]
Great, thanks! Is it possible to have more than one project shown?
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
On 05/09/2014 08:28 AM, Andreas Jaeger wrote: On 05/09/2014 02:20 PM, Sean Dague wrote: Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit. ex: https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard (replace openstack/nova with the project of your choice). [...] Great, thanks! Is it possible to have more than one project shown? Andreas Unfortunately not. Gerrit's got a limitation that custom dashboards either apply to All-Projects, or with a per project iterator. -Sean -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
Sean, Very cool - thanks for providing. One question - for Trove, we have Jenkins but also voting jobs on reddwarf - any way to change the No Negative Feedback section to take into account reddwarf failures? Regards, Doug -Original Message- From: Sean Dague [mailto:s...@dague.net] Sent: May-09-14 8:21 AM To: OpenStack Development Mailing List (not for usage questions) Subject: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit. ex: https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard (replace openstack/nova with the project of your choice). This provides 3 sections. = Needs Final +2 = This is code that has an existing +2, no negative code review feedback, and positive jenkins score. So it's mergable if you provide the final +2. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 label:Code-Review=2 NOT label:Workflow=-1 limit:50 ) = No negative feedback = Changes that have no negative code review feedback, and positive jenkins score. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 NOT label:Workflow=-1 limit:50 ) = Wayward changes = Changes that have no code review feedback at all (no one has looked at it), a positive jenkins score, and are older than 2 days. (Gerrit Query: status:open label:Verified=1,jenkins NOT label:Workflow=-1 NOT label:Code-Review=2 age:2d) In all cases it filters out patches that you've commented on in the most recently revision. So as you vote on these things they will disappear from your list. Hopefully people will find this dashboard also useful. -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
There are a lot of 3rd party CI systems, and strictly speaking projects only need to pass jenkins to make it through, so I don't think that's fundamentally something we want to add here. There is some ability to create per project dashboards as well, if you wanted to build something just for trove in the trove repository. Documentation on custom dashboards is here - https://review.openstack.org/Documentation/user-dashboards.html Realize that every project is going to have a class of concerns, so these are attempting to be generically applicable rules that would apply anywhere, and highlight code that's basically waiting on reviewers, not waiting on the authors to take an action. -Sean On 05/09/2014 08:42 AM, Doug Shelley wrote: Sean, Very cool - thanks for providing. One question - for Trove, we have Jenkins but also voting jobs on reddwarf - any way to change the No Negative Feedback section to take into account reddwarf failures? Regards, Doug -Original Message- From: Sean Dague [mailto:s...@dague.net] Sent: May-09-14 8:21 AM To: OpenStack Development Mailing List (not for usage questions) Subject: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit. ex: https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard (replace openstack/nova with the project of your choice). This provides 3 sections. = Needs Final +2 = This is code that has an existing +2, no negative code review feedback, and positive jenkins score. So it's mergable if you provide the final +2. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 label:Code-Review=2 NOT label:Workflow=-1 limit:50 ) = No negative feedback = Changes that have no negative code review feedback, and positive jenkins score. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 NOT label:Workflow=-1 limit:50 ) = Wayward changes = Changes that have no code review feedback at all (no one has looked at it), a positive jenkins score, and are older than 2 days. (Gerrit Query: status:open label:Verified=1,jenkins NOT label:Workflow=-1 NOT label:Code-Review=2 age:2d) In all cases it filters out patches that you've commented on in the most recently revision. So as you vote on these things they will disappear from your list. Hopefully people will find this dashboard also useful. -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
You have to be logged in for it to work, as it references self. It's a limitation that we couldn't find a nice solution around. On 05/09/2014 10:00 AM, Jesus M. Gonzalez-Barahona wrote: Hi, Sean, I'm getting: Code Review - Error Error in operator label:Code-Review=0,self And maybe some more text that I cannot read, because of black background, and a button to Continue, which if I click leads me to the usual Gerrit page... Am I missing something? Jesus. On Fri, 2014-05-09 at 08:20 -0400, Sean Dague wrote: Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit. ex: https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard (replace openstack/nova with the project of your choice). This provides 3 sections. = Needs Final +2 = This is code that has an existing +2, no negative code review feedback, and positive jenkins score. So it's mergable if you provide the final +2. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 label:Code-Review=2 NOT label:Workflow=-1 limit:50 ) = No negative feedback = Changes that have no negative code review feedback, and positive jenkins score. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 NOT label:Workflow=-1 limit:50 ) = Wayward changes = Changes that have no code review feedback at all (no one has looked at it), a positive jenkins score, and are older than 2 days. (Gerrit Query: status:open label:Verified=1,jenkins NOT label:Workflow=-1 NOT label:Code-Review=2 age:2d) In all cases it filters out patches that you've commented on in the most recently revision. So as you vote on these things they will disappear from your list. Hopefully people will find this dashboard also useful. -Sean ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Sean Dague http://dague.net signature.asc Description: OpenPGP digital signature ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
Hi Sean, That’s pretty cool and helpful. Thanks for providing this. -Original Message- From: Sean Dague [mailto:s...@dague.net] Sent: Friday, May 9, 2014 9:21 PM To: OpenStack Development Mailing List (not for usage questions) Subject: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit. ex: https://review.openstack.org/#/projects/openstack/nova,dashboards/impo https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard rtant-changes:review-inbox-dashboard https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard (replace openstack/nova with the project of your choice). This provides 3 sections. = Needs Final +2 = This is code that has an existing +2, no negative code review feedback, and positive jenkins score. So it's mergable if you provide the final +2. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 label:Code-Review=2 NOT label:Workflow=-1 limit:50 ) = No negative feedback = Changes that have no negative code review feedback, and positive jenkins score. (Gerrit Query: status:open NOT label:Code-Review=0,self label:Verified=1,jenkins NOT label:Code-Review=-1 NOT label:Workflow=-1 limit:50 ) = Wayward changes = Changes that have no code review feedback at all (no one has looked at it), a positive jenkins score, and are older than 2 days. (Gerrit Query: status:open label:Verified=1,jenkins NOT label:Workflow=-1 NOT label:Code-Review=2 age:2d) In all cases it filters out patches that you've commented on in the most recently revision. So as you vote on these things they will disappear from your list. Hopefully people will find this dashboard also useful. -Sean -- Sean Dague http://dague.net -- Thanks Regards Ghanshyam Mann ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
Doug Shelley writes: Very cool - thanks for providing. One question - for Trove, we have Jenkins but also voting jobs on reddwarf - any way to change the No Negative Feedback section to take into account reddwarf failures? Hi Doug: We're working on moving the reddwarf trove tests to OpenStack Infra CI in Juno, so this shouldn't be an issue long-term. For the short term, I've set up a URI-based custom dashboard for Trove that uses Sean's gerrit queries as a base (thanks Sean!), and does take into account the outcome of the reddwarf tests as well. http://bit.do/trove-reviews ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
