Re: [openstack-dev] [bashate] .bashateignore

2014-09-02 Thread Ian Wienand
On 09/02/2014 10:13 PM, Sean Dague wrote: One of the things that could make it better is to add file extensions to all shell files in devstack. This would also solve the issue of gerrit not syntax highlighting most of the files. If people are up for that, I'll propose a rename patch to get us

Re: [openstack-dev] [bashate] .bashateignore

2014-09-02 Thread Robert Collins
Well, git knows all the files in-tree, right? Or am I missing something here? if-has-bash-hashbang-and-is-versioned-then-bashate-it? -Rob On 3 September 2014 13:26, Ian Wienand iwien...@redhat.com wrote: On 09/02/2014 10:13 PM, Sean Dague wrote: One of the things that could make it better is

Re: [openstack-dev] [bashate] .bashateignore

2014-09-02 Thread Dean Troyer
On Tue, Sep 2, 2014 at 8:32 PM, Robert Collins robe...@robertcollins.net wrote: Well, git knows all the files in-tree, right? Or am I missing something here? if-has-bash-hashbang-and-is-versioned-then-bashate-it? It's not quote that simple, none of the include files have a shebang line;

Re: [openstack-dev] [bashate] .bashateignore

2014-09-02 Thread Ian Wienand
On 09/03/2014 11:32 AM, Robert Collins wrote: if-has-bash-hashbang-and-is-versioned-then-bashate-it? That misses library files that aren't execed and have no #! This might be an appropriate rule for test infrastructure to generate a list for their particular project, but IMO I don't think we

Re: [openstack-dev] [bashate] .bashateignore

2014-08-31 Thread Ian Wienand
On 08/29/2014 10:42 PM, Sean Dague wrote: I'm actually kind of convinced now that none of these approaches are what we need, and that we should instead have a .bashateignore file in the root dir for the project instead, which would be regex that would match files or directories to throw out of

Re: [openstack-dev] [bashate] .bashateignore

2014-08-29 Thread Dean Troyer
On Fri, Aug 29, 2014 at 7:42 AM, Sean Dague s...@dague.net wrote: Integrating bashate into something as complicated as devstack, the file ignore problem has come up. We seem to have 3 approaches out under review right now: https://review.openstack.org/#/c/117425 : --exclude-dirs

Re: [openstack-dev] [bashate] .bashateignore

2014-08-29 Thread Sean Dague
On 08/29/2014 08:53 AM, Dean Troyer wrote: On Fri, Aug 29, 2014 at 7:42 AM, Sean Dague s...@dague.net mailto:s...@dague.net wrote: Integrating bashate into something as complicated as devstack, the file ignore problem has come up. We seem to have 3 approaches out under review

Re: [openstack-dev] [bashate] .bashateignore

2014-08-29 Thread Dean Troyer
On Fri, Aug 29, 2014 at 9:02 AM, Sean Dague s...@dague.net wrote: If pathspec did the right thing, pulling in the extra dep would be fine, but it doesn't seem like it does. After looking at it with fresh eyes, the issue could be resolved by combining two methods from pathspec and still