Re: [openstack-dev] [ceilometer][gnocchi] some code not very understood

2017-12-07 Thread Julien Danjou 
On Thu, Dec 07 2017, Jaze Lee wrote:

> Yes. I misunderstand here. If there any exception in gnocchi api, it
> won't store any measures.
> Just after all resource, and all metrics are there, gnocchi will store
> those measures. Am i right?

Yes.

-- 
Julien Danjou
# Free Software hacker
# https://julien.danjou.info


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ceilometer][gnocchi] some code not very understood

2017-12-07 Thread Jaze Lee 
2017-12-07 16:36 GMT+08:00 Julien Danjou :
> On Thu, Dec 07 2017, Jaze Lee wrote:
>
>>I think at line 416, we should remove some measures that already post at 
>> 390.
>>Or may be i miss something?
>>
>>
>> https://github.com/openstack/ceilometer/blob/master/ceilometer/publisher/gnocchi.py#L416
>
> The code at L416 is only executed if L390 raises an exception.
> So if L390 raises an exception, it has not complete. That's why it's
> done again here.
Yes. I misunderstand here. If there any exception in gnocchi api, it
won't store any measures.
Just after all resource, and all metrics are there, gnocchi will store
those measures. Am i right?



>
> --
> Julien Danjou
> # Free Software hacker
> # https://julien.danjou.info



-- 
谦谦君子

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ceilometer][gnocchi] some code not very understood

2017-12-07 Thread Julien Danjou 
On Thu, Dec 07 2017, Jaze Lee wrote:

>I think at line 416, we should remove some measures that already post at 
> 390.
>Or may be i miss something?
>
>
> https://github.com/openstack/ceilometer/blob/master/ceilometer/publisher/gnocchi.py#L416

The code at L416 is only executed if L390 raises an exception.
So if L390 raises an exception, it has not complete. That's why it's
done again here.

-- 
Julien Danjou
# Free Software hacker
# https://julien.danjou.info


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev