Re: [openstack-dev] [cinder][globalization] Need input on how to proceed .

2014-05-02 Thread Jay S. Bryant
Thanks for the input Duncan. The removal of the debug logs is really a separate issue. I was just hoping to reduce the number of patches that would touch a large number of files. As we are thinking through this though, it really is a separate change so it is best to do separate patches. On a

Re: [openstack-dev] [cinder][globalization] Need input on how to proceed .

2014-05-01 Thread Duncan Thomas
That sounds like a sensible way forward, yes. If the dependency is not need, then great, makes review and merge even easier. Thanks On 28 April 2014 17:03, Jay S. Bryant jsbry...@electronicjungle.net wrote: Duncan, Thanks for the response. Have some additional thoughts, in-line, below:

Re: [openstack-dev] [cinder][globalization] Need input on how to proceed .

2014-04-28 Thread Duncan Thomas
Two separate patches, or even two chains of separate patches, will make reviewing and more importantly (hopefully temporary) backouts easier. It will also reduce the number of merge conflicts, which are still likely to be substantial. There's no benefit at all to all of this being done in one

Re: [openstack-dev] [cinder][globalization] Need input on how to proceed .

2014-04-28 Thread Jay S. Bryant
Duncan, Thanks for the response. Have some additional thoughts, in-line, below: On Mon, 2014-04-28 at 12:15 +0100, Duncan Thomas wrote: Two separate patches, or even two chains of separate patches, will make reviewing and more importantly (hopefully temporary) backouts easier. It will also