Re: [openstack-dev] [cinder] qemu-img disk corruption bug to patch or not?
Potentially corrupted images are bad; depending on the affected data it might only be diagnosed some time after installation, so IMO the fix is needed. Sure but there is a (potentially hefty) performance impact. Well, do you want fast or working/consistent images? Only a minor issue: I'd like to see it have a check for the qemu version, and only then kick in. That dosn't work as $distro may have a qemu 2.0.x that has the fix backported. That's why the workarounds group was created. You specify the safe default and if a distributor knows it's package is safe it can alter the default. Oh, okay... with the safe default being derived from the qemu version ;) At some point you can invert that or remove the option altogether. Yeah, 5 years down the line ... ;[ __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [cinder] qemu-img disk corruption bug to patch or not?
On Fri, Feb 20, 2015 at 12:40:34PM +0100, Philipp Marek wrote: Well, do you want fast or working/consistent images? Sure I often said I'll take slow and correct over fast and buggy anyday. Oh, okay... with the safe default being derived from the qemu version ;) Umm excuse my ignorance but can we actually do a runtime determeined default or are you talking about something more like def maybe_fsync(path) if not CONF.option: return if CONF.option or qemu_version() (2.1.0): do_sync(path) I'm happy to do what the cinder community wants/needs as long as I know what that is up front :) Yours Tony. pgpZBiUc0QKF0.pgp Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [cinder] qemu-img disk corruption bug to patch or not?
On Fri, Feb 20, 2015 at 07:27:33AM +0100, Philipp Marek wrote: Potentially corrupted images are bad; depending on the affected data it might only be diagnosed some time after installation, so IMO the fix is needed. Sure but there is a (potentially hefty) performance impact. Only a minor issue: I'd like to see it have a check for the qemu version, and only then kick in. That dosn't work as $distro may have a qemu 2.0.x that has the fix backported. That's why the workarounds group was created. You specify the safe default and if a distributor knows it's package is safe it can alter the default. At some point you can invert that or remove the option altogether. Yours Tony. pgpT3f8GWB3Kv.pgp Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [cinder] qemu-img disk corruption bug to patch or not?
On Thu, Feb 19, 2015 at 5:53 PM, Tony Breeds t...@bakeyournoodle.com wrote: Hi all, In September I started working on a simple (but controvertial) fix in nova[1] to avoid some disk corruption issues. John kindly ran with a similar fix to cinder[2]. John's review ended up in merge conflict so I tried my own version [3]. While (trying) to add workarounds to nova (and cinder) upstream qemu-img was fixed. A tracking page for distros was maintained [4]. At the nova mid-cycle it was decided that enough distros had the fix that juno and kilo would mostly be unaffected. So my question is pretty simple. Does Cinder want/need the fix? If so I'll work on knocking [3] into shape if not I'll abandon it. Yours Tony. [1] https://review.openstack.org/123957 [2] https://review.openstack.org/141259 [3] https://review.openstack.org/143575 [4] https://wiki.openstack.org/wiki/Bug1368815 Hi Tony, Thanks for sending this out, and for the complete summary. I'm inclined to lean towards working the option for Cinder personally. Granted it looks like the update is in the distro packages to fix this, but I'm wondering about backport and cases for installs that are on say 12.04? Maybe that's not an issue? Anybody else have thoughts on this? Thanks, John __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [cinder] qemu-img disk corruption bug to patch or not?
In September I started working on a simple (but controvertial) fix in nova[1] to avoid some disk corruption issues. John kindly ran with a similar fix to cinder[2]. John's review ended up in merge conflict so I tried my own version [3]. Thanks for sending this out, and for the complete summary. I'm inclined to lean towards working the option for Cinder personally. Granted it looks like the update is in the distro packages to fix this, but I'm wondering about backport and cases for installs that are on say 12.04? Maybe that's not an issue? Anybody else have thoughts on this? Potentially corrupted images are bad; depending on the affected data it might only be diagnosed some time after installation, so IMO the fix is needed. Only a minor issue: I'd like to see it have a check for the qemu version, and only then kick in. Regards, Phil -- : Ing. Philipp Marek : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com : DRBD® and LINBIT® are registered trademarks of LINBIT, Austria. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
