Re: [openstack-dev] [gerrit] Gerrit review problem

2014-12-01 Thread Thierry Carrez
Jay Lau wrote:
 
 When I review a patch for OpenStack, after review finished, I want to
 check more patches for this project and then after click the Project
 content for this patch, it will **not** jump to all patches but project
 description. I think it is not convenient for a reviewer if s/he wants
 to review more patches for this project.

I usually click on the name of the branch (master) just below to
workaround that UI issue. That gives me the list of patches to review in
same branch, same project, which is generally a good approximation of
what I want.

-- 
Thierry Carrez (ttx)

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [gerrit] Gerrit review problem

2014-12-01 Thread Jeremy Stanley
On 2014-12-01 17:04:23 +0800 (+0800), Jay Lau wrote:
 Cool, Thierry! I see. This is really what I want ;-)

Also note that we're not running a modified version of Gerrit, so if
a behavior change is desired it likely needs to be reported at
http://code.google.com/p/gerrit/issues instead.
-- 
Jeremy Stanley

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [gerrit] Gerrit review problem

2014-11-30 Thread Chen CH Ji
+1, I also found this inconvenient point before ,thanks Jay for bring up :)

Best Regards!

Kevin (Chen) Ji 纪 晨

Engineer, zVM Development, CSTL
Notes: Chen CH Ji/China/IBM@IBMCN   Internet: jiche...@cn.ibm.com
Phone: +86-10-82454158
Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District,
Beijing 100193, PRC



From:   Jay Lau jay.lau@gmail.com
To: OpenStack Development Mailing List
openstack-dev@lists.openstack.org
Date:   12/01/2014 01:56 PM
Subject:[openstack-dev] [gerrit] Gerrit review problem




When I review a patch for OpenStack, after review finished, I want to check
more patches for this project and then after click the Project content
for this patch, it will **not** jump to all patches but project
description. I think it is not convenient for a reviewer if s/he wants to
review more patches for this project.

内嵌图片 1

内嵌图片 2

--
Thanks,

Jay___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [gerrit] Gerrit review problem

2014-11-30 Thread Steve Martinelli
Clicking on the magnifying glass icon (next to the project name) lists
all recent patches for that project (closed and open).

I have a bookmark that lists all open reviews of a project and
always try to keep it open in a tab, and open specific code reviews in
new tabs.

Steve

Chen CH Ji jiche...@cn.ibm.com wrote on 12/01/2014 12:59:52 AM:

 From: Chen CH Ji jiche...@cn.ibm.com
 To: OpenStack Development Mailing List \(not for usage questions\)
 openstack-dev@lists.openstack.org
 Date: 12/01/2014 01:09 AM
 Subject: Re: [openstack-dev] [gerrit] Gerrit review problem
 
 +1, I also found this inconvenient point before ,thanks Jay for bring up 
:)
 
 Best Regards! 
 
 Kevin (Chen) Ji 纪 晨
 
 Engineer, zVM Development, CSTL
 Notes: Chen CH Ji/China/IBM@IBMCN   Internet: jiche...@cn.ibm.com
 Phone: +86-10-82454158
 Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian 
 District, Beijing 100193, PRC 
 
 [image removed] Jay Lau ---12/01/2014 01:56:48 PM---When I review a 
 patch for OpenStack, after review finished, I want to check more 
 patches for this pr
 
 From: Jay Lau jay.lau@gmail.com
 To: OpenStack Development Mailing List 
openstack-dev@lists.openstack.org
 Date: 12/01/2014 01:56 PM
 Subject: [openstack-dev] [gerrit] Gerrit review problem
 
 
 
 
 When I review a patch for OpenStack, after review finished, I want 
 to check more patches for this project and then after click the 
 Project content for this patch, it will **not** jump to all 
 patches but project description. I think it is not convenient for a 
 reviewer if s/he wants to review more patches for this project.
 
 [image removed] 
 
 [image removed] 
 
 -- 
 Thanks,
 
 Jay___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [gerrit] Gerrit review problem

2014-11-30 Thread Jay Lau
Thanks all, yes, there are ways I can get all on-going patches for one
project, I was complaining this because I can always direct to the right
page before gerrit review upgrade, the upgrade broken this feature which
makes not convenient for reviewers...

2014-12-01 14:13 GMT+08:00 Steve Martinelli steve...@ca.ibm.com:

 Clicking on the magnifying glass icon (next to the project name) lists
 all recent patches for that project (closed and open).

 I have a bookmark that lists all open reviews of a project and
 always try to keep it open in a tab, and open specific code reviews in
 new tabs.

 Steve

 Chen CH Ji jiche...@cn.ibm.com wrote on 12/01/2014 12:59:52 AM:

  From: Chen CH Ji jiche...@cn.ibm.com
  To: OpenStack Development Mailing List \(not for usage questions\)
  openstack-dev@lists.openstack.org
  Date: 12/01/2014 01:09 AM
  Subject: Re: [openstack-dev] [gerrit] Gerrit review problem
 
  +1, I also found this inconvenient point before ,thanks Jay for bring up
 :)
 
  Best Regards!
 
  Kevin (Chen) Ji 纪 晨
 
  Engineer, zVM Development, CSTL
  Notes: Chen CH Ji/China/IBM@IBMCN   Internet: jiche...@cn.ibm.com
  Phone: +86-10-82454158
  Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian
  District, Beijing 100193, PRC
 
  [image removed] Jay Lau ---12/01/2014 01:56:48 PM---When I review a
  patch for OpenStack, after review finished, I want to check more
  patches for this pr
 
  From: Jay Lau jay.lau@gmail.com
  To: OpenStack Development Mailing List 
 openstack-dev@lists.openstack.org
  Date: 12/01/2014 01:56 PM
  Subject: [openstack-dev] [gerrit] Gerrit review problem
 
 
 
 
  When I review a patch for OpenStack, after review finished, I want
  to check more patches for this project and then after click the
  Project content for this patch, it will **not** jump to all
  patches but project description. I think it is not convenient for a
  reviewer if s/he wants to review more patches for this project.
 
  [image removed]
 
  [image removed]
 
  --
  Thanks,
 
  Jay___
  OpenStack-dev mailing list
  OpenStack-dev@lists.openstack.org
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

  ___
  OpenStack-dev mailing list
  OpenStack-dev@lists.openstack.org
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




-- 
Thanks,

Jay
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [gerrit] Gerrit review problem

2014-11-30 Thread OpenStack Dev
Jay this has been informed  discussed, pre  post the gerrit upgrade :)

On Mon Dec 01 2014 at 12:00:02 PM Jay Lau jay.lau@gmail.com wrote:

 Thanks all, yes, there are ways I can get all on-going patches for one
 project, I was complaining this because I can always direct to the right
 page before gerrit review upgrade, the upgrade broken this feature which
 makes not convenient for reviewers...

 2014-12-01 14:13 GMT+08:00 Steve Martinelli steve...@ca.ibm.com:

 Clicking on the magnifying glass icon (next to the project name) lists
 all recent patches for that project (closed and open).

 I have a bookmark that lists all open reviews of a project and
 always try to keep it open in a tab, and open specific code reviews in
 new tabs.

 Steve

 Chen CH Ji jiche...@cn.ibm.com wrote on 12/01/2014 12:59:52 AM:

  From: Chen CH Ji jiche...@cn.ibm.com
  To: OpenStack Development Mailing List \(not for usage questions\)
  openstack-dev@lists.openstack.org
  Date: 12/01/2014 01:09 AM
  Subject: Re: [openstack-dev] [gerrit] Gerrit review problem
 
  +1, I also found this inconvenient point before ,thanks Jay for bring
 up :)
 
  Best Regards!
 
  Kevin (Chen) Ji 纪 晨
 
  Engineer, zVM Development, CSTL
  Notes: Chen CH Ji/China/IBM@IBMCN   Internet: jiche...@cn.ibm.com
  Phone: +86-10-82454158
  Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian
  District, Beijing 100193, PRC
 
  [image removed] Jay Lau ---12/01/2014 01:56:48 PM---When I review a
  patch for OpenStack, after review finished, I want to check more
  patches for this pr
 
  From: Jay Lau jay.lau@gmail.com
  To: OpenStack Development Mailing List 
 openstack-dev@lists.openstack.org
  Date: 12/01/2014 01:56 PM
  Subject: [openstack-dev] [gerrit] Gerrit review problem
 
 
 
 
  When I review a patch for OpenStack, after review finished, I want
  to check more patches for this project and then after click the
  Project content for this patch, it will **not** jump to all
  patches but project description. I think it is not convenient for a
  reviewer if s/he wants to review more patches for this project.
 
  [image removed]
 
  [image removed]
 
  --
  Thanks,
 
  Jay___
  OpenStack-dev mailing list
  OpenStack-dev@lists.openstack.org
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

  ___
  OpenStack-dev mailing list
  OpenStack-dev@lists.openstack.org
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




 --
 Thanks,

 Jay
  ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [gerrit] Gerrit review problem

2014-11-30 Thread Jay Lau
I'm OK if all reviewers agree on this proposal, I may need to bookmark the
projects that I want to review. ;-)

2014-12-01 14:35 GMT+08:00 OpenStack Dev cools...@gmail.com:

 Jay this has been informed  discussed, pre  post the gerrit upgrade :)


 On Mon Dec 01 2014 at 12:00:02 PM Jay Lau jay.lau@gmail.com wrote:

 Thanks all, yes, there are ways I can get all on-going patches for one
 project, I was complaining this because I can always direct to the right
 page before gerrit review upgrade, the upgrade broken this feature which
 makes not convenient for reviewers...

 2014-12-01 14:13 GMT+08:00 Steve Martinelli steve...@ca.ibm.com:

 Clicking on the magnifying glass icon (next to the project name) lists
 all recent patches for that project (closed and open).

 I have a bookmark that lists all open reviews of a project and
 always try to keep it open in a tab, and open specific code reviews in
 new tabs.

 Steve

 Chen CH Ji jiche...@cn.ibm.com wrote on 12/01/2014 12:59:52 AM:

  From: Chen CH Ji jiche...@cn.ibm.com
  To: OpenStack Development Mailing List \(not for usage questions\)
  openstack-dev@lists.openstack.org
  Date: 12/01/2014 01:09 AM
  Subject: Re: [openstack-dev] [gerrit] Gerrit review problem
 
  +1, I also found this inconvenient point before ,thanks Jay for bring
 up :)
 
  Best Regards!
 
  Kevin (Chen) Ji 纪 晨
 
  Engineer, zVM Development, CSTL
  Notes: Chen CH Ji/China/IBM@IBMCN   Internet: jiche...@cn.ibm.com
  Phone: +86-10-82454158
  Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian
  District, Beijing 100193, PRC
 
  [image removed] Jay Lau ---12/01/2014 01:56:48 PM---When I review a
  patch for OpenStack, after review finished, I want to check more
  patches for this pr
 
  From: Jay Lau jay.lau@gmail.com
  To: OpenStack Development Mailing List 
 openstack-dev@lists.openstack.org
  Date: 12/01/2014 01:56 PM
  Subject: [openstack-dev] [gerrit] Gerrit review problem
 
 
 
 
  When I review a patch for OpenStack, after review finished, I want
  to check more patches for this project and then after click the
  Project content for this patch, it will **not** jump to all
  patches but project description. I think it is not convenient for a
  reviewer if s/he wants to review more patches for this project.
 
  [image removed]
 
  [image removed]
 
  --
  Thanks,
 
  Jay___
  OpenStack-dev mailing list
  OpenStack-dev@lists.openstack.org
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

  ___
  OpenStack-dev mailing list
  OpenStack-dev@lists.openstack.org
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




 --
 Thanks,

 Jay
  ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


 ___
 OpenStack-dev mailing list
 OpenStack-dev@lists.openstack.org
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




-- 
Thanks,

Jay
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [gerrit] Gerrit review problem

2014-11-30 Thread Andreas Jaeger
On 12/01/2014 08:16 AM, Jay Lau wrote:
 I'm OK if all reviewers agree on this proposal, I may need to bookmark
 the projects that I want to review. ;-)


Add the projects you want to review to your watch list (via
Settings-Watched Projects) and see all open patches in your watched
changes list: https://review.openstack.org/#/q/is:watched+status:open,n,z

You can also create a personal dashboard using
http://git.openstack.org/cgit/stackforge/gerrit-dash-creator/ . Several
projects have their own dashboards, see for example:
http://is.gd/openstackdocsreview


Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF:Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB 21284 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev