Re: [openstack-dev] [glance][feature freeze exception] Proposal for using Launcher/ProcessLauncher for launching services

2014-09-05 Thread Thierry Carrez
Kekane, Abhishek wrote:
 [...]
 If we have this feature in glance then we can able to use features like
 reload glance configuration file without restart, graceful shutdown etc.
 
 Also it will use common code like other OpenStack projects nova,
 keystone, cinder does.

I think it makes a lot of sense but it also has a lot of documentation
consequences. If it was ready to merge and had the necessary reviews
piled up I would +1 this but the way it stands now (and given Glance's
current review velocity) I'm more leaning towards -1.

Cheers,

-- 
Thierry Carrez (ttx)

___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [glance][feature freeze exception] Proposal for using Launcher/ProcessLauncher for launching services

2014-09-05 Thread Anne Gentle
On Wed, Sep 3, 2014 at 2:07 PM, Kekane, Abhishek 
abhishek.kek...@nttdata.com wrote:

  Hi  Erno,

 I agree that we must document what all config parameters will be reloaded
 after SIGHUP signal is processed, that's the reason why we have added
 DocImpact tag to patch https://review.openstack.org/#/c/117988/. We will
 test what parameters are reloaded and report them to the Doc team.



The use of a DocImpact flag does not mean a doc person will take the
assignment. The Glance team takes responsibility for any documentation
needed for changes.

If it really is just configuration options that change, we have an
automation script that generates new, changed, and deprecated configuration
options and pulls out the descriptions from the code itself. However you
may want more description about operating the Image Service in this way so
an additional section would help people understand.

From reading the code comments it looks like another approach is preferred,
so my describing the doc process is just so that others on the list know
how DocImpact works.

Anne


  *Our use case:*


  We want to use SIGHUP signal to reload filesystem store related config
 parameters namely filesystem_store_datadir and
 filesystem_store_datadirs which are very crucial in the production
 environment especially for people using NFS. In case, the filesystem is
 approaching at full capacity, administrator can add more storage and
 configured it via the above parameters which will be taken into effect upon
 sending SIGHUP signal. Secondly, most of the OpenStack services uses
 service framework and it does handle reloading of configuration files via
 SIGHUP signal which glance cannot without this patch.


  Thanks  Regards,


  Abhishek Kekane

  --
 *From:* Kekane, Abhishek
 *Sent:* Wednesday, September 03, 2014 9:39 AM
 *To:* OpenStack Development Mailing List (not for usage questions)
 *Subject:* RE: [openstack-dev] [glance][feature freeze exception]
 Proposal for using Launcher/ProcessLauncher for launching services

   Hi All,



 Please give your support me for applying the  freeze exception for using
 oslo-incubator service framework in glance, based on the following
 blueprint:



 https://blueprints.launchpad.net/glance/+spec/use-common-service-framework



 I have ensured that after making these changes everything is working
 smoothly.



 I have done the functional testing for following three scenarios:

 1.   Enabled SSL and checked requests are processed by the Api
 service before and after SIGHUP signal

 2.   Disabled SSL and  checked requests are processed by the Api
 service before and after SIGHUP signal

 3.   I have also ensured reloading of the parameters like
 ilesystem_store_datadir, filesystem_store_datadirs are  working effectively
 after sending the SIGHUP signal.



 To test 1st and 2nd I have created a python script which will send
 multiple requests to glance at a time and added a chron job to send a
 SIGHUP signal to the parent process.

 I have tested above script for 1 hour and confirmed every request has been
 processed successfully.



 Please consider this feature to be a part of Juno release.







 Thanks  Regards,



 Abhishek Kekane





 *From:* Kekane, Abhishek [mailto:abhishek.kek...@nttdata.com]
 *Sent:* 02 September 2014 19:11
 *To:* OpenStack Development Mailing List (
 openstack-dev@lists.openstack.org)
 *Subject:* [openstack-dev] [glance][feature freeze exception] Proposal
 for using Launcher/ProcessLauncher for launching services



 Hi All,



 I'd like to ask for a feature freeze exception for using oslo-incubator
 service framework in glance, based on the following blueprint:



 https://blueprints.launchpad.net/glance/+spec/use-common-service-framework





 The code to implement this feature is under review at present.



 1. Sync oslo-incubator service module in glance:
 https://review.openstack.org/#/c/117135/2

 2. Use Launcher/ProcessLauncher in glance:
 https://review.openstack.org/#/c/117988/





 If we have this feature in glance then we can able to use features like
 reload glance configuration file without restart, graceful shutdown etc.

 Also it will use common code like other OpenStack projects nova, keystone,
 cinder does.





 We are ready to address all the concerns of the community if they have any.





 Thanks  Regards,



 Abhishek Kekane


 __
 Disclaimer:This email and any attachments are sent in strictest confidence
 for the sole use of the addressee and may contain legally privileged,
 confidential, and proprietary data. If you are not the intended recipient,
 please advise the sender by replying promptly to this email and then delete
 and destroy this email and any attachments without any further use, copying
 or forwarding

 __
 Disclaimer:This email and any attachments are sent

Re: [openstack-dev] [glance][feature freeze exception] Proposal for using Launcher/ProcessLauncher for launching services

2014-09-03 Thread Kekane, Abhishek
Hi All,

Please give your support me for applying the  freeze exception for using 
oslo-incubator service framework in glance, based on the following blueprint:

https://blueprints.launchpad.net/glance/+spec/use-common-service-framework

I have ensured that after making these changes everything is working smoothly.

I have done the functional testing for following three scenarios:

1.   Enabled SSL and checked requests are processed by the Api service 
before and after SIGHUP signal

2.   Disabled SSL and  checked requests are processed by the Api service 
before and after SIGHUP signal

3.   I have also ensured reloading of the parameters like 
ilesystem_store_datadir, filesystem_store_datadirs are  working effectively 
after sending the SIGHUP signal.

To test 1st and 2nd I have created a python script which will send multiple 
requests to glance at a time and added a chron job to send a SIGHUP signal to 
the parent process.
I have tested above script for 1 hour and confirmed every request has been 
processed successfully.

Please consider this feature to be a part of Juno release.



Thanks  Regards,

Abhishek Kekane


From: Kekane, Abhishek [mailto:abhishek.kek...@nttdata.com]
Sent: 02 September 2014 19:11
To: OpenStack Development Mailing List (openstack-dev@lists.openstack.org)
Subject: [openstack-dev] [glance][feature freeze exception] Proposal for using 
Launcher/ProcessLauncher for launching services

Hi All,

I'd like to ask for a feature freeze exception for using oslo-incubator service 
framework in glance, based on the following blueprint:

https://blueprints.launchpad.net/glance/+spec/use-common-service-framework


The code to implement this feature is under review at present.

1. Sync oslo-incubator service module in glance: 
https://review.openstack.org/#/c/117135/2
2. Use Launcher/ProcessLauncher in glance: 
https://review.openstack.org/#/c/117988/


If we have this feature in glance then we can able to use features like reload 
glance configuration file without restart, graceful shutdown etc.
Also it will use common code like other OpenStack projects nova, keystone, 
cinder does.


We are ready to address all the concerns of the community if they have any.


Thanks  Regards,

Abhishek Kekane

__
Disclaimer:This email and any attachments are sent in strictest confidence for 
the sole use of the addressee and may contain legally privileged, confidential, 
and proprietary data. If you are not the intended recipient, please advise the 
sender by replying promptly to this email and then delete and destroy this 
email and any attachments without any further use, copying or forwarding

__
Disclaimer:This email and any attachments are sent in strictest confidence for 
the sole use of the addressee and may contain legally privileged, confidential, 
and proprietary data.  If you are not the intended recipient, please advise the 
sender by replying promptly to this email and then delete and destroy this 
email and any attachments without any further use, copying or forwarding___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [glance][feature freeze exception] Proposal for using Launcher/ProcessLauncher for launching services

2014-09-03 Thread Kuvaja, Erno
In principle I like the idea and concept, a lot. In practice I don't think 
glance code is ready in a state that we could say SIGHUP reloads our configs. 
Even more my concern is that based on the behavior seen some config options 
gets picked up and some does not.

As long as we do not have definite list documented what options gets updated on 
the fly and what is the actual behavior at the point when new config is picked 
up (lets say we have some locks in place and locking folder gets updated, what 
happens?) I don't think we should be taking this functionality in. Even the 
current behavior is fundamentally broken, at least it's broken in a way that it 
is consistent and the behavior is known.


-  Erno (jokke_) Kuvaja

kuv...@hp.com

From: Kekane, Abhishek [mailto:abhishek.kek...@nttdata.com]
Sent: 03 September 2014 14:39
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [glance][feature freeze exception] Proposal for 
using Launcher/ProcessLauncher for launching services

Hi All,

Please give your support me for applying the  freeze exception for using 
oslo-incubator service framework in glance, based on the following blueprint:

https://blueprints.launchpad.net/glance/+spec/use-common-service-framework

I have ensured that after making these changes everything is working smoothly.

I have done the functional testing for following three scenarios:

1.   Enabled SSL and checked requests are processed by the Api service 
before and after SIGHUP signal

2.   Disabled SSL and  checked requests are processed by the Api service 
before and after SIGHUP signal

3.   I have also ensured reloading of the parameters like 
ilesystem_store_datadir, filesystem_store_datadirs are  working effectively 
after sending the SIGHUP signal.

To test 1st and 2nd I have created a python script which will send multiple 
requests to glance at a time and added a chron job to send a SIGHUP signal to 
the parent process.
I have tested above script for 1 hour and confirmed every request has been 
processed successfully.

Please consider this feature to be a part of Juno release.



Thanks  Regards,

Abhishek Kekane


From: Kekane, Abhishek [mailto:abhishek.kek...@nttdata.com]
Sent: 02 September 2014 19:11
To: OpenStack Development Mailing List 
(openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org)
Subject: [openstack-dev] [glance][feature freeze exception] Proposal for using 
Launcher/ProcessLauncher for launching services

Hi All,

I'd like to ask for a feature freeze exception for using oslo-incubator service 
framework in glance, based on the following blueprint:

https://blueprints.launchpad.net/glance/+spec/use-common-service-framework


The code to implement this feature is under review at present.

1. Sync oslo-incubator service module in glance: 
https://review.openstack.org/#/c/117135/2
2. Use Launcher/ProcessLauncher in glance: 
https://review.openstack.org/#/c/117988/


If we have this feature in glance then we can able to use features like reload 
glance configuration file without restart, graceful shutdown etc.
Also it will use common code like other OpenStack projects nova, keystone, 
cinder does.


We are ready to address all the concerns of the community if they have any.


Thanks  Regards,

Abhishek Kekane

__
Disclaimer:This email and any attachments are sent in strictest confidence for 
the sole use of the addressee and may contain legally privileged, confidential, 
and proprietary data. If you are not the intended recipient, please advise the 
sender by replying promptly to this email and then delete and destroy this 
email and any attachments without any further use, copying or forwarding

__
Disclaimer:This email and any attachments are sent in strictest confidence for 
the sole use of the addressee and may contain legally privileged, confidential, 
and proprietary data. If you are not the intended recipient, please advise the 
sender by replying promptly to this email and then delete and destroy this 
email and any attachments without any further use, copying or forwarding
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [glance][feature freeze exception] Proposal for using Launcher/ProcessLauncher for launching services

2014-09-03 Thread Kekane, Abhishek
Hi  Erno,


I agree that we must document what all config parameters will be reloaded after 
SIGHUP signal is processed, that's the reason why we have added DocImpact tag 
to patch https://review.openstack.org/#/c/117988/. We will test what parameters 
are reloaded and report them to the Doc team.


Our use case:


We want to use SIGHUP signal to reload filesystem store related config 
parameters namely filesystem_store_datadir and filesystem_store_datadirs 
which are very crucial in the production environment especially for people 
using NFS. In case, the filesystem is approaching at full capacity, 
administrator can add more storage and configured it via the above parameters 
which will be taken into effect upon sending SIGHUP signal. Secondly, most of 
the OpenStack services uses service framework and it does handle reloading of 
configuration files via SIGHUP signal which glance cannot without this patch.


Thanks  Regards,


Abhishek Kekane


From: Kekane, Abhishek
Sent: Wednesday, September 03, 2014 9:39 AM
To: OpenStack Development Mailing List (not for usage questions)
Subject: RE: [openstack-dev] [glance][feature freeze exception] Proposal for 
using Launcher/ProcessLauncher for launching services

Hi All,

Please give your support me for applying the  freeze exception for using 
oslo-incubator service framework in glance, based on the following blueprint:

https://blueprints.launchpad.net/glance/+spec/use-common-service-framework

I have ensured that after making these changes everything is working smoothly.

I have done the functional testing for following three scenarios:

1.   Enabled SSL and checked requests are processed by the Api service 
before and after SIGHUP signal

2.   Disabled SSL and  checked requests are processed by the Api service 
before and after SIGHUP signal

3.   I have also ensured reloading of the parameters like 
ilesystem_store_datadir, filesystem_store_datadirs are  working effectively 
after sending the SIGHUP signal.

To test 1st and 2nd I have created a python script which will send multiple 
requests to glance at a time and added a chron job to send a SIGHUP signal to 
the parent process.
I have tested above script for 1 hour and confirmed every request has been 
processed successfully.

Please consider this feature to be a part of Juno release.



Thanks  Regards,

Abhishek Kekane


From: Kekane, Abhishek [mailto:abhishek.kek...@nttdata.com]
Sent: 02 September 2014 19:11
To: OpenStack Development Mailing List (openstack-dev@lists.openstack.org)
Subject: [openstack-dev] [glance][feature freeze exception] Proposal for using 
Launcher/ProcessLauncher for launching services

Hi All,

I'd like to ask for a feature freeze exception for using oslo-incubator service 
framework in glance, based on the following blueprint:

https://blueprints.launchpad.net/glance/+spec/use-common-service-framework


The code to implement this feature is under review at present.

1. Sync oslo-incubator service module in glance: 
https://review.openstack.org/#/c/117135/2
2. Use Launcher/ProcessLauncher in glance: 
https://review.openstack.org/#/c/117988/


If we have this feature in glance then we can able to use features like reload 
glance configuration file without restart, graceful shutdown etc.
Also it will use common code like other OpenStack projects nova, keystone, 
cinder does.


We are ready to address all the concerns of the community if they have any.


Thanks  Regards,

Abhishek Kekane

__
Disclaimer:This email and any attachments are sent in strictest confidence for 
the sole use of the addressee and may contain legally privileged, confidential, 
and proprietary data. If you are not the intended recipient, please advise the 
sender by replying promptly to this email and then delete and destroy this 
email and any attachments without any further use, copying or forwarding

__
Disclaimer:This email and any attachments are sent in strictest confidence for 
the sole use of the addressee and may contain legally privileged, confidential, 
and proprietary data.  If you are not the intended recipient, please advise the 
sender by replying promptly to this email and then delete and destroy this 
email and any attachments without any further use, copying or forwarding___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev