Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Some of our xstatic packages require an elaborate build process, as they use various javascript-based tools to do the build. In this case, it's more than just minification — it's macros and includes, basically a pre-processor, and it would be very hard to re-create that in Python. Thus, we did

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

2018年6月6日(水) 11:54 Xinni Ge : > Hi, akihiro and other guys, > > I understand why minified is considered to be non-free, but I was confused > about the statement > "At the very least, a non-minified version should be present next to the > minified version" [1] > in the documentation. > > Actually

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi, akihiro and other guys, I understand why minified is considered to be non-free, but I was confused about the statement "At the very least, a non-minified version should be present next to the minified version" [1] in the documentation. Actually in existing xstatic repo, I observed several

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi, Sorry for re-using the ancient ML thread. Looking at recent xstatic-* repo reviews, I am a bit afraid that xstatic-cores do not have a common understanding on the principle of xstatic packages. I hope all xstatic-cores re-read "Packing Software" in the horizon contributor docs [1], especially

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Xinni, There is no need that you push a tag manually for official deliverables. You can propose a patch to openstack/releases repository. Horizon PTL or release liaison (at now both Ivan) can confirm it and the release team will approve it. Once it is approved, a release tag will be added and

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Xinni, Please, send me a list of packages which should be released. In general, release-* groups are different from core-*. We should discuss how to go forward with it Regards, Ivan Kolodyazhny, http://blog.e0ne.info/ On Wed, Apr 4, 2018 at 8:34 AM, Xinni Ge wrote:

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Ivan and other Horizon team member, Thanks for adding us into xstatic-core group. But I still need your opinion and help to release the newly-added xstatic packages to pypi index. Current `xstatic-core` group doesn't have the permission to PUSH SIGNED TAG, and I cannot release the first

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Ivan, Thank you very much. I've confirmed that all of us have been added to xstatic-core. As discussed, we will focus on the followings what we added for heat-dashboard, will not touch other xstatic repos as core. xstatic-angular-material xstatic-angular-notify xstatic-angular-uuid

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Kuz, Don't worry, we're on the same page with you. I added both you, Xinni and Keichii to the xstatic-core group. Thank you for your contributions! Regards, Ivan Kolodyazhny, http://blog.e0ne.info/ On Wed, Mar 28, 2018 at 5:18 PM, Kaz Shinohara wrote: > Hi Ivan &

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Ivan & Horizon folks AFAIK, Horizon team had conclusion that you will add the specific members to xstatic-core, correct ? Can I ask you to add the following members ? # All of tree are heat-dashboard core. Kazunori Shinohara / ksnhr.t...@gmail.com #myself Xinni Ge / xinni.ge1...@gmail.com

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Ivan, Akihiro, Thanks for your kind arrangement. Looking forward to hearing your decision soon. Regards, Kaz 2018-03-21 21:43 GMT+09:00 Ivan Kolodyazhny : > HI Team, > > From my perspective, I'm OK both with #2 and #3 options. I agree that #4 > could be too complicated for

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

HI Team, >From my perspective, I'm OK both with #2 and #3 options. I agree that #4 could be too complicated for us. Anyway, we've got this topic on the meeting agenda [1] so we'll discuss it there too. I'll share our decision after the meeting. [1]

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Kaz and Ivan, Yeah, it is worth discussed officially in the horizon team meeting or the mailing list thread to get a consensus. Hopefully you can add this topic to the horizon meeting agenda. After sending the previous mail, I noticed anther option. I see there are several options now. (1)

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Akihiro, Thanks for your comment. The background of my request to add us to xstatic-core comes from Ivan's comment in last PTG's etherpad for heat-dashboard discussion. https://etherpad.openstack.org/p/heat-dashboard-ptg-rocky-discussion Line135, "we can share ownership if needed - e0ne"

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Kaz, These repositories are under horizon project. It looks better to keep the current core team. It potentially brings some confusion if we treat some horizon plugin team specially. Reviewing xstatic repos would be a small burden, wo I think it would work without problem even if only

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Ivan, Horizon folks, Now totally 8 xstatic-** repos for heat-dashboard have been landed. In project-config for them, I've set same acl-config as the existing xstatic repos. It means only "xstatic-core" can manage the newly created repos on gerrit. Could you kindly add "heat-dashboard-core"

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Horizon Team, I reported a bug about lack of ``ADD_XSTATIC_MODULES`` plugin option, and submitted a patch for it. Could you please help to review the patch. https://bugs.launchpad.net/horizon/+bug/1755339 https://review.openstack.org/#/c/552259/ Thank you very much. Best Regards, Xinni On

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Kaz, Thanks for cleaning this up. I put +1 on both of these patches Regards, Ivan Kolodyazhny, http://blog.e0ne.info/ On Tue, Mar 13, 2018 at 4:48 AM, Kaz Shinohara wrote: > Hi Ivan & Horizon folks, > > > Now we are submitting a couple of patches to have the new

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Ivan & Horizon folks, Now we are submitting a couple of patches to have the new xstatic modules. Let me request you to have review the following patches. We need Horizon PTL's +1 to move these forward. project-config https://review.openstack.org/#/c/551978/ governance

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Yes, please do that. We can then discuss in the review about technical details. On Mon, Mar 12, 2018 at 2:54 AM, Xinni Ge wrote: > Hi, Akihiro > > Thanks for the quick reply. > > I agree with your opinion that BASE_XSTATIC_MODULES should not be > modified. > It is much

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi, Akihiro Thanks for the quick reply. I agree with your opinion that BASE_XSTATIC_MODULES should not be modified. It is much better to enhance horizon plugin settings, and I think maybe there could be one option like ADD_XSTATIC_MODULES. This option adds the plugin's xstatic files in

Re: [openstack-dev] [horizon] [heat-dashboard] Horizon plugin settings for new xstatic modules

Hi Xinni, 2018-03-09 12:05 GMT+09:00 Xinni Ge : > Hello Horizon Team, > > I would like to hear about your opinions about how to add new xstatic > modules to horizon settings. > > As for Heat-dashboard project embedded 3rd-party files issue, thanks for > your advices in