Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

I'm late to the party and probably my mail will be meaningless. ;) But -1 from me. Because usually I'm against "oh, nvm, fix it later" approaches at all. I don't see any significant problem of getting any kind of patches (both docs and code) merged in Kolla, especially in comparison to the

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

...@gmail.com] Sent: Wednesday, April 13, 2016 12:03 PM To: OpenStack Development Mailing List (not for usage questions) <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes On Tue, Apr 12, 2016 at 10:05 PM, Steve Gordon <sgor...@r

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

On Tue, Apr 12, 2016 at 10:05 PM, Steve Gordon wrote: > - Original Message - > > From: "Jeff Peeler" > > To: "OpenStack Development Mailing List (not for usage questions)" < > openstack-dev@lists.openstack.org> > > > > On Mon, Apr 11, 2016 at 3:37

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

I value the friendliness and approachability that contributors seek. I am totally fine with minor mistakes in documentation. As they make more changes, they will understand/follow the process. +1 Regards, Vikram Hosakote IRC: vhosakot From: "Steven Dake (stdake)"

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

- Original Message - > From: "Jeff Peeler" > To: "OpenStack Development Mailing List (not for usage questions)" > > > On Mon, Apr 11, 2016 at 3:37 AM, Steven Dake (stdake) > wrote: > > Hey folks, > > > > The

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

On Mon, Apr 11, 2016 at 3:37 AM, Steven Dake (stdake) wrote: > Hey folks, > > The reviewers in Kolla tend to nit-pick the quickstart guide to death during > reviews. I'd like to keep that high bar in place for the QSG, because it is > our most important piece of documentation

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

, April 12, 2016 4:49:09 AM Subject: Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes I've said in the past I'm not a fan of nitpicking docs. That said, I feel it's important for spelling and grammar to be correct. The quickstart guide is the first point of contact

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

I've said in the past I'm not a fan of nitpicking docs. That said, I feel it's important for spelling and grammar to be correct. The quickstart guide is the first point of contact for many people to the project, and rightly or wrongly it will give an overall impression of the quality of the

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

My proposal was for docs-only patches not code contributions with docs. Obviously we want a high bar for code contributions. This is part of the reason we have the DocImpact flag (for folks that don't feel comfortable writing documentation because perhaps of ESL, or other reasons). We already

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

So one way to approach it is to decouple docs from code, make it 2 reviews. We can -1 code without docs and ask to create separate patchset depending on one in question with docs. Then we can nitpick all we want:) new contributor will get his/hers code merged, at least one patchset, so it will

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

On 4/11/16, 1:38 AM, "Gerard Braad" wrote: >Hi, > >On Mon, Apr 11, 2016 at 4:20 PM, Steven Dake (stdake) >wrote: >> On 4/11/16, 12:54 AM, "Gerard Braad" wrote: >> as >>>at the moment getting an environment up-and-running according to the

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

Hi, On Mon, Apr 11, 2016 at 4:20 PM, Steven Dake (stdake) wrote: > On 4/11/16, 12:54 AM, "Gerard Braad" wrote: > as >>at the moment getting an environment up-and-running according to the >>quickstart guide is a hit and miss > I don't think deployment is not hit

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

On 4/11/16, 12:54 AM, "Gerard Braad" wrote: >Hi Steven, > >On Mon, Apr 11, 2016 at 3:37 PM, Steven Dake (stdake) >wrote: >> However, when new >> contributors see the nitpicking going on in reviews, I think they may >>get >> discouraged about writing

Re: [openstack-dev] [kolla][vote] Nit-picking documentation changes

Hi Steven, On Mon, Apr 11, 2016 at 3:37 PM, Steven Dake (stdake) wrote: > However, when new > contributors see the nitpicking going on in reviews, I think they may get > discouraged about writing documentation for other parts of Kolla. This is one of the things I experienced