Re: [openstack-dev] [neutron][cisco] Cisco Nexus requires patched ncclient
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 24/08/14 20:40, Maru Newby wrote: On Aug 24, 2014, at 5:14 PM, Henry Gessau ges...@cisco.com wrote: Ihar Hrachyshka ihrac...@redhat.com wrote: Now, maybe putting the module into requirements.txt is an overkill (though I doubt it). In that case, we could be interested in getting the info in some other centralized way. Maru is of the opinion that it is overkill. I feel the same way, but I am not involved much with deployment issues so my feelings should not sway anyone. Note that ncclient is not the only package used by vendor solutions that is not listed in requirements.txt. The ones I am aware of are: ncclient (cisco and brocade) heleosapi (embrane) a10_neutron_lbaas (a10networks) Maybe we should start exploring some other centralized way to list these type of dependencies? I think each plugin should be able to have its own requirements.txt file to aid in manual deployment and in packaging of a given plugin. This suggests the need to maintain a global plugin requirements file (in the tree) to ensure use of only a single version of any dependencies used across more than one plugin. Given that 3rd party CI is likely having to install these dependencies anyway, I think it would be good to make this deployment reproducible while avoiding the need to add new dependencies to core Neutron. With plans to move most of plugins into separate trees, we will probably just move those plugin specific dependencies there, so that dependencies are both explicit AND not adding exotic dependencies to core package. This sounds like work for after-split time (=after Juno). /Ihar -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBCgAGBQJUDV53AAoJEC5aWaUY1u57qIIIANFifDL2/orIqZ4HL12IWteG YpQrExTHdPksz02gv2WAzbvegcIplHdoJ057vTMYxLXxDKYwomhXkF1AD0ByNsVZ 6gJUYtmNclBGXv1Mf9bDa7xue69Ce/imrRuNbycov+0bZcBm4ilavX2HF6vv3TMW AxF3N3FXlc+hIJYhu8SkgHoHDvonh+/oZ8KCQ8t53uAZWR54wUavQkIo7pwRVlcA CJeJPXWB+nFJVfl5a8yZAUtobhyaN5gJlftLvP4ZcLDTeIpIyaP12Kzf7Ui9f55B STK6VPBQcIr5rN85XaHm0h60bzOaRcJn0wj3pGDv2kEUEEldnLPXpLsRGsnFcnk= =EeG1 -END PGP SIGNATURE- ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][cisco] Cisco Nexus requires patched ncclient
Fwiw I would like to see such dependencies listed so that we can properly install trunk via automation. On 24 Aug 2014 10:43, Maru Newby ma...@redhat.com wrote: On Aug 14, 2014, at 1:55 PM, Ihar Hrachyshka ihrac...@redhat.com wrote: Signed PGP part FYI: I've uploaded a review for openstack/requirements to add the upstream module into the list of potential dependencies [1]. Once it's merged, I'm going to introduce this new requirement for Neutron. The only reason someone would install ncclient would be because they had a brocade or cisco solution that they wanted to integrate with and I don't think that justifies making Neutron depend on the library. Maru [1]: https://review.openstack.org/114213 /Ihar On 12/08/14 16:27, Ihar Hrachyshka wrote: Hey all, as per [1], Cisco Nexus ML2 plugin requires a patched version of ncclient from github. I wonder: - whether this information is still current; - why don't we depend on ncclient thru our requirements.txt file. [1]: https://wiki.openstack.org/wiki/Neutron/ML2/MechCiscoNexus Cheers, /Ihar ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][cisco] Cisco Nexus requires patched ncclient
On Aug 25, 2014, at 11:38 AM, Robert Collins robe...@robertcollins.net wrote: Fwiw I would like to see such dependencies listed so that we can properly install trunk via automation. Do you mean that you want the requirements for all plugins listed somewhere in the tree? Or specifically in Neutron’s requirements.txt? On 24 Aug 2014 10:43, Maru Newby ma...@redhat.com wrote: On Aug 14, 2014, at 1:55 PM, Ihar Hrachyshka ihrac...@redhat.com wrote: Signed PGP part FYI: I've uploaded a review for openstack/requirements to add the upstream module into the list of potential dependencies [1]. Once it's merged, I'm going to introduce this new requirement for Neutron. The only reason someone would install ncclient would be because they had a brocade or cisco solution that they wanted to integrate with and I don't think that justifies making Neutron depend on the library. Maru [1]: https://review.openstack.org/114213 /Ihar On 12/08/14 16:27, Ihar Hrachyshka wrote: Hey all, as per [1], Cisco Nexus ML2 plugin requires a patched version of ncclient from github. I wonder: - whether this information is still current; - why don't we depend on ncclient thru our requirements.txt file. [1]: https://wiki.openstack.org/wiki/Neutron/ML2/MechCiscoNexus Cheers, /Ihar ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][cisco] Cisco Nexus requires patched ncclient
Ihar Hrachyshka ihrac...@redhat.com wrote: Now, maybe putting the module into requirements.txt is an overkill (though I doubt it). In that case, we could be interested in getting the info in some other centralized way. Maru is of the opinion that it is overkill. I feel the same way, but I am not involved much with deployment issues so my feelings should not sway anyone. Note that ncclient is not the only package used by vendor solutions that is not listed in requirements.txt. The ones I am aware of are: ncclient (cisco and brocade) heleosapi (embrane) a10_neutron_lbaas (a10networks) Maybe we should start exploring some other centralized way to list these type of dependencies? ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][cisco] Cisco Nexus requires patched ncclient
On Aug 24, 2014, at 5:14 PM, Henry Gessau ges...@cisco.com wrote: Ihar Hrachyshka ihrac...@redhat.com wrote: Now, maybe putting the module into requirements.txt is an overkill (though I doubt it). In that case, we could be interested in getting the info in some other centralized way. Maru is of the opinion that it is overkill. I feel the same way, but I am not involved much with deployment issues so my feelings should not sway anyone. Note that ncclient is not the only package used by vendor solutions that is not listed in requirements.txt. The ones I am aware of are: ncclient (cisco and brocade) heleosapi (embrane) a10_neutron_lbaas (a10networks) Maybe we should start exploring some other centralized way to list these type of dependencies? I think each plugin should be able to have its own requirements.txt file to aid in manual deployment and in packaging of a given plugin. This suggests the need to maintain a global plugin requirements file (in the tree) to ensure use of only a single version of any dependencies used across more than one plugin. Given that 3rd party CI is likely having to install these dependencies anyway, I think it would be good to make this deployment reproducible while avoiding the need to add new dependencies to core Neutron. Maru ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][cisco] Cisco Nexus requires patched ncclient
On Aug 14, 2014, at 1:55 PM, Ihar Hrachyshka ihrac...@redhat.com wrote: Signed PGP part FYI: I've uploaded a review for openstack/requirements to add the upstream module into the list of potential dependencies [1]. Once it's merged, I'm going to introduce this new requirement for Neutron. The only reason someone would install ncclient would be because they had a brocade or cisco solution that they wanted to integrate with and I don't think that justifies making Neutron depend on the library. Maru [1]: https://review.openstack.org/114213 /Ihar On 12/08/14 16:27, Ihar Hrachyshka wrote: Hey all, as per [1], Cisco Nexus ML2 plugin requires a patched version of ncclient from github. I wonder: - whether this information is still current; - why don't we depend on ncclient thru our requirements.txt file. [1]: https://wiki.openstack.org/wiki/Neutron/ML2/MechCiscoNexus Cheers, /Ihar ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev signature.asc Description: Message signed with OpenPGP using GPGMail ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][cisco] Cisco Nexus requires patched ncclient
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 FYI: I've uploaded a review for openstack/requirements to add the upstream module into the list of potential dependencies [1]. Once it's merged, I'm going to introduce this new requirement for Neutron. [1]: https://review.openstack.org/114213 /Ihar On 12/08/14 16:27, Ihar Hrachyshka wrote: Hey all, as per [1], Cisco Nexus ML2 plugin requires a patched version of ncclient from github. I wonder: - whether this information is still current; - why don't we depend on ncclient thru our requirements.txt file. [1]: https://wiki.openstack.org/wiki/Neutron/ML2/MechCiscoNexus Cheers, /Ihar ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBCgAGBQJT7KO6AAoJEC5aWaUY1u57ft0IAJzPC2o8fz9mwlC47tXGeHpJ uP5HFIMaJaPXIwDnuz2uz8dJQZzBvTo6WrN+SRPb6PL3aGbIW4y2BA4n6NM276Xx PwL8cnBdjQ9INwxn3g9jBceynbm2Yxx3I//2AIT1iu1Io/qjHppkUePxgH33PVMn jw/n00mnCVJgxpHNXuFoe7Mn8UsduhB7xNCnW90t4rc9cfClGhW1T6/Pw2PWc07p 3Kw4OmmTS7q6r89iAmkBgbgdI2WBjdR902gwGxnuwmf7TJLo5Nd+jnvbe4bJ7V1d DHzcFPNffKS2Fjbbxay0GjN+7/dAKHVRqkGQZvGzzEL8ZvqZGzyFojZ9BlnrM4Q= =BZEc -END PGP SIGNATURE- ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][cisco] Cisco Nexus requires patched ncclient
On 8/12/2014 10:27 AM, Ihar Hrachyshka wrote: as per [1], Cisco Nexus ML2 plugin requires a patched version of ncclient from github. I wonder: - - whether this information is still current; Please see: https://review.openstack.org/112175 But we need to do backports before updating the wiki. - - why don't we depend on ncclient thru our requirements.txt file. Do we want to have requirements on things that are only used by a specific vendor plugin? So far it has worked by vendor-specific documentation instructing to manually install the requirement, or vendor-tailored deployment tools/scripts. [1]: https://wiki.openstack.org/wiki/Neutron/ML2/MechCiscoNexus ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][cisco] Cisco Nexus requires patched ncclient
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/08/14 17:12, Henry Gessau wrote: On 8/12/2014 10:27 AM, Ihar Hrachyshka wrote: as per [1], Cisco Nexus ML2 plugin requires a patched version of ncclient from github. I wonder: - - whether this information is still current; Please see: https://review.openstack.org/112175 But we need to do backports before updating the wiki. Thanks for the link! - - why don't we depend on ncclient thru our requirements.txt file. Do we want to have requirements on things that are only used by a specific vendor plugin? So far it has worked by vendor-specific documentation instructing to manually install the requirement, or vendor-tailored deployment tools/scripts. In downstream, it's hard to maintain all plugin dependencies if they are not explicitly mentioned in e.g. requirements.txt. Red Hat ships those plugins (with no commercial support or testing done on our side), and we didn't know that to make the plugin actually useable, we need to install that ncclient module until a person from Cisco reported the issue to us. We don't usually monitor random wiki pages to get an idea what we need to package and depend on. :) I think we should have every third party module that we directly use in requirements.txt. We have code in the tree that imports ncclient (btw is it unit tested?), so I think it's enough to make that dependency explicit. Now, maybe putting the module into requirements.txt is an overkill (though I doubt it). In that case, we could be interested in getting the info in some other centralized way. /Ihar -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBCgAGBQJT6lSAAAoJEC5aWaUY1u57rk8IAKWBqBAJ+DChAkcU/hzs70o5 dqTKm1y5dtLpebSckjLuTb568nd1ShghCaqEQbck4U01g6aDg1hWyWzm2wF2FUyG PtkYHZRSnKlqyAN7J2PU/Ak7uvTr51UfVKFzqc1hfLujY+SGSlzIjKeucXgjatts TYIq53xz69y9+9GE/XxX0NpD1ROeaOwaj884WFUI5sIwKWvTjur929o58grym1Hb bncQUc3wSY1Mtp6OdvwxZJ0MEmlC3t8ukykAUSkv1fBU6xSYo/nLmpGYeHn3o3GQ icNJXTZbJ/z3oAktbTol1DCxHkKKKruMBqCZcxmxniAdV+l1yNSkZUlAqYwuy3E= =nI7E -END PGP SIGNATURE- ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [neutron][cisco] Cisco Nexus requires patched ncclient
On 8/12/2014 1:53 PM, Ihar Hrachyshka wrote: On 12/08/14 17:12, Henry Gessau wrote: On 8/12/2014 10:27 AM, Ihar Hrachyshka wrote: as per [1], Cisco Nexus ML2 plugin requires a patched version of ncclient from github. I wonder: - - whether this information is still current; Please see: https://review.openstack.org/112175 But we need to do backports before updating the wiki. Thanks for the link! - - why don't we depend on ncclient thru our requirements.txt file. Do we want to have requirements on things that are only used by a specific vendor plugin? So far it has worked by vendor-specific documentation instructing to manually install the requirement, or vendor-tailored deployment tools/scripts. In downstream, it's hard to maintain all plugin dependencies if they are not explicitly mentioned in e.g. requirements.txt. Red Hat ships those plugins (with no commercial support or testing done on our side), and we didn't know that to make the plugin actually useable, we need to install that ncclient module until a person from Cisco reported the issue to us. We don't usually monitor random wiki pages to get an idea what we need to package and depend on. :) I think we should have every third party module that we directly use in requirements.txt. We have code in the tree that imports ncclient (btw is it unit tested?), so I think it's enough to make that The unit tests mock the import of ncclient. dependency explicit. Now, maybe putting the module into requirements.txt is an overkill (though I doubt it). In that case, we could be interested in getting the info in some other centralized way. I am not familiar with other ways, but let me know if I can be of any help. Note: it seems that the Brocade plugin also imports ncclient. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
