Re: [openstack-dev] [nova][api]do we need to have a spec for all api related changes?

[Matt Riedemann]

On 1/7/2015 11:16 AM, Joe Gordon wrote:



On Tue, Jan 6, 2015 at 7:43 PM, Eli Qiao mailto:ta...@linux.vnet.ibm.com>> wrote:

hi all:
I have a patch [1], just did slight changes on api, do I need to
write a spec(kinds of wasting time to get approved)?
since api-microversion[2] is almost done, can we just feel free to
add changes as micro-version api?
like bump version , write down changes in rest_api_version_history.rst


We should always be careful about making API changes, so all API changes
need a spec.

http://docs.openstack.org/developer/nova/devref/kilo.blueprints.html#kilo

[1] https://review.openstack.org/#/c/144914/
[2]

https://review.openstack.org/#/q/status:merged+project:openstack/nova+branch:master+topic:bp/api-microversions,n,z

--
Thanks,
Eli (Li Yong) Qiao


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



Yeah, here is another example [1].

[1] https://review.openstack.org/#/c/125471/

--

Thanks,

Matt Riedemann


___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova][api]do we need to have a spec for all api related changes?

[Joe Gordon]

On Tue, Jan 6, 2015 at 7:43 PM, Eli Qiao  wrote:

>  hi all:
> I have a patch [1], just did slight changes on api, do I need to write a
> spec(kinds of wasting time to get approved)?
> since api-microversion[2] is almost done, can we just feel free to add
> changes as micro-version api?
> like bump version , write down changes in rest_api_version_history.rst
>
>
We should always be careful about making API changes, so all API changes
need a spec.

http://docs.openstack.org/developer/nova/devref/kilo.blueprints.html#kilo


> [1] https://review.openstack.org/#/c/144914/
> [2]
> https://review.openstack.org/#/q/status:merged+project:openstack/nova+branch:master+topic:bp/api-microversions,n,z
>
> --
> Thanks,
> Eli (Li Yong) Qiao
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova][api]do we need to have a spec for all api related changes?

[Alex Xu]

2015-01-07 11:43 GMT+08:00 Eli Qiao :

>  hi all:
> I have a patch [1], just did slight changes on api, do I need to write a
> spec(kinds of wasting time to get approved)?
> since api-microversion[2] is almost done, can we just feel free to add
> changes as micro-version api?
>

We definitely can't 'feel free' to change API even we have micro-version,
special for back-incompatibility change. The spec is for avoid we break the
API accidentally.



> like bump version , write down changes in rest_api_version_history.rst
>
> [1] https://review.openstack.org/#/c/144914/
> [2]
> https://review.openstack.org/#/q/status:merged+project:openstack/nova+branch:master+topic:bp/api-microversions,n,z
>
> --
> Thanks,
> Eli (Li Yong) Qiao
>
>
> ___
> OpenStack-dev mailing list
> OpenStack-dev@lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
___
OpenStack-dev mailing list
OpenStack-dev@lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev