Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-31 Thread Artom Lifshitz
The more urgent stuff has indeed merged - many thanks to Matt and other cores for getting this in quickly before rc1. The fixes to tests do indeed need more attention, which I will provide :) On Mon, Jan 30, 2017 at 8:49 PM, Matt Riedemann wrote: > On 1/26/2017 8:32 PM,

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-30 Thread Matt Riedemann
On 1/26/2017 8:32 PM, Artom Lifshitz wrote: Since the consensus is to fix this with a new microversion, I've submitted some patches: * https://review.openstack.org/#/c/426030/ A spec for the new microversion in case folks want one. Merged. * https://review.openstack.org/#/c/424759/ The

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-26 Thread Artom Lifshitz
Since the consensus is to fix this with a new microversion, I've submitted some patches: * https://review.openstack.org/#/c/426030/ A spec for the new microversion in case folks want one. * https://review.openstack.org/#/c/424759/ The new microversion itself. I've already had feedback from

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-24 Thread Matt Riedemann
On 1/24/2017 8:16 PM, Alex Xu wrote: One other thing: we're going to need to also fix this in python-novaclient, which we might want to do first, or work concurrently, since that's going to give us the client side perspective on how gross it will be to deal with this issue.

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-24 Thread Alex Xu
2017-01-25 0:27 GMT+08:00 Matt Riedemann : > On 1/24/2017 9:18 AM, Matt Riedemann wrote: > >> >> First, thanks to Kevin and Alex for finding this issue and explaining it >> in detail so we can understand the scope. >> >> This is a nasty unfortunate issue which I really wish

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-24 Thread Zhenyu Zheng
Thanks Alex for raising this up widely, as Chinese holiday is comming and Alex and me might be away for a week, And it will be better to fix this faster, so thanks Artom taking over to fix it :) On Wed, Jan 25, 2017 at 7:50 AM, Ghanshyam Mann wrote: > > On Wed, Jan 25,

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-24 Thread Ghanshyam Mann
On Wed, Jan 25, 2017 at 1:18 AM, Matt Riedemann wrote: > On 1/24/2017 2:05 AM, Alex Xu wrote: > >> Unfortunately the device tag support in the API was broken in the old >> Microversion https://bugs.launchpad.net/nova/+bug/1658571, which thanks >> to Kevin Zheng to find out

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-24 Thread Matt Riedemann
On 1/24/2017 9:18 AM, Matt Riedemann wrote: First, thanks to Kevin and Alex for finding this issue and explaining it in detail so we can understand the scope. This is a nasty unfortunate issue which I really wish we could just fix without a microversion bump but we have microversions for a

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-24 Thread Matt Riedemann
On 1/24/2017 2:05 AM, Alex Xu wrote: Unfortunately the device tag support in the API was broken in the old Microversion https://bugs.launchpad.net/nova/+bug/1658571, which thanks to Kevin Zheng to find out that. Actually there are two bugs, just all of them are about device tag. The first one

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-24 Thread Matt Riedemann
On 1/24/2017 3:34 AM, Ghanshyam Mann wrote: But from looking at api-ref and db, i am little bit confused. API-ref says device tag as "An arbitrary tag." [6] and DB also have it as Column(String(255)) [7] But our tag validation we mistakenly removed is more strict actually as per [8] which

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-24 Thread Artom Lifshitz
> So the current API behavior is as below: > > 2.32: BDM tag and network device tag added. > 2.33 - 2.36: 'tag' in the BDM disappeared. The network device tag still > works. > 2.37: The network device tag disappeared also. Thanks for the summary. For the visual minded like me, I made some ASCII

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-24 Thread Ghanshyam Mann
Sorry, forgot to mention tempest patch - https://review.openstack.org/#/c/424572/1 (but broken cases seems clear without that patch also) Regards Ghanshyam Mann +818011120698 On Tue, Jan 24, 2017 at 7:34 PM, Ghanshyam Mann wrote: > Thanks Alex for writing in details. >

Re: [openstack-dev] [nova] Device tag in the API breaks in the old microversion

2017-01-24 Thread Ghanshyam Mann
Thanks Alex for writing in details. On Tue, Jan 24, 2017 at 6:05 PM, Alex Xu wrote: > Unfortunately the device tag support in the API was broken in the old > Microversion https://bugs.launchpad.net/nova/+bug/1658571, which thanks > to Kevin Zheng to find out that. > >