Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-29 Thread Sean M. Collins
On Mon, Jul 20, 2015 at 10:19:02AM EDT, Jim Rollenhagen wrote: On Mon, Jul 20, 2015 at 12:56:10PM +, Sean M. Collins wrote: On Sun, Jul 19, 2015 at 02:26:32PM EDT, Jim Rollenhagen wrote: For a little background, this patch came from code that is running in production today, where

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-23 Thread Jim Rollenhagen
On Thu, Jul 16, 2015 at 04:23:29PM -0400, Mathieu Gagné wrote: Hi, I stubble on this review [1] which proposes adding info about provider networks in network_data.json. snip [1] https://review.openstack.org/#/c/152703/5 Just to loop back on this - we talked about it a bit at the Nova

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-20 Thread Sean M. Collins
On Sun, Jul 19, 2015 at 02:26:32PM EDT, Jim Rollenhagen wrote: For a little background, this patch came from code that is running in production today, where we're trunking two VLANs down to the host -- it isn't a theoretical use case. Have you taken a look at the vlan transparent API

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-20 Thread Jim Rollenhagen
On Mon, Jul 20, 2015 at 12:56:10PM +, Sean M. Collins wrote: On Sun, Jul 19, 2015 at 02:26:32PM EDT, Jim Rollenhagen wrote: For a little background, this patch came from code that is running in production today, where we're trunking two VLANs down to the host -- it isn't a theoretical

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-20 Thread Clint Byrum
Excerpts from Sam Stoelinga's message of 2015-07-18 05:39:23 -0700: +1 on Kevin Benton's comments. Ironic should have integration with switches where the switches are SDN compatible. The individual bare metal node should not care which vlan, vxlan or other translation is programmed at the

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-20 Thread Devananda van der Veen
On Sat, Jul 18, 2015 at 5:42 AM Sam Stoelinga sammiest...@gmail.com wrote: +1 on Kevin Benton's comments. Ironic should have integration with switches where the switches are SDN compatible. The individual bare metal node should not care which vlan, vxlan or other translation is programmed at

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-20 Thread Kevin Benton
Having Nova make assumptions isn't the right way to do this though. To support this I would rather see an ML2 driver that informs Nova to pass tagging info to the instance via the port binding info. Only neutron knows which one is appropriate based on the network configuration. On Jul 20, 2015

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-19 Thread Jim Rollenhagen
On Sat, Jul 18, 2015 at 08:39:23PM +0800, Sam Stoelinga wrote: +1 on Kevin Benton's comments. Ironic should have integration with switches where the switches are SDN compatible. The individual bare metal node should not care which vlan, vxlan or other translation is programmed at the switch.

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-18 Thread Sam Stoelinga
+1 on Kevin Benton's comments. Ironic should have integration with switches where the switches are SDN compatible. The individual bare metal node should not care which vlan, vxlan or other translation is programmed at the switch. The individual bare metal nodes just knows I have 2 nics and and

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-17 Thread John Garbutt
On 17 July 2015 at 11:23, Sean Dague s...@dague.net wrote: On 07/16/2015 06:06 PM, Sean M. Collins wrote: On Thu, Jul 16, 2015 at 01:23:29PM PDT, Mathieu Gagné wrote: So it looks like there is a missing part in this feature. There should be a way to hide this information if the instance does

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-17 Thread Jim Rollenhagen
On Fri, Jul 17, 2015 at 01:06:46PM +0100, John Garbutt wrote: On 17 July 2015 at 11:23, Sean Dague s...@dague.net wrote: On 07/16/2015 06:06 PM, Sean M. Collins wrote: On Thu, Jul 16, 2015 at 01:23:29PM PDT, Mathieu Gagné wrote: So it looks like there is a missing part in this feature.

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-17 Thread Sean Dague
On 07/16/2015 06:06 PM, Sean M. Collins wrote: On Thu, Jul 16, 2015 at 01:23:29PM PDT, Mathieu Gagné wrote: So it looks like there is a missing part in this feature. There should be a way to hide this information if the instance does not require to configure vlan interfaces to make network

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-17 Thread Kevin Benton
Check out my comments on the review. Only Neutron knows whether or not an instance needs to do manual tagging based on the plugin/driver loaded. For example, Ironic/bare metal ports can be bound by neutron with a correct driver so they shouldn't get the VLAN information at the instance level in

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-17 Thread Jim Rollenhagen
On Fri, Jul 17, 2015 at 10:56:36AM -0600, Kevin Benton wrote: Check out my comments on the review. Only Neutron knows whether or not an instance needs to do manual tagging based on the plugin/driver loaded. For example, Ironic/bare metal ports can be bound by neutron with a correct driver so

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-17 Thread Jim Rollenhagen
On Fri, Jul 17, 2015 at 10:43:37AM -0700, Jim Rollenhagen wrote: On Fri, Jul 17, 2015 at 10:56:36AM -0600, Kevin Benton wrote: Check out my comments on the review. Only Neutron knows whether or not an instance needs to do manual tagging based on the plugin/driver loaded. For example,

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-17 Thread Kevin Benton
which requires VLAN info to be pushed to the host. I keep hearing bare metal will never need to know about VLANs so I want to quash that ASAP. That's leaking implementation details though if the bare metal host only needs to be on one network. It also creates a security risk if the bare metal

Re: [openstack-dev] [nova] Exposing provider networks in network_data.json

2015-07-16 Thread Sean M. Collins
On Thu, Jul 16, 2015 at 01:23:29PM PDT, Mathieu Gagné wrote: So it looks like there is a missing part in this feature. There should be a way to hide this information if the instance does not require to configure vlan interfaces to make network functional. I just commented on the review, but