Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-22 Thread Murray, Paul (HP Cloud)
I spent a little time trying to work out a good way to include this kind of data in the ComputeNode object. You will have seen that I added the supported_instances reported to the RT by the virt drivers as a list of HVSpec – where HVSpec is a new nova object I created for the purpose. The

Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-22 Thread Jay Pipes
On 10/21/2014 05:44 AM, Nikola Đipanov wrote: On 10/20/2014 07:38 PM, Jay Pipes wrote: Hi Dan, Dan, Nikola, all Nova devs, OK, so in reviewing Dan B's patch series that refactors the virt driver's get_available_resource() method [1], I am stuck between two concerns. I like (love even) much of

Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-22 Thread Jay Pipes
On 10/21/2014 04:51 PM, Dan Smith wrote: The rationale behind two parallel data model hiercharies is that the format the virt drivers report data in, is not likely to be exactly the same as the format that the resoure tracker / scheduler wishes to use in the database. Yeah, and in cases where

Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-21 Thread Sylvain Bauza
Le 20 oct. 2014 20:13, Dan Smith d...@danplanet.com a écrit : OK, so in reviewing Dan B's patch series that refactors the virt driver's get_available_resource() method [1], I am stuck between two concerns. I like (love even) much of the refactoring work involved in Dan's patches. They

Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-21 Thread Nikola Đipanov
On 10/20/2014 07:38 PM, Jay Pipes wrote: Hi Dan, Dan, Nikola, all Nova devs, OK, so in reviewing Dan B's patch series that refactors the virt driver's get_available_resource() method [1], I am stuck between two concerns. I like (love even) much of the refactoring work involved in Dan's

Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-21 Thread Dan Smith
As there are multiple interfaces using non versioned dicts and as we are looking at reducing technical debt by Kilo, there are different blueprints which can be worked in parallel. I don't think I disagree with anything above, but I'm not sure what you're getting at. I think the parallelism we

Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-21 Thread Daniel P. Berrange
On Mon, Oct 20, 2014 at 01:38:46PM -0400, Jay Pipes wrote: Hi Dan, Dan, Nikola, all Nova devs, OK, so in reviewing Dan B's patch series that refactors the virt driver's get_available_resource() method [1], I am stuck between two concerns. I like (love even) much of the refactoring work

Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-21 Thread Daniel P. Berrange
On Mon, Oct 20, 2014 at 11:12:57AM -0700, Dan Smith wrote: OK, so in reviewing Dan B's patch series that refactors the virt driver's get_available_resource() method [1], I am stuck between two concerns. I like (love even) much of the refactoring work involved in Dan's patches. They replace

Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-21 Thread Daniel P. Berrange
On Tue, Oct 21, 2014 at 08:46:10AM -0700, Dan Smith wrote: As there are multiple interfaces using non versioned dicts and as we are looking at reducing technical debt by Kilo, there are different blueprints which can be worked in parallel. I don't think I disagree with anything above, but

Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-21 Thread Dan Smith
The rationale behind two parallel data model hiercharies is that the format the virt drivers report data in, is not likely to be exactly the same as the format that the resoure tracker / scheduler wishes to use in the database. Yeah, and in cases where we know where that line is, it makes

Re: [openstack-dev] [nova] Pulling nova/virt/hardware.py into nova/objects/

2014-10-20 Thread Dan Smith
OK, so in reviewing Dan B's patch series that refactors the virt driver's get_available_resource() method [1], I am stuck between two concerns. I like (love even) much of the refactoring work involved in Dan's patches. They replace a whole bunch of our nested dicts that are used in the