Re: [openstack-dev] [nova] Should be instance_dir in all nova compute node same ?

[Murray, Paul (HP Cloud)]

The instance path is assumed to be the same everywhere. When using libvirt to 
do cold migration/resize the source host creates the instance directory on the 
target host using ssh and then copies the files to it using scp. So the target 
host doesn’t even get to determine where its own files are created. (note: this 
is one of the security flaws we intend to remove in the libvirt storage pools 
work).


From: Michael Still [mailto:mi...@stillhq.com]
Sent: 04 May 2016 06:16
To: OpenStack Development Mailing List (not for usage questions) 
<openstack-dev@lists.openstack.org>
Subject: Re: [openstack-dev] [nova] Should be instance_dir in all nova compute 
node same ?

I can't think of a reason. In fact its a bit warty because we've changed the 
way we name the instance directories at least once. Its just how this code was 
written back in the day.

Cleaning this up would be a fair bit of work though. Is it really worth the 
effort just so people can have different directory names for some undefined 
reason?

Michael



On Wed, May 4, 2016 at 9:03 AM, Ghe Rivero 
<ghe.riv...@gmail.com<mailto:ghe.riv...@gmail.com>> wrote:
Is there any specific reason why this is require that way? or just a "feature"?

Ghe Rivero

On 03/05/16 11:42, Matthew Booth wrote:
On Fri, Apr 29, 2016 at 2:47 AM, Eli Qiao 
<liyong.q...@intel.com<mailto:liyong.q...@intel.com>> wrote:
hi team,

Is there any require that all compute node's instance_dir should be same?

Yes. This is assumed in many places, certainly in cold migration/resize.

Matt
--
Matthew Booth
Red Hat Engineering, Virtualisation Team

Phone: +442070094448<tel:%2B442070094448> (UK)



__

OpenStack Development Mailing List (not for usage questions)

Unsubscribe: 
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe<mailto:openstack-dev-requ...@lists.openstack.org?subject:unsubscribe>

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe<http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



--
Rackspace Australia
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] Should be instance_dir in all nova compute node same ?

[Michael Still]

I can't think of a reason. In fact its a bit warty because we've changed
the way we name the instance directories at least once. Its just how this
code was written back in the day.

Cleaning this up would be a fair bit of work though. Is it really worth the
effort just so people can have different directory names for some undefined
reason?

Michael



On Wed, May 4, 2016 at 9:03 AM, Ghe Rivero  wrote:

> Is there any specific reason why this is require that way? or just a
> "feature"?
>
> Ghe Rivero
>
>
> On 03/05/16 11:42, Matthew Booth wrote:
>
> On Fri, Apr 29, 2016 at 2:47 AM, Eli Qiao  wrote:
>
>> hi team,
>>
>> Is there any require that all compute node's instance_dir should be same?
>>
>
> Yes. This is assumed in many places, certainly in cold migration/resize.
>
> Matt
> --
> Matthew Booth
> Red Hat Engineering, Virtualisation Team
>
> Phone: +442070094448 (UK)
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: 
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribehttp://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>


-- 
Rackspace Australia
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] Should be instance_dir in all nova compute node same ?

[Ghe Rivero]

Is there any specific reason why this is require that way? or just a 
"feature"?


Ghe Rivero

On 03/05/16 11:42, Matthew Booth wrote:
On Fri, Apr 29, 2016 at 2:47 AM, Eli Qiao > wrote:


hi team,

Is there any require that all compute node's instance_dir should
be same?


Yes. This is assumed in many places, certainly in cold migration/resize.

Matt
--
Matthew Booth
Red Hat Engineering, Virtualisation Team

Phone: +442070094448 (UK)



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] Should be instance_dir in all nova compute node same ?

[taget]

Thanks Matt

That really surprised me.

On 2016年05月03日 17:42, Matthew Booth wrote:
On Fri, Apr 29, 2016 at 2:47 AM, Eli Qiao > wrote:


hi team,

Is there any require that all compute node's instance_dir should
be same?


Yes. This is assumed in many places, certainly in cold migration/resize.

Matt


--
Best Regards, Eli Qiao (乔立勇)

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] Should be instance_dir in all nova compute node same ?

[Matthew Booth]

On Fri, Apr 29, 2016 at 2:47 AM, Eli Qiao  wrote:

> hi team,
>
> Is there any require that all compute node's instance_dir should be same?
>

Yes. This is assumed in many places, certainly in cold migration/resize.

Matt
-- 
Matthew Booth
Red Hat Engineering, Virtualisation Team

Phone: +442070094448 (UK)
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] Should be instance_dir in all nova compute node same ?

[taget]

hi Timofei

I don't have any specific use case, this issue is found while I am doing 
live migration testing, what I did is:


1. create 2 compute node,
2. create a nfs service on one of compute node, let's say node-2 and 
expose /opt/stack/date/nova/instances

3. mount node-2:/opt/stack/date/nova/instances to node-1 's /mnt
4. specify /mnt as node-1's instance_dir so node-1 and node-2 have 
shared instance_dir(with different path)

5. live migration an instance and fail.


Thanks
Eli.

On 2016年04月29日 19:52, Timofei Durakov wrote:

Hi,

From the first sight there are no restrictions for instance_path 
option. Could you please provide some details about the use case?
I wonder would this functionality be really useful for 
cloud-operators, or we just should add description to instance path 
option, forcing to use the same path on compute nodes?


Timofey



On Fri, Apr 29, 2016 at 4:47 AM, Eli Qiao > wrote:


hi team,

Is there any require that all compute node's instance_dir should
be same?

I recently get an issue while doing live migration with
migrateToURI3 method of libvirt python interface, if
source and dest host are configured with difference instance_dir,
migration will fail since migrateToURI3
requires a new xml, but we don't modified the instance_dir of dest
xml.

I reported a bug on [1]_ , would like to get confirmation before
spend effort working on it.

[1] https://bugs.launchpad.net/nova/+bug/1576245

Thanks.

-- 


Best Regards, Eli Qiao (乔立勇)
Intel OTC China


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe:
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe

http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


--
Best Regards, Eli Qiao (乔立勇)

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [nova] Should be instance_dir in all nova compute node same ?

[Timofei Durakov]

Hi,

>From the first sight there are no restrictions for instance_path option.
Could you please provide some details about the use case?
I wonder would this functionality be really useful for cloud-operators, or
we just should add description to instance path option, forcing to use the
same path on compute nodes?

Timofey



On Fri, Apr 29, 2016 at 4:47 AM, Eli Qiao  wrote:

> hi team,
>
> Is there any require that all compute node's instance_dir should be same?
>
> I recently get an issue while doing live migration with migrateToURI3
> method of libvirt python interface, if
> source and dest host are configured with difference instance_dir,
> migration will fail since migrateToURI3
> requires a new xml, but we don't modified the instance_dir of dest xml.
>
> I reported a bug on [1]_ , would like to get confirmation before spend
> effort working on it.
>
> [1] https://bugs.launchpad.net/nova/+bug/1576245
>
> Thanks.
>
> --
>
> Best Regards, Eli Qiao (乔立勇)
> Intel OTC China
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev