Re: [openstack-dev] [nova] nova-manage cell_v2 map_instances uses invalid UUID as marker in the db

2018-05-14 Thread Balázs Gibizer
On Mon, May 14, 2018 at 11:49 AM, Balázs Gibizer wrote: On Thu, May 10, 2018 at 8:48 PM, Dan Smith wrote: Personally, I'd just make the offending tests shut up about the warning and move on, but I'm also okay with the above solution if

Re: [openstack-dev] [nova] nova-manage cell_v2 map_instances uses invalid UUID as marker in the db

2018-05-14 Thread Balázs Gibizer
On Thu, May 10, 2018 at 8:48 PM, Dan Smith wrote: The oslo UUIDField emits a warning if the string used as a field value does not pass the validation of the uuid.UUID(str(value)) call [3]. All the offending places are fixed in nova except the nova-manage cell_v2

Re: [openstack-dev] [nova] nova-manage cell_v2 map_instances uses invalid UUID as marker in the db

2018-05-10 Thread melanie witt
On Thu, 10 May 2018 11:48:31 -0700, Dan Smith wrote: We already store values in this field that are not 8-4-4-4-12, and the oslo field warning is just a warning. If people feel like we need to do something, I propose we just do this: https://review.openstack.org/#/c/567669/ It is one of those

Re: [openstack-dev] [nova] nova-manage cell_v2 map_instances uses invalid UUID as marker in the db

2018-05-10 Thread Dan Smith
> Takashi Natsume writes: > >> In some compute REST APIs, it returns the 'marker' parameter >> in their pagination. >> Then users can specify the 'marker' parameter in the next request. I read this as you saying there was some way that the in-band marker mapping

Re: [openstack-dev] [nova] nova-manage cell_v2 map_instances uses invalid UUID as marker in the db

2018-05-10 Thread Dan Smith
Takashi Natsume writes: > In some compute REST APIs, it returns the 'marker' parameter > in their pagination. > Then users can specify the 'marker' parameter in the next request. How is this possible? The only way we would get the marker is if we either (a) listed

Re: [openstack-dev] [nova] nova-manage cell_v2 map_instances uses invalid UUID as marker in the db

2018-05-10 Thread Dan Smith
> The oslo UUIDField emits a warning if the string used as a field value > does not pass the validation of the uuid.UUID(str(value)) call > [3]. All the offending places are fixed in nova except the nova-manage > cell_v2 map_instances call [1][2]. That call uses markers in the DB > that are not

Re: [openstack-dev] [nova] nova-manage cell_v2 map_instances uses invalid UUID as marker in the db

2018-05-10 Thread Ed Leafe
On May 10, 2018, at 12:50 AM, Takashi Natsume wrote: > > So it is one way to change the command to stop storing a 'marker' value > in the InstanceMapping (instance_mappings) DB table > and return (print) a 'marker' value and be able to be specifid > the 'marker'

Re: [openstack-dev] [nova] nova-manage cell_v2 map_instances uses invalid UUID as marker in the db

2018-05-10 Thread Stephen Finucane
On Tue, 2018-05-08 at 11:49 +0200, Balázs Gibizer wrote: > Hi, > > The oslo UUIDField emits a warning if the string used as a field value > does not pass the validation of the uuid.UUID(str(value)) call [3]. All > the offending places are fixed in nova except the nova-manage cell_v2 >

Re: [openstack-dev] [nova] nova-manage cell_v2 map_instances uses invalid UUID as marker in the db

2018-05-09 Thread Takashi Natsume
The temporary fix to pass the gate jobs is to mock the 'warnings.warn' method in the test method. Then add a TODO note to fix storing non-UUID value in the 'map_instances' command of the 'CellV2Commands' class. The fundamental solution is to change the design of the 'map_instances' command. In