Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 03/03/2016 09:09 AM, Sam Matzek wrote: >> > So, don't deprecate until you have a solution. All you will be doing is >> > putting people in a tight spot where they will have to fork the code base, >> > and that is downright antisocial. >> > >> > Let's plan this out in the Newton Summit and

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Thu, Mar 03, 2016 at 09:09:03AM -0600, Sam Matzek wrote: > On Wed, Mar 2, 2016 at 8:25 PM, Adam Young wrote: > > On 02/29/2016 01:49 PM, Andrew Laski wrote: > >> > >> > >> On Mon, Feb 29, 2016, at 01:18 PM, Dan Smith wrote: > > Forgive my ignorance or for playing

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Wed, Mar 2, 2016 at 8:25 PM, Adam Young wrote: > On 02/29/2016 01:49 PM, Andrew Laski wrote: >> >> >> On Mon, Feb 29, 2016, at 01:18 PM, Dan Smith wrote: Forgive my ignorance or for playing devil's advocate, but wouldn't the main difference between

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 02/29/2016 01:49 PM, Andrew Laski wrote: On Mon, Feb 29, 2016, at 01:18 PM, Dan Smith wrote: Forgive my ignorance or for playing devil's advocate, but wouldn't the main difference between notifications and hooks be that notifications are asynchronous and hooks aren't? The main difference

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 03/02/2016 03:01 AM, Juan Antonio Osorio wrote: > > > On Tue, Mar 1, 2016 at 2:14 PM, Sean Dague > wrote: > > On 02/29/2016 05:23 PM, Matt Riedemann wrote: > > > > > > On 2/29/2016 2:54 PM, Sean Dague wrote: > >> On 02/29/2016

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Tue, Mar 01, 2016 at 01:53:18PM -0500, Rob Crittenden wrote: > Daniel P. Berrange wrote: > > On Mon, Feb 29, 2016 at 12:36:03PM -0700, Rich Megginson wrote: > >> On 02/29/2016 12:19 PM, Chris Friesen wrote: > >>> On 02/29/2016 12:22 PM, Daniel P. Berrange wrote: > >>> > There's three core

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Tue, Mar 1, 2016 at 2:14 PM, Sean Dague wrote: > On 02/29/2016 05:23 PM, Matt Riedemann wrote: > > > > > > On 2/29/2016 2:54 PM, Sean Dague wrote: > >> On 02/29/2016 11:59 AM, Sean Dague wrote: > >>> The nova/hooks.py infrastructure has been with us since early Nova. > It's >

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 03/01/2016 02:04 PM, Rob Crittenden wrote: > Daniel P. Berrange wrote: >> On Mon, Feb 29, 2016 at 11:59:06AM -0500, Sean Dague wrote: >>> The nova/hooks.py infrastructure has been with us since early Nova. It's >>> currently only annotated on a few locations - 'build_instance', >>>

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

Daniel P. Berrange wrote: > On Mon, Feb 29, 2016 at 11:59:06AM -0500, Sean Dague wrote: >> The nova/hooks.py infrastructure has been with us since early Nova. It's >> currently only annotated on a few locations - 'build_instance', >> 'create_instance', 'delete_instance', and

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

Daniel P. Berrange wrote: > On Mon, Feb 29, 2016 at 12:36:03PM -0700, Rich Megginson wrote: >> On 02/29/2016 12:19 PM, Chris Friesen wrote: >>> On 02/29/2016 12:22 PM, Daniel P. Berrange wrote: >>> There's three core scenarios for hooks 1. Modifying some aspect of the Nova

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

Sorry for the top posting, but seems like doing so is ok, So an idea, feel free to use it or not... But if a in-memory notification mechanism is desired then a library that I have been using and extracted from taskflow could be helpful here, It doesn't bring in the full oslo.messaging

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 02/29/2016 05:23 PM, Matt Riedemann wrote: > > > On 2/29/2016 2:54 PM, Sean Dague wrote: >> On 02/29/2016 11:59 AM, Sean Dague wrote: >>> The nova/hooks.py infrastructure has been with us since early Nova. It's >>> currently only annotated on a few locations - 'build_instance', >>>

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 29 February 2016 at 18:49, Andrew Laski wrote: > On Mon, Feb 29, 2016, at 01:18 PM, Dan Smith wrote: >> > Forgive my ignorance or for playing devil's advocate, but wouldn't the >> > main difference between notifications and hooks be that notifications >> > are asynchronous

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 1 March 2016 at 10:10, Daniel P. Berrange wrote: > On Mon, Feb 29, 2016 at 12:36:03PM -0700, Rich Megginson wrote: >> On 02/29/2016 12:19 PM, Chris Friesen wrote: >> >On 02/29/2016 12:22 PM, Daniel P. Berrange wrote: >> > >> >>There's three core scenarios for hooks >> >>

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Mon, Feb 29, 2016 at 12:36:03PM -0700, Rich Megginson wrote: > On 02/29/2016 12:19 PM, Chris Friesen wrote: > >On 02/29/2016 12:22 PM, Daniel P. Berrange wrote: > > > >>There's three core scenarios for hooks > >> > >> 1. Modifying some aspect of the Nova operation > >> 2. Triggering an

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Tue, Mar 1, 2016 at 12:23 AM, Matt Riedemann wrote: > > > On 2/29/2016 2:54 PM, Sean Dague wrote: > >> On 02/29/2016 11:59 AM, Sean Dague wrote: >> >>> The nova/hooks.py infrastructure has been with us since early Nova. It's >>> currently only annotated on a few

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 2/29/2016 2:54 PM, Sean Dague wrote: On 02/29/2016 11:59 AM, Sean Dague wrote: The nova/hooks.py infrastructure has been with us since early Nova. It's currently only annotated on a few locations - 'build_instance', 'create_instance', 'delete_instance', and 'instance_network_info'. It's

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 02/29/2016 11:59 AM, Sean Dague wrote: > The nova/hooks.py infrastructure has been with us since early Nova. It's > currently only annotated on a few locations - 'build_instance', > 'create_instance', 'delete_instance', and 'instance_network_info'. It's > got a couple of unit tests on it, but

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 02/29/2016 12:19 PM, Chris Friesen wrote: On 02/29/2016 12:22 PM, Daniel P. Berrange wrote: There's three core scenarios for hooks 1. Modifying some aspect of the Nova operation 2. Triggering an external action synchronously to some Nova operation 3. Triggering an external action

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 02/29/2016 12:22 PM, Daniel P. Berrange wrote: There's three core scenarios for hooks 1. Modifying some aspect of the Nova operation 2. Triggering an external action synchronously to some Nova operation 3. Triggering an external action asynchronously to some Nova operation The Rdo

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Mon, Feb 29, 2016, at 01:18 PM, Dan Smith wrote: > > Forgive my ignorance or for playing devil's advocate, but wouldn't the > > main difference between notifications and hooks be that notifications > > are asynchronous and hooks aren't? > > The main difference is that notifications are

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 02/29/2016 01:33 PM, Andrew Laski wrote: > > > On Mon, Feb 29, 2016, at 12:53 PM, Rob Crittenden wrote: >> Andrew Laski wrote: >>> >>> >>> On Mon, Feb 29, 2016, at 12:12 PM, Dan Smith wrote: > In our continued quest on being more explicit about plug points it feels > like we should

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Mon, Feb 29, 2016, at 12:53 PM, Rob Crittenden wrote: > Andrew Laski wrote: > > > > > > On Mon, Feb 29, 2016, at 12:12 PM, Dan Smith wrote: > >>> In our continued quest on being more explicit about plug points it feels > >>> like we should other document the interface (which means creating

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Mon, Feb 29, 2016 at 12:03:00PM -0600, Matt Riedemann wrote: > > > On 2/29/2016 11:23 AM, Andrew Laski wrote: > > > > > >On Mon, Feb 29, 2016, at 12:12 PM, Dan Smith wrote: > >>>In our continued quest on being more explicit about plug points it feels > >>>like we should other document the

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

> Forgive my ignorance or for playing devil's advocate, but wouldn't the > main difference between notifications and hooks be that notifications > are asynchronous and hooks aren't? The main difference is that notifications are external and intended to be stable (especially with the versioned

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On 2/29/2016 11:23 AM, Andrew Laski wrote: On Mon, Feb 29, 2016, at 12:12 PM, Dan Smith wrote: In our continued quest on being more explicit about plug points it feels like we should other document the interface (which means creating stability on the hook parameters) or we should deprecate

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

Andrew Laski wrote: > > > On Mon, Feb 29, 2016, at 12:12 PM, Dan Smith wrote: >>> In our continued quest on being more explicit about plug points it feels >>> like we should other document the interface (which means creating >>> stability on the hook parameters) or we should deprecate this

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Mon, Feb 29, 2016 at 12:23:09PM -0500, Andrew Laski wrote: > > > On Mon, Feb 29, 2016, at 12:12 PM, Dan Smith wrote: > > > In our continued quest on being more explicit about plug points it feels > > > like we should other document the interface (which means creating > > > stability on the

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Mon, Feb 29, 2016, at 12:12 PM, Dan Smith wrote: > > In our continued quest on being more explicit about plug points it feels > > like we should other document the interface (which means creating > > stability on the hook parameters) or we should deprecate this construct > > as part of a

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

On Mon, Feb 29, 2016 at 11:59:06AM -0500, Sean Dague wrote: > The nova/hooks.py infrastructure has been with us since early Nova. It's > currently only annotated on a few locations - 'build_instance', > 'create_instance', 'delete_instance', and 'instance_network_info'. It's > got a couple of unit

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

Well, I do feel that the hooks have been pretty painful (having tried to use them and having stumbled upon that bug). However, even as undocumented as they were, that seems to be the only way of doing actions in nova when instances are spawned or deleted, while also having some awareness of

Re: [openstack-dev] [nova] nova hooks - document & test or deprecate?

> In our continued quest on being more explicit about plug points it feels > like we should other document the interface (which means creating > stability on the hook parameters) or we should deprecate this construct > as part of a bygone era. > > I lean on deprecation because it feels like a