Re: [openstack-dev] [nova] novaclient functional test guidelines

2015-03-06 Thread Joe Gordon
First pass at trying to capture this thread into a README: https://review.openstack.org/162334 On Tue, Feb 24, 2015 at 2:07 PM, Joe Gordon joe.gord...@gmail.com wrote: On Tue, Feb 24, 2015 at 1:18 PM, melanie witt melwi...@gmail.com wrote: On Feb 24, 2015, at 9:47, Sean Dague s...@dague.net

Re: [openstack-dev] [nova] novaclient functional test guidelines

2015-02-24 Thread melanie witt
On Feb 24, 2015, at 9:47, Sean Dague s...@dague.net wrote: I'm happy if there are other theories about how we do these things, being the first functional test in the python-novaclient tree that creates and destroys real resources, there isn't an established pattern yet. But I think doing all

Re: [openstack-dev] [nova] novaclient functional test guidelines

2015-02-24 Thread Ed Leafe
On Feb 24, 2015, at 2:30 PM, Sean Dague s...@dague.net wrote: Right, I think to some degree novaclient is legacy code, and we should focus on specific regressions and bugs without doing to much code change. The future should be more focussed on openstacksdk and openstackclient. IMO,

Re: [openstack-dev] [nova] novaclient functional test guidelines

2015-02-24 Thread Sean Dague
On 02/24/2015 03:28 PM, Ed Leafe wrote: On Feb 24, 2015, at 1:49 PM, Sean Dague s...@dague.net wrote: IMHO the CLI should have an option to returned raw JSON back instead of pretty tabled results as well. Um... isn't that just the API calls? I'm not sure creating a 3rd functional surface

Re: [openstack-dev] [nova] novaclient functional test guidelines

2015-02-24 Thread Sean Dague
On 02/24/2015 01:47 PM, Joe Gordon wrote: On Tue, Feb 24, 2015 at 9:47 AM, Sean Dague s...@dague.net mailto:s...@dague.net wrote: Towards the end of merging the regression test for the nova volume-attach bug - https://review.openstack.org/#/c/157959/ there was a discussion

Re: [openstack-dev] [nova] novaclient functional test guidelines

2015-02-24 Thread Ed Leafe
On Feb 24, 2015, at 1:49 PM, Sean Dague s...@dague.net wrote: IMHO the CLI should have an option to returned raw JSON back instead of pretty tabled results as well. Um... isn't that just the API calls? I'm not sure creating a 3rd functional surface is really the answer here, because we

Re: [openstack-dev] [nova] novaclient functional test guidelines

2015-02-24 Thread Joe Gordon
On Tue, Feb 24, 2015 at 9:47 AM, Sean Dague s...@dague.net wrote: Towards the end of merging the regression test for the nova volume-attach bug - https://review.openstack.org/#/c/157959/ there was a discussion around what style the functional tests should take. Especially as that had a mix of

Re: [openstack-dev] [nova] novaclient functional test guidelines

2015-02-24 Thread Joe Gordon
On Tue, Feb 24, 2015 at 12:30 PM, Sean Dague s...@dague.net wrote: On 02/24/2015 03:28 PM, Ed Leafe wrote: On Feb 24, 2015, at 1:49 PM, Sean Dague s...@dague.net wrote: IMHO the CLI should have an option to returned raw JSON back instead of pretty tabled results as well. Um... isn't

Re: [openstack-dev] [nova] novaclient functional test guidelines

2015-02-24 Thread Joe Gordon
On Tue, Feb 24, 2015 at 1:18 PM, melanie witt melwi...@gmail.com wrote: On Feb 24, 2015, at 9:47, Sean Dague s...@dague.net wrote: I'm happy if there are other theories about how we do these things, being the first functional test in the python-novaclient tree that creates and destroys