Re: [openstack-dev] [osc] bug/design flaw: Clients not cached per region

2016-10-18 Thread Adrian Turjak
In response to Jamie's comment I've abandoned my patch in favor of this one: https://review.openstack.org/#/c/388232 It simply removes the ClientCache from the openstackclient code and replaces it with property(). On 18/10/16 17:10, Adrian Turjak wrote: > > On 18/10/16 15:52, Jamie Lennox

Re: [openstack-dev] [osc] bug/design flaw: Clients not cached per region

2016-10-17 Thread Adrian Turjak
On 18/10/16 15:52, Jamie Lennox wrote: > > A comment from the cheap seats, almost all clients are using a > keystoneauth1 session at this point and that's where your > authentication information is being cached. There is essentially no > cost to creating a client with an existing session as auth

Re: [openstack-dev] [osc] bug/design flaw: Clients not cached per region

2016-10-17 Thread Jamie Lennox
On 18 October 2016 at 12:09, Dean Troyer wrote: > On Mon, Oct 17, 2016 at 5:29 PM, Adrian Turjak > wrote: > > What I'm wondering is can the current client cache be changed to be keyed > > off the client_manager.region_name? That way the change is only

Re: [openstack-dev] [osc] bug/design flaw: Clients not cached per region

2016-10-17 Thread Adrian Turjak
On 18/10/16 15:15, Adrian Turjak wrote: > Although option would be to leave the cache in osc-lib untouched as a > pure singleton and just make a new one for openstackclient that does > support regions. odd typo. "Although another option would be"

Re: [openstack-dev] [osc] bug/design flaw: Clients not cached per region

2016-10-17 Thread Adrian Turjak
On 18/10/16 14:09, Dean Troyer wrote: > On Mon, Oct 17, 2016 at 5:29 PM, Adrian Turjak > wrote: >> What I'm wondering is can the current client cache be changed to be keyed >> off the client_manager.region_name? That way the change is only in how the >> clients are

Re: [openstack-dev] [osc] bug/design flaw: Clients not cached per region

2016-10-17 Thread Dean Troyer
On Mon, Oct 17, 2016 at 5:29 PM, Adrian Turjak wrote: > What I'm wondering is can the current client cache be changed to be keyed > off the client_manager.region_name? That way the change is only in how the > clients are built and the code elsewhere doesn't change unless

Re: [openstack-dev] [osc] bug/design flaw: Clients not cached per region

2016-10-17 Thread Adrian Turjak
On 18/10/16 03:36, Dean Troyer wrote: > On Sun, Oct 16, 2016 at 9:11 PM, Adrian Turjak > > wrote: > > The problem I'm running into is for some of our custom plugins we > require the commands to run in all regions. We do this by

Re: [openstack-dev] [osc] bug/design flaw: Clients not cached per region

2016-10-17 Thread Dean Troyer
On Sun, Oct 16, 2016 at 9:11 PM, Adrian Turjak wrote: > The problem I'm running into is for some of our custom plugins we > require the commands to run in all regions. We do this by getting the > region list from keystone, and then doing the command in each region. > ...