Re: [openstack-dev] [qa] Lack of consistency in returning response from tempest clients

2014-08-31 Thread Yair Fried
Sent: Saturday, August 30, 2014 2:53:37 PM Subject: Re: [openstack-dev] [qa] Lack of consistency in returning response from tempest clients Sean, class ResponseBody(dict): def __init__(self, body={}, resp=None): self.update(body) self.resp = resp Are you sure that you would like

Re: [openstack-dev] [qa] Lack of consistency in returning response from tempest clients

2014-08-30 Thread Andrea Frittoli
+1 keeping the body as a ~dict will help with all existing asserts comparing dicts in tests. Andrea On 30 Aug 2014 06:45, Christopher Yeoh cbky...@gmail.com wrote: On Fri, 29 Aug 2014 11:13:39 -0400 David Kranz dkr...@redhat.com wrote: On 08/29/2014 10:56 AM, Sean Dague wrote: On

Re: [openstack-dev] [qa] Lack of consistency in returning response from tempest clients

2014-08-30 Thread GHANSHYAM MANN
+1. That will also help full for API coming up with microversion like Nova. On Fri, Aug 29, 2014 at 11:56 PM, Sean Dague s...@dague.net wrote: On 08/29/2014 10:19 AM, David Kranz wrote: While reviewing patches for moving response checking to the clients, I noticed that there are places

Re: [openstack-dev] [qa] Lack of consistency in returning response from tempest clients

2014-08-30 Thread Boris Pavlovic
Sean, class ResponseBody(dict): def __init__(self, body={}, resp=None): self.update(body) self.resp = resp Are you sure that you would like to have default value {} for method argument and not something like: class ResponseBody(dict): def __init__(self, body=None,

Re: [openstack-dev] [qa] Lack of consistency in returning response from tempest clients

2014-08-29 Thread Jay Pipes
On 08/29/2014 10:19 AM, David Kranz wrote: While reviewing patches for moving response checking to the clients, I noticed that there are places where client methods do not return any value. This is usually, but not always, a delete method. IMO, every rest client method should return at least the

Re: [openstack-dev] [qa] Lack of consistency in returning response from tempest clients

2014-08-29 Thread Sean Dague
On 08/29/2014 10:19 AM, David Kranz wrote: While reviewing patches for moving response checking to the clients, I noticed that there are places where client methods do not return any value. This is usually, but not always, a delete method. IMO, every rest client method should return at least

Re: [openstack-dev] [qa] Lack of consistency in returning response from tempest clients

2014-08-29 Thread David Kranz
On 08/29/2014 10:56 AM, Sean Dague wrote: On 08/29/2014 10:19 AM, David Kranz wrote: While reviewing patches for moving response checking to the clients, I noticed that there are places where client methods do not return any value. This is usually, but not always, a delete method. IMO, every

Re: [openstack-dev] [qa] Lack of consistency in returning response from tempest clients

2014-08-29 Thread Miguel Lavalle
Yeah, Sean's proposal looks great to me On Fri, Aug 29, 2014 at 10:13 AM, David Kranz dkr...@redhat.com wrote: On 08/29/2014 10:56 AM, Sean Dague wrote: On 08/29/2014 10:19 AM, David Kranz wrote: While reviewing patches for moving response checking to the clients, I noticed that there

Re: [openstack-dev] [qa] Lack of consistency in returning response from tempest clients

2014-08-29 Thread Christopher Yeoh
On Fri, 29 Aug 2014 11:13:39 -0400 David Kranz dkr...@redhat.com wrote: On 08/29/2014 10:56 AM, Sean Dague wrote: On 08/29/2014 10:19 AM, David Kranz wrote: While reviewing patches for moving response checking to the clients, I noticed that there are places where client methods do not