Excerpts from David Kranz's message of 2013-11-11 09:58:59 -0800:
I have seen a wide variety of -1'ing (and in many cases approving)
patches for minor spelling or grammatical errors and think we need a
policy about this. Given the large number of contributors for whom
English is not their
As long as the -1's include a correction that can be copied
and pasted, I think they're OK.
I know I would be grateful if someone were to
proofread my work, if I had to document in a second-language.
--
Sean M. Collins
___
OpenStack-dev mailing list
I am in favor/favour of the -1 with suggestions on what to change. The
more input we can provide on a review the better.
Thanks
Gary
On 11/11/13 8:21 PM, Collins, Sean (Contractor)
sean_colli...@cable.comcast.com wrote:
As long as the -1's include a correction that can be copied
and pasted, I
On 2013-11-11 12:19, Clint Byrum wrote:
Excerpts from David Kranz's message of 2013-11-11 09:58:59 -0800:
I have seen a wide variety of -1'ing (and in many cases approving)
patches for minor spelling or grammatical errors and think we need a
policy about this. Given the large number of
On 2013-11-11 12:21, Collins, Sean (Contractor) wrote:
As long as the -1's include a correction that can be copied
and pasted, I think they're OK.
I know I would be grateful if someone were to
proofread my work, if I had to document in a second-language.
+1 to this as well. I figure that as
-1 from me as well.
When I first started with OpenStack, I probably would have agreed with
letting small grammar mistakes and typos slide by.
However, I now feel that getting commit messages right is more
important. Also keep in mind that with small grammar mistakes, the
intent may be obvious
From: Clint Byrum cl...@fewbar.com
To: openstack-dev openstack-dev@lists.openstack.org,
Date: 11/11/2013 12:21 PM
Subject:Re: [openstack-dev] [qa] Policy on spelling and grammar
Excerpts from David Kranz's message of 2013-11-11 09:58:59 -0800
On Tue, Nov 12, 2013 at 2:49 AM, James Slagle james.sla...@gmail.com wrote:
-1 from me as well.
When I first started with OpenStack, I probably would have agreed with
letting small grammar mistakes and typos slide by.
However, I now feel that getting commit messages right is more
important.
: [openstack-dev] [qa] Policy on spelling and grammar
On Tue, Nov 12, 2013 at 2:49 AM, James Slagle james.sla...@gmail.com wrote:
-1 from me as well.
When I first started with OpenStack, I probably would have agreed with
letting small grammar mistakes and typos slide by.
However, I now
On Mon, Nov 11, 2013 at 12:19 PM, Clint Byrum cl...@fewbar.com wrote:
Excerpts from David Kranz's message of 2013-11-11 09:58:59 -0800:
I have seen a wide variety of -1'ing (and in many cases approving)
patches for minor spelling or grammatical errors and think we need a
policy about this.
On Tue, Nov 12, 2013 at 6:19 AM, Sean Dague s...@dague.net wrote:
On 11/11/2013 02:28 PM, Tim Bell wrote:
As a speaker of the Queen's English, I find flavor to be incorrect. Does
that mean I can -1 any patch that does not use flavour ?
At CERN, we are working with 130 countries in a
On Tue, Nov 12, 2013 at 6:24 AM, Ben Nemec openst...@nemebean.com wrote:
On 2013-11-11 13:28, Tim Bell wrote:
As a speaker of the Queen's English, I find flavor to be incorrect.
Does that mean I can -1 any patch that does not use flavour ?
At CERN, we are working with 130 countries in a
-Original Message-
From: John Griffith [mailto:john.griff...@solidfire.com]
Sent: 11 November 2013 20:03
To: OpenStack Development Mailing List (not for usage questions)
Subject: Re: [openstack-dev] [qa] Policy on spelling and grammar
On Tue, Nov 12, 2013 at 2:49 AM, James Slagle james.sla
Excerpts from Sean Dague's message of 2013-11-11 14:19:41 -0800:
On 11/11/2013 02:28 PM, Tim Bell wrote:
As a speaker of the Queen's English, I find flavor to be incorrect. Does
that mean I can -1 any patch that does not use flavour ?
At CERN, we are working with 130 countries in a
On Mon, Nov 11, 2013 at 11:02 AM, John Griffith john.griff...@solidfire.com
wrote:
Seems to me there's a middle ground here, but honestly if you're value
add to the review process is catching grammatical or spelling errors
in comments and commit messages I'd argue that in most cases it would
15 matches
Mail list logo
