Re: [openstack-dev] [third party][neutron] - OpenDaylight CI and -1 voting
On Mon, Sep 1, 2014 at 10:47 PM, Kevin Benton wrote: > Thank you YAMAMOTO. I didn't think to look at stackalytics. > > Kyle, can you list yourself on the wiki? I don't want to do it in case there > is someone else doing that job full time. > Also, is there a re-trigger phrase that you can document on the Wiki or in > the message body the CI posts to the reviews? > I'll add myself (and Dave Tucker, copied here) to the wiki for now. Please note the OpenDaylight CI is undergoing some major changes at the moment (it's being moved to the RAX cloud). Thanks, Kyle > Thanks, > Kevin Benton > > > On Mon, Sep 1, 2014 at 8:08 PM, YAMAMOTO Takashi > wrote: >> >> > I have had multiple occasions where the OpenDaylight CI will vote a -1 >> > on a >> > patch for something completely unrelated (e.g. [1]). This would be fine >> > except for two issues. First, there doesn't appear to be any way to >> > trigger >> > a recheck. Second, there is no maintainer listed on the Neutron third >> > party >> > drivers page.[2] Because of this, there is effectively no way to get the >> > -1 >> > removed without uploading a new patch and losing current code review >> > votes. >> >> http://stackalytics.com/report/driverlog says its maintainer is >> irc:mestery. last time it happened to me, i asked him to trigger >> recheck and it worked. >> >> YAMAMOTO Takashi >> >> > >> > Can we remove the voting rights for the ODL CI until there is a >> > documented >> > way to trigger rechecks and a public contact on the drivers page for >> > when >> > things go wrong? Getting reviews is already hard enough, let alone when >> > there is a -1 in the 'verified' column. >> > >> > 1. https://review.openstack.org/#/c/116187/ >> > 2. >> > >> > https://wiki.openstack.org/wiki/Neutron_Plugins_and_Drivers#Existing_Plugin >> > >> > -- >> > Kevin Benton >> >> ___ >> OpenStack-dev mailing list >> OpenStack-dev@lists.openstack.org >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > -- > Kevin Benton > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [third party][neutron] - OpenDaylight CI and -1 voting
Thank you YAMAMOTO. I didn't think to look at stackalytics. Kyle, can you list yourself on the wiki? I don't want to do it in case there is someone else doing that job full time. Also, is there a re-trigger phrase that you can document on the Wiki or in the message body the CI posts to the reviews? Thanks, Kevin Benton On Mon, Sep 1, 2014 at 8:08 PM, YAMAMOTO Takashi wrote: > > I have had multiple occasions where the OpenDaylight CI will vote a -1 > on a > > patch for something completely unrelated (e.g. [1]). This would be fine > > except for two issues. First, there doesn't appear to be any way to > trigger > > a recheck. Second, there is no maintainer listed on the Neutron third > party > > drivers page.[2] Because of this, there is effectively no way to get the > -1 > > removed without uploading a new patch and losing current code review > votes. > > http://stackalytics.com/report/driverlog says its maintainer is > irc:mestery. last time it happened to me, i asked him to trigger > recheck and it worked. > > YAMAMOTO Takashi > > > > > Can we remove the voting rights for the ODL CI until there is a > documented > > way to trigger rechecks and a public contact on the drivers page for when > > things go wrong? Getting reviews is already hard enough, let alone when > > there is a -1 in the 'verified' column. > > > > 1. https://review.openstack.org/#/c/116187/ > > 2. > > > https://wiki.openstack.org/wiki/Neutron_Plugins_and_Drivers#Existing_Plugin > > > > -- > > Kevin Benton > > ___ > OpenStack-dev mailing list > OpenStack-dev@lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Kevin Benton ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [third party][neutron] - OpenDaylight CI and -1 voting
> I have had multiple occasions where the OpenDaylight CI will vote a -1 on a > patch for something completely unrelated (e.g. [1]). This would be fine > except for two issues. First, there doesn't appear to be any way to trigger > a recheck. Second, there is no maintainer listed on the Neutron third party > drivers page.[2] Because of this, there is effectively no way to get the -1 > removed without uploading a new patch and losing current code review votes. http://stackalytics.com/report/driverlog says its maintainer is irc:mestery. last time it happened to me, i asked him to trigger recheck and it worked. YAMAMOTO Takashi > > Can we remove the voting rights for the ODL CI until there is a documented > way to trigger rechecks and a public contact on the drivers page for when > things go wrong? Getting reviews is already hard enough, let alone when > there is a -1 in the 'verified' column. > > 1. https://review.openstack.org/#/c/116187/ > 2. > https://wiki.openstack.org/wiki/Neutron_Plugins_and_Drivers#Existing_Plugin > > -- > Kevin Benton ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
