Re: [openstack-dev] Gerrit tools
On Sun, Oct 20, 2013 at 05:01:23AM +, Joshua Harlow wrote: I created some gerrit tools that I think others might find useful. https://github.com/harlowja/gerrit_view The neat one there is a curses based real time gerrit review receiver that uses a similar mechanism as the gerrit irc bot to sit on the gerrit event queue and receive events. Actually, from my POV, the neat one there is the qgerrit script - I had no idea you could query this info so easily. I've done some work on it to allow you to filter based on project name, commit message string, approval flags, and best of all, file path changed. I also improved the date display to make it clearer how old patches are, which may help people prioritize reviews for oldest stuff. With this, I can now finally keep an eye on any change which impacts the libvirt driver code: eg to see all code touching 'nova/virt/libvirt', which has not been -1'd by jenkins $ qgerrit -f url -f subject:100 -f approvals -f lastUpdated -f createdOn -p openstack/nova -a v1 nova/virt/libvirt ++---+--+--+-+ | URL| Subject | Created | Updated | Approvals | ++---+--+--+-+ | https://review.openstack.org/33409 | Adding image multiple location support | 127 days | 17 hours | v=1 c=-1,1 | | https://review.openstack.org/35303 | Stop, Rescue, and Delete should give guest a chance to shutdown | 112 days | 2 hours | v=1,1 c=-1 | | https://review.openstack.org/35760 | Added monitor (e.g. CPU) to monitor and collect data | 110 days | 18 hours | v=1,1 c=-1,-1 | | https://review.openstack.org/39929 | Port to oslo.messaging | 82 days | 7 hours | v=1,1 | | https://review.openstack.org/43984 | Call baselineCPU for full feature list | 56 days | 1 day| v=1,1 c=-1,1,1,1| | https://review.openstack.org/44359 | Wait for files to be accessible when migrating| 54 days | 2 days | v=1 c=1,1,1 | | https://review.openstack.org/45993 | Remove multipath mapping device descriptor| 42 days | 4 hours | v=1,1 c=-1 | | https://review.openstack.org/46055 | Remove dup of LibvirtISCSIVolumeDriver in LibvirtISERVolumeDriver | 42 days | 18 hours | v=1,1 c=2 | | https://review.openstack.org/48246 | Disconnect from iSCSI volume sessions after live migration| 28 days | 5 days | v=1 | | https://review.openstack.org/48362 | Fixing ephemeral disk creation. | 27 days | 16 hours | v=1,1 c=2 | | https://review.openstack.org/49329 | Add unsafe flag to libvirt live migration call. | 21 days | 6 days | v=1,1 c=-1,-1,1,1,1 | | https://review.openstack.org/50857 | Apply six for metaclass | 13 days | 6 hours | v=1,1 | | https://review.openstack.org/51193 | clean up numeric expressions with byte constants | 12 days | 9 hours | v=1 | | https://review.openstack.org/51282 | nova.exception does not have a ProcessExecutionError | 11 days | 21 hours | v=1,1 | | https://review.openstack.org/51287 | Remove vim header from from nova/virt | 11 days | 2 days | v=1,1 c=-1,-1 | | https://review.openstack.org/51718 | libvirt: Fix spurious backing file existence check. | 8 days | 5 days | v=1 c=1 | | https://review.openstack.org/52184 | Reply with a meaningful exception, when libvirt connection is broken. | 6 days | 16 hours | v=1,1 c=2 | | https://review.openstack.org/52363 | Remove unnecessary steps for cold snapshots | 6 days | 45 mins | v=1,1 c=-1 | | https://review.openstack.org/52401 | make libvirt driver get_connection thread-safe| 5 days | 3 hours | v=1,1 | | https://review.openstack.org/52581 | Add context as parameter for resume | 5 days | 2 days | v=1,1,1 c=1,1 | | https://review.openstack.org/52777 | Optimize libvirt live migration workflow at source| 3 days | 1 day| v=1,1 | | https://review.openstack.org/52807 | Create image again when resize revert a VM with image type as LVM | 3 days | 3 days | v=1,1 | | https://review.openstack.org/53069 | Fix lxc
Re: [openstack-dev] Gerrit tools
Daniel P. Berrange berra...@redhat.com writes: Actually, from my POV, the neat one there is the qgerrit script - I had no idea you could query this info so easily. FYI the query syntax for SSH and the web is the same, so you can also make a bookmark for a query like that. The search syntax is here: https://review.openstack.org/Documentation/user-search.html In the next version of Gerrit, you can actually make a dashboard based on such queries. However, note the following in the docs about the file operator: Currently this operator is only available on a watched project and may not be used in the search bar. -Jim ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Gerrit tools
Wow, awesomeness! I'll put out a 0.2 on pypi when u are ready with that, very cool. Sent from my really tiny device... On Oct 23, 2013, at 7:12 AM, Daniel P. Berrange berra...@redhat.com wrote: On Sun, Oct 20, 2013 at 05:01:23AM +, Joshua Harlow wrote: I created some gerrit tools that I think others might find useful. https://github.com/harlowja/gerrit_view The neat one there is a curses based real time gerrit review receiver that uses a similar mechanism as the gerrit irc bot to sit on the gerrit event queue and receive events. Actually, from my POV, the neat one there is the qgerrit script - I had no idea you could query this info so easily. I've done some work on it to allow you to filter based on project name, commit message string, approval flags, and best of all, file path changed. I also improved the date display to make it clearer how old patches are, which may help people prioritize reviews for oldest stuff. With this, I can now finally keep an eye on any change which impacts the libvirt driver code: eg to see all code touching 'nova/virt/libvirt', which has not been -1'd by jenkins $ qgerrit -f url -f subject:100 -f approvals -f lastUpdated -f createdOn -p openstack/nova -a v1 nova/virt/libvirt ++---+--+--+-+ | URL| Subject | Created | Updated | Approvals | ++---+--+--+-+ | https://review.openstack.org/33409 | Adding image multiple location support | 127 days | 17 hours | v=1 c=-1,1 | | https://review.openstack.org/35303 | Stop, Rescue, and Delete should give guest a chance to shutdown | 112 days | 2 hours | v=1,1 c=-1 | | https://review.openstack.org/35760 | Added monitor (e.g. CPU) to monitor and collect data | 110 days | 18 hours | v=1,1 c=-1,-1 | | https://review.openstack.org/39929 | Port to oslo.messaging | 82 days | 7 hours | v=1,1 | | https://review.openstack.org/43984 | Call baselineCPU for full feature list | 56 days | 1 day| v=1,1 c=-1,1,1,1| | https://review.openstack.org/44359 | Wait for files to be accessible when migrating| 54 days | 2 days | v=1 c=1,1,1 | | https://review.openstack.org/45993 | Remove multipath mapping device descriptor| 42 days | 4 hours | v=1,1 c=-1 | | https://review.openstack.org/46055 | Remove dup of LibvirtISCSIVolumeDriver in LibvirtISERVolumeDriver | 42 days | 18 hours | v=1,1 c=2 | | https://review.openstack.org/48246 | Disconnect from iSCSI volume sessions after live migration| 28 days | 5 days | v=1 | | https://review.openstack.org/48362 | Fixing ephemeral disk creation. | 27 days | 16 hours | v=1,1 c=2 | | https://review.openstack.org/49329 | Add unsafe flag to libvirt live migration call. | 21 days | 6 days | v=1,1 c=-1,-1,1,1,1 | | https://review.openstack.org/50857 | Apply six for metaclass | 13 days | 6 hours | v=1,1 | | https://review.openstack.org/51193 | clean up numeric expressions with byte constants | 12 days | 9 hours | v=1 | | https://review.openstack.org/51282 | nova.exception does not have a ProcessExecutionError | 11 days | 21 hours | v=1,1 | | https://review.openstack.org/51287 | Remove vim header from from nova/virt | 11 days | 2 days | v=1,1 c=-1,-1 | | https://review.openstack.org/51718 | libvirt: Fix spurious backing file existence check. | 8 days | 5 days | v=1 c=1 | | https://review.openstack.org/52184 | Reply with a meaningful exception, when libvirt connection is broken. | 6 days | 16 hours | v=1,1 c=2 | | https://review.openstack.org/52363 | Remove unnecessary steps for cold snapshots | 6 days | 45 mins | v=1,1 c=-1 | | https://review.openstack.org/52401 | make libvirt driver get_connection thread-safe| 5 days | 3 hours | v=1,1 | | https://review.openstack.org/52581 | Add context as parameter for resume | 5 days | 2 days | v=1,1,1 c=1,1 | | https://review.openstack.org/52777 | Optimize libvirt live migration workflow at
Re: [openstack-dev] Gerrit tools
On Wed, Oct 23, 2013 at 03:05:32PM +, James E. Blair wrote: Daniel P. Berrange berra...@redhat.com writes: Actually, from my POV, the neat one there is the qgerrit script - I had no idea you could query this info so easily. FYI the query syntax for SSH and the web is the same, so you can also make a bookmark for a query like that. The search syntax is here: https://review.openstack.org/Documentation/user-search.html In the next version of Gerrit, you can actually make a dashboard based on such queries. However, note the following in the docs about the file operator: Currently this operator is only available on a watched project and may not be used in the search bar. Yeah, I'm only too well aware of that limitation - makes it basically useless to me :-( Also I can't see a way to filter based on the jenkins code review +1/+2/-1/-2 flags Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Gerrit tools
Thanks, did some cleanup and pushed a newer version. https://pypi.python.org/pypi/gerrit-view/0.1.1 -Josh On 10/23/13 8:16 AM, Joshua Harlow harlo...@yahoo-inc.com wrote: Wow, awesomeness! I'll put out a 0.2 on pypi when u are ready with that, very cool. Sent from my really tiny device... On Oct 23, 2013, at 7:12 AM, Daniel P. Berrange berra...@redhat.com wrote: On Sun, Oct 20, 2013 at 05:01:23AM +, Joshua Harlow wrote: I created some gerrit tools that I think others might find useful. https://github.com/harlowja/gerrit_view The neat one there is a curses based real time gerrit review receiver that uses a similar mechanism as the gerrit irc bot to sit on the gerrit event queue and receive events. Actually, from my POV, the neat one there is the qgerrit script - I had no idea you could query this info so easily. I've done some work on it to allow you to filter based on project name, commit message string, approval flags, and best of all, file path changed. I also improved the date display to make it clearer how old patches are, which may help people prioritize reviews for oldest stuff. With this, I can now finally keep an eye on any change which impacts the libvirt driver code: eg to see all code touching 'nova/virt/libvirt', which has not been -1'd by jenkins $ qgerrit -f url -f subject:100 -f approvals -f lastUpdated -f createdOn -p openstack/nova -a v1 nova/virt/libvirt ++--- +--+--+-- ---+ | URL| Subject | Created | Updated | Approvals | ++--- +--+--+-- ---+ | https://review.openstack.org/33409 | Adding image multiple location support| 127 days | 17 hours | v=1 c=-1,1 | | https://review.openstack.org/35303 | Stop, Rescue, and Delete should give guest a chance to shutdown | 112 days | 2 hours | v=1,1 c=-1 | | https://review.openstack.org/35760 | Added monitor (e.g. CPU) to monitor and collect data | 110 days | 18 hours | v=1,1 c=-1,-1 | | https://review.openstack.org/39929 | Port to oslo.messaging | 82 days | 7 hours | v=1,1 | | https://review.openstack.org/43984 | Call baselineCPU for full feature list| 56 days | 1 day| v=1,1 c=-1,1,1,1| | https://review.openstack.org/44359 | Wait for files to be accessible when migrating| 54 days | 2 days | v=1 c=1,1,1 | | https://review.openstack.org/45993 | Remove multipath mapping device descriptor| 42 days | 4 hours | v=1,1 c=-1 | | https://review.openstack.org/46055 | Remove dup of LibvirtISCSIVolumeDriver in LibvirtISERVolumeDriver | 42 days | 18 hours | v=1,1 c=2 | | https://review.openstack.org/48246 | Disconnect from iSCSI volume sessions after live migration| 28 days | 5 days | v=1 | | https://review.openstack.org/48362 | Fixing ephemeral disk creation. | 27 days | 16 hours | v=1,1 c=2 | | https://review.openstack.org/49329 | Add unsafe flag to libvirt live migration call. | 21 days | 6 days | v=1,1 c=-1,-1,1,1,1 | | https://review.openstack.org/50857 | Apply six for metaclass | 13 days | 6 hours | v=1,1 | | https://review.openstack.org/51193 | clean up numeric expressions with byte constants | 12 days | 9 hours | v=1 | | https://review.openstack.org/51282 | nova.exception does not have a ProcessExecutionError | 11 days | 21 hours | v=1,1 | | https://review.openstack.org/51287 | Remove vim header from from nova/virt | 11 days | 2 days | v=1,1 c=-1,-1 | | https://review.openstack.org/51718 | libvirt: Fix spurious backing file existence check. | 8 days | 5 days | v=1 c=1 | | https://review.openstack.org/52184 | Reply with a meaningful exception, when libvirt connection is broken. | 6 days | 16 hours | v=1,1 c=2 | | https://review.openstack.org/52363 | Remove unnecessary steps for cold snapshots | 6 days | 45 mins | v=1,1 c=-1 | | https://review.openstack.org/52401 | make libvirt driver get_connection thread-safe| 5 days | 3 hours | v=1,1 | | https://review.openstack.org/52581 | Add context as parameter for resume | 5 days | 2 days | v=1,1,1 c=1,1 | | https://review.openstack.org/52777 |
Re: [openstack-dev] Gerrit tools
On 21/10/13 15:41 +0200, Chmouel Boudjnah wrote: On Mon, Oct 21, 2013 at 3:03 PM, Flavio Percoco fla...@redhat.com wrote: Also realize that OpenStack maintains gerritlib - https://github.com/ openstack-infra/gerritlib Which anyone can contribute to (and is the code that every message posted back to gerrit by a bot users). It would actually be nice to enhance gerritlib if there were enough features missing that are in python-gerrit. Yup, that's part of the plan, python-gerrit rewrites a lot of stuff, though. It seems that gerritlib is using SSH commands, isn't that the plans is to have a gerrit with the full REST api enabled in the future without needing to have to spawn ssh commands for every calls? The last time I checked the 'REST' api, I think there were some pieces missing, I could be wrong, though. I'll take another look. Cheers, FF Chmouel. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- @flaper87 Flavio Percoco ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Gerrit tools
On 21/10/13 15:55 +, Joshua Harlow wrote: I am using gerritlib in the curses ui; seems to work nicely. Only 1 thing that I don't like so much is that it silences connection/other errors from what I can tell. See _run() method in https://github.com/openstack-infra/gerritlib/blob/master/gerritlib/gerrit.py I started migrating some of the OpenStack tools to python-gerrit a couple of months ago, I still have that code somewhere in my laptop, I hope. I think that gerritlib API could be improved a lot from python-gerrit, plus query combinations in gerritlib are a bit limited due to how they're expressed there. At least the last time I checked. I'll take some time in the next few weeks to work on that. @Joshua, do you mind taking a look at python-gerrit and provide some feedback or use it? :D Cheers, FF Otherwise pretty easy to use. Sent from my really tiny device... On Oct 21, 2013, at 4:46 AM, Sean Dague s...@dague.net wrote: On 10/21/2013 04:04 AM, Flavio Percoco wrote: On 20/10/13 05:01 +, Joshua Harlow wrote: I created some gerrit tools that I think others might find useful. https://github.com/harlowja/gerrit_view I worked on this Python library for Gerrit[0] a couple of months ago and I've been using it for this gerrit-cli[1] tool. I was wondering if you'd like to migrate your Gerrit queries and make them use python-gerrit instead? I can do that for you. [0] https://github.com/FlaPer87/python-gerrit [1] https://github.com/FlaPer87/gerrit-cli BTW, Big +1 for the curses UI! Also realize that OpenStack maintains gerritlib - https://github.com/openstack-infra/gerritlib Which anyone can contribute to (and is the code that every message posted back to gerrit by a bot users). It would actually be nice to enhance gerritlib if there were enough features missing that are in python-gerrit. -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- @flaper87 Flavio Percoco ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Gerrit tools
Sure I'll look it over :-) Btw just uploaded: https://pypi.python.org/pypi/gerrit-view Making it easier to install the 2 tools. Have fun! On 10/21/13 11:37 PM, Flavio Percoco fla...@redhat.com wrote: On 21/10/13 15:55 +, Joshua Harlow wrote: I am using gerritlib in the curses ui; seems to work nicely. Only 1 thing that I don't like so much is that it silences connection/other errors from what I can tell. See _run() method in https://github.com/openstack-infra/gerritlib/blob/master/gerritlib/gerrit .py I started migrating some of the OpenStack tools to python-gerrit a couple of months ago, I still have that code somewhere in my laptop, I hope. I think that gerritlib API could be improved a lot from python-gerrit, plus query combinations in gerritlib are a bit limited due to how they're expressed there. At least the last time I checked. I'll take some time in the next few weeks to work on that. @Joshua, do you mind taking a look at python-gerrit and provide some feedback or use it? :D Cheers, FF Otherwise pretty easy to use. Sent from my really tiny device... On Oct 21, 2013, at 4:46 AM, Sean Dague s...@dague.net wrote: On 10/21/2013 04:04 AM, Flavio Percoco wrote: On 20/10/13 05:01 +, Joshua Harlow wrote: I created some gerrit tools that I think others might find useful. https://github.com/harlowja/gerrit_view I worked on this Python library for Gerrit[0] a couple of months ago and I've been using it for this gerrit-cli[1] tool. I was wondering if you'd like to migrate your Gerrit queries and make them use python-gerrit instead? I can do that for you. [0] https://github.com/FlaPer87/python-gerrit [1] https://github.com/FlaPer87/gerrit-cli BTW, Big +1 for the curses UI! Also realize that OpenStack maintains gerritlib - https://github.com/openstack-infra/gerritlib Which anyone can contribute to (and is the code that every message posted back to gerrit by a bot users). It would actually be nice to enhance gerritlib if there were enough features missing that are in python-gerrit. -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- @flaper87 Flavio Percoco ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Gerrit tools
On 10/21/2013 04:04 AM, Flavio Percoco wrote: On 20/10/13 05:01 +, Joshua Harlow wrote: I created some gerrit tools that I think others might find useful. https://github.com/harlowja/gerrit_view I worked on this Python library for Gerrit[0] a couple of months ago and I've been using it for this gerrit-cli[1] tool. I was wondering if you'd like to migrate your Gerrit queries and make them use python-gerrit instead? I can do that for you. [0] https://github.com/FlaPer87/python-gerrit [1] https://github.com/FlaPer87/gerrit-cli BTW, Big +1 for the curses UI! Also realize that OpenStack maintains gerritlib - https://github.com/openstack-infra/gerritlib Which anyone can contribute to (and is the code that every message posted back to gerrit by a bot users). It would actually be nice to enhance gerritlib if there were enough features missing that are in python-gerrit. -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Gerrit tools
On 21/10/13 07:44 -0400, Sean Dague wrote: On 10/21/2013 04:04 AM, Flavio Percoco wrote: On 20/10/13 05:01 +, Joshua Harlow wrote: I created some gerrit tools that I think others might find useful. https://github.com/harlowja/gerrit_view I worked on this Python library for Gerrit[0] a couple of months ago and I've been using it for this gerrit-cli[1] tool. I was wondering if you'd like to migrate your Gerrit queries and make them use python-gerrit instead? I can do that for you. [0] https://github.com/FlaPer87/python-gerrit [1] https://github.com/FlaPer87/gerrit-cli BTW, Big +1 for the curses UI! Also realize that OpenStack maintains gerritlib - https://github.com/openstack-infra/gerritlib Which anyone can contribute to (and is the code that every message posted back to gerrit by a bot users). It would actually be nice to enhance gerritlib if there were enough features missing that are in python-gerrit. Yup, that's part of the plan, python-gerrit rewrites a lot of stuff, though. Cheers, FF -- @flaper87 Flavio Percoco ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Gerrit tools
On Mon, Oct 21, 2013 at 3:03 PM, Flavio Percoco fla...@redhat.com wrote: Also realize that OpenStack maintains gerritlib - https://github.com/openstack-**infra/gerritlibhttps://github.com/openstack-infra/gerritlib Which anyone can contribute to (and is the code that every message posted back to gerrit by a bot users). It would actually be nice to enhance gerritlib if there were enough features missing that are in python-gerrit. Yup, that's part of the plan, python-gerrit rewrites a lot of stuff, though. It seems that gerritlib is using SSH commands, isn't that the plans is to have a gerrit with the full REST api enabled in the future without needing to have to spawn ssh commands for every calls? Chmouel. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Gerrit tools
I am using gerritlib in the curses ui; seems to work nicely. Only 1 thing that I don't like so much is that it silences connection/other errors from what I can tell. See _run() method in https://github.com/openstack-infra/gerritlib/blob/master/gerritlib/gerrit.py Otherwise pretty easy to use. Sent from my really tiny device... On Oct 21, 2013, at 4:46 AM, Sean Dague s...@dague.net wrote: On 10/21/2013 04:04 AM, Flavio Percoco wrote: On 20/10/13 05:01 +, Joshua Harlow wrote: I created some gerrit tools that I think others might find useful. https://github.com/harlowja/gerrit_view I worked on this Python library for Gerrit[0] a couple of months ago and I've been using it for this gerrit-cli[1] tool. I was wondering if you'd like to migrate your Gerrit queries and make them use python-gerrit instead? I can do that for you. [0] https://github.com/FlaPer87/python-gerrit [1] https://github.com/FlaPer87/gerrit-cli BTW, Big +1 for the curses UI! Also realize that OpenStack maintains gerritlib - https://github.com/openstack-infra/gerritlib Which anyone can contribute to (and is the code that every message posted back to gerrit by a bot users). It would actually be nice to enhance gerritlib if there were enough features missing that are in python-gerrit. -Sean -- Sean Dague http://dague.net ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Gerrit tools
Neat didn't know about this library :) Thx for the +1! Sent from my really tiny device... On Oct 21, 2013, at 1:08 AM, Flavio Percoco fla...@redhat.com wrote: On 20/10/13 05:01 +, Joshua Harlow wrote: I created some gerrit tools that I think others might find useful. https://github.com/harlowja/gerrit_view I worked on this Python library for Gerrit[0] a couple of months ago and I've been using it for this gerrit-cli[1] tool. I was wondering if you'd like to migrate your Gerrit queries and make them use python-gerrit instead? I can do that for you. [0] https://github.com/FlaPer87/python-gerrit [1] https://github.com/FlaPer87/gerrit-cli BTW, Big +1 for the curses UI! Cheers, FF -- @flaper87 Flavio Percoco ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] Gerrit tools
The nice thing about the current ssh is that it is doing push notifications over ssh, if the rest API supported that it would be great; instead of a pull notification via rest. Sent from my really tiny device... On Oct 21, 2013, at 6:48 AM, Chmouel Boudjnah chmo...@enovance.commailto:chmo...@enovance.com wrote: On Mon, Oct 21, 2013 at 3:03 PM, Flavio Percoco fla...@redhat.commailto:fla...@redhat.com wrote: Also realize that OpenStack maintains gerritlib - https://github.com/openstack-infra/gerritlib Which anyone can contribute to (and is the code that every message posted back to gerrit by a bot users). It would actually be nice to enhance gerritlib if there were enough features missing that are in python-gerrit. Yup, that's part of the plan, python-gerrit rewrites a lot of stuff, though. It seems that gerritlib is using SSH commands, isn't that the plans is to have a gerrit with the full REST api enabled in the future without needing to have to spawn ssh commands for every calls? Chmouel. ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.orgmailto:OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
