Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-16 Thread Pete Zaitcev
On Thu, 11 Jun 2015 11:08:55 +0300
Duncan Thomas duncan.tho...@gmail.com wrote:

 There's only one cinder driver using it (nimble storage), and it seems to
 be using only very basic features. There are half a dozen suds forks on
 pipi, or there's pisimplesoap that the debian maintainer recommends. None
 of the above are currently packaged for Ubuntu that I can see, so can
 anybody in-the-know make a reaasoned recommendation as to what to move to?

In instances I had to deal with (talking to VMware), it was easier and
better to roll-your-own with python-xml and libhttp.

-- P

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-15 Thread Joe Gordon
On Sun, Jun 14, 2015 at 10:46 PM, Thomas Goirand z...@debian.org wrote:

 On 06/11/2015 11:31 PM, Nikhil Manchanda wrote:
  Hi Thomas:
 
  I just checked and I don't see suds as a requirement for trove.
  I don't think it should be a requirement for the trove debian package,
  either.
 
  Thanks,
  Nikhil

 Hi,

 I fixed the package and removed the Suggests: python-suds in both Trove
  Ironic. Now there's still the issue in:
 - nova


Nova itself doesn't depend on suds anymore. Oslo.vmware has a suds
dependency, but that is only needed if you are using the vmware virt driver
in nova.

So nova's vmware driver depends on suds (it may be suds-jurko these days),
but not nova in general.



 - cinder
 - oslo.vmware

 It'd be nice to do something about them. As I mentioned, I'll do the
 packaging work for anything that will replace it if needed.

 FYI, I filed bugs:
 https://bugs.launchpad.net/oslo.vmware/+bug/1465015
 https://bugs.launchpad.net/nova/+bug/1465016
 https://bugs.launchpad.net/cinder/+bug/1465017

 Cheers,

 Thomas Goirand (zigo)


 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-15 Thread Davanum Srinivas
Thomas,

Is anyone willing to the work needed to get the existing Nova vmware
driver scenarios with any alternate python library acceptable to
Debian? If not, this discussion is moot.

-- dims

On Mon, Jun 15, 2015 at 9:16 AM, Thomas Goirand z...@debian.org wrote:
 On 06/15/2015 11:31 AM, Joe Gordon wrote:
 Nova itself doesn't depend on suds anymore.

 A quick grep still shows references to suds (that's in Kilo, but the
 master branch shows similar results):

 etc/nova/logging_sample.conf:qualname = suds

 nova/tests/unit/test_hacking.py: def
 fake_suds_context(calls={}):

 nova/tests/unit/virt/vmwareapi/test_vim_util.py:with
 stubs.fake_suds_context(calls):

 nova/tests/unit/virt/vmwareapi/stubs.py:def fake_suds_context(calls=None):

 nova/tests/unit/virt/vmwareapi/stubs.py:Generate a suds client
 which automatically mocks all SOAP method calls.

 nova/tests/unit/virt/vmwareapi/stubs.py:
 mock.patch('suds.client.Client', fake_client),

 nova/tests/unit/virt/vmwareapi/test_driver_api.py:import suds

 nova/tests/unit/virt/vmwareapi/test_driver_api.py:
 mock.patch.object(suds.client.Client,

 nova/tests/unit/virt/vmwareapi/fake.py:Fake factory class for the
 suds client.

 nova/tests/unit/virt/vmwareapi/fake.py:Initializes the suds
 client object, sets the service content

 nova/virt/vmwareapi/vim_util.py:import suds

 nova/virt/vmwareapi/vim_util.py:for k, v in
 suds.sudsobject.asdict(obj).iteritems():

 nova/config.py:   'qpid=WARN', 'sqlalchemy=WARN',
 'suds=INFO',

 test-requirements.txt:suds=0.4


 Oslo.vmware has a suds
 dependency, but that is only needed if you are using the vmware virt
 driver in nova.

 It's used in unit tests, no?

 So nova's vmware driver depends on suds (it may be suds-jurko these
 days)

 As I wrote, suds-jurko isn't acceptable either, as it's also not
 maintained upstream.

 but not nova in general.

 If we don't want suds, we don't want suds. Not just it's only in some
 parts kind of answer. Especially, it should appear in
 tests-requirements.txt and in vmwareapi unit tests. Don't you think?

 Cheers,

 Thomas Goirand (zigo)


 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-15 Thread Joe Gordon
On Mon, Jun 15, 2015 at 4:16 PM, Thomas Goirand z...@debian.org wrote:

 On 06/15/2015 11:31 AM, Joe Gordon wrote:
  Nova itself doesn't depend on suds anymore.

 A quick grep still shows references to suds (that's in Kilo, but the
 master branch shows similar results):


Your git repo is out of date.


https://github.com/openstack/nova/search?utf8=%E2%9C%93q=suds



 etc/nova/logging_sample.conf:qualname = suds


this doesn't actually require suds.

We can remove this line



 nova/tests/unit/test_hacking.py: def
 fake_suds_context(calls={}):

 nova/tests/unit/virt/vmwareapi/test_vim_util.py:with
 stubs.fake_suds_context(calls):

 nova/tests/unit/virt/vmwareapi/stubs.py:def fake_suds_context(calls=None):

 nova/tests/unit/virt/vmwareapi/stubs.py:Generate a suds client
 which automatically mocks all SOAP method calls.

 nova/tests/unit/virt/vmwareapi/stubs.py:
 mock.patch('suds.client.Client', fake_client),

 nova/tests/unit/virt/vmwareapi/test_driver_api.py:import suds

 nova/tests/unit/virt/vmwareapi/test_driver_api.py:
 mock.patch.object(suds.client.Client,

 nova/tests/unit/virt/vmwareapi/fake.py:Fake factory class for the
 suds client.

 nova/tests/unit/virt/vmwareapi/fake.py:Initializes the suds
 client object, sets the service content

 nova/virt/vmwareapi/vim_util.py:import suds


this was removed in https://review.openstack.org/#/c/181554/



 nova/virt/vmwareapi/vim_util.py:for k, v in
 suds.sudsobject.asdict(obj).iteritems():

 nova/config.py:   'qpid=WARN', 'sqlalchemy=WARN',
 'suds=INFO',


We missed this, so here is a patch https://review.openstack.org/#/c/191795/



 test-requirements.txt:suds=0.4


  Oslo.vmware has a suds
  dependency, but that is only needed if you are using the vmware virt
  driver in nova.

 It's used in unit tests, no?


as explained above, nope.



  So nova's vmware driver depends on suds (it may be suds-jurko these
  days)

 As I wrote, suds-jurko isn't acceptable either, as it's also not
 maintained upstream.


Agreed, we have more work to do.



  but not nova in general.

 If we don't want suds, we don't want suds. Not just it's only in some
 parts kind of answer. Especially, it should appear in
 tests-requirements.txt and in vmwareapi unit tests. Don't you think?

 Cheers,

 Thomas Goirand (zigo)


 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-15 Thread Thomas Goirand
On 06/15/2015 11:31 AM, Joe Gordon wrote:
 Nova itself doesn't depend on suds anymore.

A quick grep still shows references to suds (that's in Kilo, but the
master branch shows similar results):

etc/nova/logging_sample.conf:qualname = suds

nova/tests/unit/test_hacking.py: def
fake_suds_context(calls={}):

nova/tests/unit/virt/vmwareapi/test_vim_util.py:with
stubs.fake_suds_context(calls):

nova/tests/unit/virt/vmwareapi/stubs.py:def fake_suds_context(calls=None):

nova/tests/unit/virt/vmwareapi/stubs.py:Generate a suds client
which automatically mocks all SOAP method calls.

nova/tests/unit/virt/vmwareapi/stubs.py:
mock.patch('suds.client.Client', fake_client),

nova/tests/unit/virt/vmwareapi/test_driver_api.py:import suds

nova/tests/unit/virt/vmwareapi/test_driver_api.py:
mock.patch.object(suds.client.Client,

nova/tests/unit/virt/vmwareapi/fake.py:Fake factory class for the
suds client.

nova/tests/unit/virt/vmwareapi/fake.py:Initializes the suds
client object, sets the service content

nova/virt/vmwareapi/vim_util.py:import suds

nova/virt/vmwareapi/vim_util.py:for k, v in
suds.sudsobject.asdict(obj).iteritems():

nova/config.py:   'qpid=WARN', 'sqlalchemy=WARN',
'suds=INFO',

test-requirements.txt:suds=0.4


 Oslo.vmware has a suds
 dependency, but that is only needed if you are using the vmware virt
 driver in nova.

It's used in unit tests, no?

 So nova's vmware driver depends on suds (it may be suds-jurko these
 days)

As I wrote, suds-jurko isn't acceptable either, as it's also not
maintained upstream.

 but not nova in general.

If we don't want suds, we don't want suds. Not just it's only in some
parts kind of answer. Especially, it should appear in
tests-requirements.txt and in vmwareapi unit tests. Don't you think?

Cheers,

Thomas Goirand (zigo)


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-15 Thread Thomas Goirand
On 06/14/2015 03:46 PM, Thomas Goirand wrote:
 On 06/11/2015 11:31 PM, Nikhil Manchanda wrote:
 Hi Thomas:

 I just checked and I don't see suds as a requirement for trove.
 I don't think it should be a requirement for the trove debian package,
 either.

 Thanks,
 Nikhil
 
 Hi,
 
 I fixed the package and removed the Suggests: python-suds in both Trove
  Ironic. Now there's still the issue in:
 - nova
 - cinder
 - oslo.vmware
 
 It'd be nice to do something about them. As I mentioned, I'll do the
 packaging work for anything that will replace it if needed.
 
 FYI, I filed bugs:
 https://bugs.launchpad.net/oslo.vmware/+bug/1465015
 https://bugs.launchpad.net/nova/+bug/1465016
 https://bugs.launchpad.net/cinder/+bug/1465017
 
 Cheers,
 
 Thomas Goirand (zigo)

Just to make it clear to everyone: suds-jurko is as badly maintained as
suds, and switching to that isn't acceptable either. The maintainer of
the suds package in Debian tried to contact Jurko, but never got a reply
at all. Multiple attempts were done, since summer 2014.

Instead, something like pysimplesoap is one possible alternative, but it
has a different API.

Cheers,

Thomas Goirand (zigo)


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-14 Thread Thomas Goirand
On 06/11/2015 10:08 AM, Duncan Thomas wrote:
 On 11 June 2015 at 10:26, Thomas Goirand z...@debian.org
 mailto:z...@debian.org wrote:
 
 Hi,
 
 The current maintainer of suds in Debian sent bug reports against all
 packages depending on it. We would like to get rid of suds completely.
 
 See:
 
 https://bugs.debian.org/788080
 https://bugs.debian.org/788081
 https://bugs.debian.org/788083
 https://bugs.debian.org/788085
 https://bugs.debian.org/788088
 
 Affected projects are: cinder, nova, trove, ironic, and finally
 oslo.vmware.
 
 So, are we moving to suds-jurko? Or anything else?
 
 Cheers,
 
 Thomas Goirand (zigo)

 There's only one cinder driver using it (nimble storage), and it seems
 to be using only very basic features. There are half a dozen suds forks
 on pipi, or there's pisimplesoap that the debian maintainer recommends.
 None of the above are currently packaged for Ubuntu that I can see, so
 can anybody in-the-know make a reaasoned recommendation as to what to
 move to?

I can do the work of packaging the module that we choose.

Thomas Goirand (zigo)


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-14 Thread Thomas Goirand
On 06/11/2015 11:31 PM, Nikhil Manchanda wrote:
 Hi Thomas:
 
 I just checked and I don't see suds as a requirement for trove.
 I don't think it should be a requirement for the trove debian package,
 either.
 
 Thanks,
 Nikhil

Hi,

I fixed the package and removed the Suggests: python-suds in both Trove
 Ironic. Now there's still the issue in:
- nova
- cinder
- oslo.vmware

It'd be nice to do something about them. As I mentioned, I'll do the
packaging work for anything that will replace it if needed.

FYI, I filed bugs:
https://bugs.launchpad.net/oslo.vmware/+bug/1465015
https://bugs.launchpad.net/nova/+bug/1465016
https://bugs.launchpad.net/cinder/+bug/1465017

Cheers,

Thomas Goirand (zigo)


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-11 Thread Davanum Srinivas
Thomas,

oslo.vmware (master) moved to suds-jurko for both python2 and python3.
we deleted references in nova and other places directly to suds and
rely on transitively loading the suds-jurko specified from
oslo.vmware. cinder (master) has a reference to suds-jurko as well.

-- dims

On Thu, Jun 11, 2015 at 3:26 AM, Thomas Goirand z...@debian.org wrote:
 Hi,

 The current maintainer of suds in Debian sent bug reports against all
 packages depending on it. We would like to get rid of suds completely.

 See:

 https://bugs.debian.org/788080
 https://bugs.debian.org/788081
 https://bugs.debian.org/788083
 https://bugs.debian.org/788085
 https://bugs.debian.org/788088

 Affected projects are: cinder, nova, trove, ironic, and finally oslo.vmware.

 So, are we moving to suds-jurko? Or anything else?

 Cheers,

 Thomas Goirand (zigo)

 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Davanum Srinivas :: https://twitter.com/dims

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-11 Thread Nikhil Manchanda
Hi Thomas:

I just checked and I don't see suds as a requirement for trove.
I don't think it should be a requirement for the trove debian package,
either.

Thanks,
Nikhil


On Thu, Jun 11, 2015 at 3:03 AM, Davanum Srinivas dava...@gmail.com wrote:

 Thomas,

 oslo.vmware (master) moved to suds-jurko for both python2 and python3.
 we deleted references in nova and other places directly to suds and
 rely on transitively loading the suds-jurko specified from
 oslo.vmware. cinder (master) has a reference to suds-jurko as well.

 -- dims

 On Thu, Jun 11, 2015 at 3:26 AM, Thomas Goirand z...@debian.org wrote:
  Hi,
 
  The current maintainer of suds in Debian sent bug reports against all
  packages depending on it. We would like to get rid of suds completely.
 
  See:
 
  https://bugs.debian.org/788080
  https://bugs.debian.org/788081
  https://bugs.debian.org/788083
  https://bugs.debian.org/788085
  https://bugs.debian.org/788088
 
  Affected projects are: cinder, nova, trove, ironic, and finally
 oslo.vmware.
 
  So, are we moving to suds-jurko? Or anything else?
 
  Cheers,
 
  Thomas Goirand (zigo)
 
 
 __
  OpenStack Development Mailing List (not for usage questions)
  Unsubscribe:
 openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
  http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



 --
 Davanum Srinivas :: https://twitter.com/dims

 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] Getting rid of suds, which is unmaintained, and which we want out of Debian

2015-06-11 Thread Duncan Thomas
There's only one cinder driver using it (nimble storage), and it seems to
be using only very basic features. There are half a dozen suds forks on
pipi, or there's pisimplesoap that the debian maintainer recommends. None
of the above are currently packaged for Ubuntu that I can see, so can
anybody in-the-know make a reaasoned recommendation as to what to move to?

On 11 June 2015 at 10:26, Thomas Goirand z...@debian.org wrote:

 Hi,

 The current maintainer of suds in Debian sent bug reports against all
 packages depending on it. We would like to get rid of suds completely.

 See:

 https://bugs.debian.org/788080
 https://bugs.debian.org/788081
 https://bugs.debian.org/788083
 https://bugs.debian.org/788085
 https://bugs.debian.org/788088

 Affected projects are: cinder, nova, trove, ironic, and finally
 oslo.vmware.

 So, are we moving to suds-jurko? Or anything else?

 Cheers,

 Thomas Goirand (zigo)

 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




-- 
Duncan Thomas
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev